From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Fri, 23 Aug 2019 15:23:27 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 15:23:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="330853252" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga004.jf.intel.com with ESMTP; 23 Aug 2019 15:23:26 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 15:23:26 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX121.amr.corp.intel.com ([169.254.10.57]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 15:23:26 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build Failures Thread-Index: AQHVWfj41EGWHrH2iUKKB2y3zFydh6cJTf6A Date: Fri, 23 Aug 2019 22:23:25 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE480D3@ORSMSX114.amr.corp.intel.com> References: <20190823212235.26988-1-michael.a.kubacki@intel.com> <20190823212235.26988-2-michael.a.kubacki@intel.com> In-Reply-To: <20190823212235.26988-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzg3OTUwNjEtMzczNS00OTNmLTg2MjktMGUyYmZiYTNiNTIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY0wwa2k2QzRwVFlIeTBhMmRQQ0xLVTZJZFc0Ym5KUENRbnNJN2p3VVNvSjAySTJaQkErYllsVVdWK2RlQ1JPSSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pch/Include/ConfigBlock/HdAudioConfig.h - I think like it would make more s= ense if Uefi.h is included first. With that change... Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Friday, August 23, 2019 2:23 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-devel] [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg:= Fix GCC Build Failures REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2124 Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.= h | 2 ++ Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h = | 1 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPchPoli= cyLib.c | 2 -- Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.c = | 1 + 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/Hd= AudioConfig.h b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/= HdAudioConfig.h index a810d4f1fc..e2c8730f38 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioCo= nfig.h +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudio +++ Config.h @@ -9,7 +9,9 @@ #ifndef _HDAUDIO_CONFIG_H_ #define _HDAUDIO_CONFIG_H_ =20 +#include #include +#include =20 #define HDAUDIO_PREMEM_CONFIG_REVISION 1 #define HDAUDIO_CONFIG_REVISION= 2 diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/Gpio= Lib.h b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h index 25def24fca..ff76e7c60f 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Library/GpioLib.h @@ -11,6 +11,7 @@ #define _GPIO_LIB_H_ =20 #include +#include =20 #define GPIO_NAME_LENGTH_MAX 32 =20 diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLi= b/PeiPchPolicyLib.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPch= PolicyLib/PeiPchPolicyLib.c index 2a1da20667..ece0be8158 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/PeiPc= hPolicyLib.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiPchPolicyLib/Pei +++ PchPolicyLib.c @@ -353,10 +353,8 @@ LoadLanConfigDefault ( ) { PCH_LAN_CONFIG *LanConfig; - UINT16 LpcDid; =20 LanConfig =3D ConfigBlockPointer; - LpcDid =3D PchGetLpcDid (); =20 DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Name =3D %g\n", &LanConf= ig->Header.GuidHob.Name)); DEBUG ((DEBUG_INFO, "LanConfig->Header.GuidHob.Header.HobLength =3D 0x%= x\n", LanConfig->Header.GuidHob.Header.HobLength)); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaI= nitDxe.c b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInit= Dxe.c index d646e60618..e6980f9a65 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDxe.= c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/SystemAgent/SaInit/Dxe/SaInitDx +++ e.c @@ -41,6 +41,7 @@ SaInitEntryPointDxe ( SaInitEntryPoint (); =20 Status =3D SaAcpiInit (ImageHandle); + ASSERT_EFI_ERROR (Status); =20 /// /// Create PCI Enumeration Completed callback for SA -- 2.16.2.windows.1