Hi All,
It is possible to use git send-email with an exchange server by using
DavMail as a relay. I would recommend that we encourage those whom work at a company which does not allow outbound SMTP connections to send their edk2 patches using this method.
Here is how you configure it:
- Figure out what your exchange server’s network name is:
CTRL + Right Click on the Outlook icon in your system tray, select Connection Status…
In the status window there might be a few connections, on my network there was connections to an exchange gateway, and then a single connection to the actual exchange server that hosts my personal mailbox, use that server.
- Download and install
DavMail. On Windows run the .exe as administrator.
- It looks like the .exe launchers that come with the Windows version of DavMail and old and intended for Java 7 (which is no longer supported and there are licensing issues.) I was able to run DavMail
fine using the RedHat supported
OpenJDK 11 binaries by opening a Windows command prompt and running the following commands:
C:\>cd "Program Files\DavMail\
C:\Program Files\DavMail>java -jar davmail.jar
- In the DavMail settings dialog, choose Exchange Protocol = EWS and enter the server name from Step #1 using the following format:
https://<server_name>/owa
- Run these commands in Git Bash:
git config --global sendemail.smtpserver localhost:1025
git config --global sendemail.smtpuser <your_email_address>
For example:
git config --global sendemail.smtpuser nathaniel.l.desimone@intel.com
- Git send-email should now work. It will popup a dialog box prompting you for a password. Use your outlook/windows password.
Thanks,
Nate
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Thursday, August 29, 2019 10:02 AM
To: devel@edk2.groups.io; lersek@redhat.com; Leif Lindholm <leif.lindholm@linaro.org>
Cc: Gao, Liming <liming.gao@intel.com>; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Jayanth.Raghuram@dell.com; 'Andrew Fish (afish@apple.com)' <afish@apple.com>; Wei.G.Liu@dell.com
Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io>
On Behalf Of Laszlo
> Ersek
> Sent: Thursday, August 29, 2019 7:24 AM
> To: Leif Lindholm <leif.lindholm@linaro.org>; Ni, Ray
> <ray.ni@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Cetola, Stephano
> <stephano.cetola@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>;
Jayanth.Raghuram@dell.com; 'Andrew Fish
> (afish@apple.com)' <afish@apple.com>;
Wei.G.Liu@dell.com;
> Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
>
> On 08/29/19 11:49, Leif Lindholm wrote:
> > On Wed, Aug 28, 2019 at 05:33:28PM +0000, Ni, Ray wrote:
>
> >> With the existence of mail attachments capability in new groups.io
> >> system, can we accept such kind of patch submission? Or any side
> >> effect you see if allowing mail attachments?
> >
> > Traditionally, the reason for not wanting patches as attachments is
> > that it complicates doing inline code review as part of the email.
> >
> > If the mail system (let's take a wild guess, Outlook/Exchange?)
> > doesn't corrupt the text *too* badly, I don't have an issue with the
> > patch being sent in the message body *and* being attached so it
> > could actually be applied.
Leif,
So, message body should have the patch changes for easy inline review. It's optional to carry a .diff attachment.
Is my understanding correct?
>
> - Doesn't work for patch series, only for single patches.
Laszlo,
Do you mean attachment is not allowed for a series of patch? Why? A mail can carry multiple attachments. That makes the patch series easy to fetch in my opinion from Outlook.