From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by groups.io with SMTP; Mon, 02 Sep 2019 21:59:59 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
  by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 21:59:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,461,1559545200"; 
   d="scan'208,223";a="189704156"
Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7])
  by FMSMGA003.fm.intel.com with ESMTP; 02 Sep 2019 21:59:58 -0700
Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by
 ORSMSX109.amr.corp.intel.com ([169.254.11.172]) with mapi id 14.03.0439.000;
 Mon, 2 Sep 2019 21:59:58 -0700
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "xypron.glpk@gmx.de"
	<xypron.glpk@gmx.de>, "Carsey, Jaben" <jaben.carsey@intel.com>, "Gao,
 Zhichao" <zhichao.gao@intel.com>
CC: "Ni, Ray" <ray.ni@intel.com>, Leif Lindholm <leif.lindholm@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>, Stephano Cetola
	<stephano.cetola@linux.intel.com>
Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak
Thread-Topic: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL
 derefence and memory leak
Thread-Index: AQHVBt/017MsmsuPIEywR/Dz2op076Zk4e6AgLR0FwCAAMTPUA==
Date: Tue, 3 Sep 2019 04:59:57 +0000
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEE88D63@ORSMSX114.amr.corp.intel.com>
References: <20190510032419.14540-1-xypron.glpk@gmx.de>
 <CB6E33457884FA40993F35157061515CBCC2D910@FMSMSX103.amr.corp.intel.com>
 <d0a8c975-7b58-186d-4bf4-bc481f7aa452@gmx.de>
In-Reply-To: <d0a8c975-7b58-186d-4bf4-bc481f7aa452@gmx.de>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDkwZjE5YTktN2JlZS00MWM1LTkzNTYtZTM3MjQ4MTdjNzQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidnR0eXp0NjMrTmg1QzQ3UjA5ZkVVSWFoWWdFaDN0Vm5LdGJZRVMwK3I2RmF1d2lIc1p6YjgxTERqMjlQY3JCRSJ9
x-ctpclassification: CTP_NT
x-originating-ip: [10.22.254.138]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64

RnJvbSBodHRwczovL2dpdGh1Yi5jb20vdGlhbm9jb3JlL2VkazIvYmxvYi9tYXN0ZXIvTWFpbnRh
aW5lcnMudHh0Og0KDQpNOiBKYWJlbiBDYXJzZXkgPGphYmVuLmNhcnNleUBpbnRlbC5jb20+DQpN
OiBSYXkgTmkgPHJheS5uaUBpbnRlbC5jb20+DQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t
DQpGcm9tOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbyA8ZGV2ZWxAZWRrMi5ncm91cHMuaW8+IE9uIEJl
aGFsZiBPZiBIZWlucmljaCBTY2h1Y2hhcmR0DQpTZW50OiBNb25kYXksIFNlcHRlbWJlciAyLCAy
MDE5IDM6MTUgQU0NClRvOiBDYXJzZXksIEphYmVuIDxqYWJlbi5jYXJzZXlAaW50ZWwuY29tPjsg
ZGV2ZWxAZWRrMi5ncm91cHMuaW87IEdhbywgWmhpY2hhbyA8emhpY2hhby5nYW9AaW50ZWwuY29t
Pg0KQ2M6IE5pLCBSYXkgPHJheS5uaUBpbnRlbC5jb20+OyBMZWlmIExpbmRob2xtIDxsZWlmLmxp
bmRob2xtQGxpbmFyby5vcmc+OyBHYW8sIExpbWluZyA8bGltaW5nLmdhb0BpbnRlbC5jb20+OyBT
dGVwaGFubyBDZXRvbGEgPHN0ZXBoYW5vLmNldG9sYUBsaW51eC5pbnRlbC5jb20+DQpTdWJqZWN0
OiBSZTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MyAxLzFdIFNoZWxsUGtnL0NvbW1hbmRMaWI6IGF2
b2lkIE5VTEwgZGVyZWZlbmNlIGFuZCBtZW1vcnkgbGVhaw0KDQpPbiA1LzEwLzE5IDQ6MzIgUE0s
IENhcnNleSwgSmFiZW4gd3JvdGU6DQo+IFJldmlld2VkLWJ5OiBKYWJlbiBDYXJzZXkgPGphYmVu
LmNhcnNleUBpbnRlbC5jb20+DQo+DQo+IENvZGUgY2hhbmdlIGxvb2tzIGdvb2QgdmlzdWFsbHku
DQoNClNvbWVob3cgdGhpcyBwYXRjaA0KDQpodHRwczovL2VkazIuZ3JvdXBzLmlvL2cvZGV2ZWwv
bWVzc2FnZS80MDM5NQ0KDQp3YXMgbmV2ZXIgbWVyZ2VkLg0KDQpXaG8gaXMgdGhlIG1haW50YWlu
ZXIgZm9yIHRoZSBTaGVsbFBrZz8NCg0KQmVzdCByZWdhcmRzDQoNCkhlaW5yaWNoDQoNCg0KDQo=