From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Tue, 10 Sep 2019 19:20:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 19:20:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,491,1559545200"; d="scan'208";a="191992378" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by FMSMGA003.fm.intel.com with ESMTP; 10 Sep 2019 19:20:51 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Sep 2019 19:20:50 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX121.amr.corp.intel.com ([169.254.10.57]) with mapi id 14.03.0439.000; Tue, 10 Sep 2019 19:20:50 -0700 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Gao, Liming" Subject: Re: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode. Thread-Topic: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode. Thread-Index: AQHVZIDwdjo0gVTdpEiJbOP3vn0BzaclxEog Date: Wed, 11 Sep 2019 02:20:50 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEEAB127@ORSMSX114.amr.corp.intel.com> References: <20190906070110.18204-1-chasel.chiu@intel.com> In-Reply-To: <20190906070110.18204-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTg2MDlmNzMtMDgwNC00MmIyLTlhZmQtYjUxY2U0ZWYzYTRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYlE5dWhwMXB3ZWdrbGlOYWI0ZENTa09TR1dMc0FUSUh1UXdUZ2VlUUVqMHpLbUdzeTV0bmQwY1IzVjR3K3ROUiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel=20 Sent: Friday, September 6, 2019 12:01 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L= ; Gao, Liming Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporar= y RAM in Dispatch mode. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2159 FSP Dispatch mode will share same stack and heap with bootloader so we shou= ld not reserve separate temporary ram for FSP. Set PcdFspTemporaryRamSize to 0 in Dispatch mode. Test: internal platform can boot with FSP Dispatch mode with 64KB temporary RAM back. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 += ++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgP= cd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d= sc index 55ae9f47ac..2009bb225a 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d +++ sc @@ -69,10 +69,10 @@ gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 !else # - # FSP Dispatch mode will share the same stack with boot loader, - # here temporary ram size is used by FSP heap and can be smaller + # FSP Dispatch mode will share the same stack and heap with boot=20 + loader, # no separate temporary ram required by FSP. # - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0 =20 # # In FSP Dispatch mode boot loader stack size must be big enough for exe= cuting -- 2.13.3.windows.1