From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 12 Sep 2019 14:03:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2019 14:03:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,498,1559545200"; d="scan'208";a="215174971" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga002.fm.intel.com with ESMTP; 12 Sep 2019 14:03:37 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.225]) by ORSMSX105.amr.corp.intel.com ([169.254.2.66]) with mapi id 14.03.0439.000; Thu, 12 Sep 2019 14:03:36 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Kubacki, Michael A" , "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2 0/2] Add error handling and initialize variables Thread-Topic: [edk2-devel] [PATCH v2 0/2] Add error handling and initialize variables Thread-Index: AQHVaRoWX9368m9MPUui8DnnkVGUt6coiIaA Date: Thu, 12 Sep 2019 21:03:35 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEEB62D1@ORSMSX114.amr.corp.intel.com> References: <20190912032720.38132-1-shenglei.zhang@intel.com> In-Reply-To: <20190912032720.38132-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2NiMzU2MzQtNjVmMC00ZmVhLWFhYmUtODZlODVlMDEwYjhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNTV6QkVCTXR2WHJEQW00TFRyTEtOS0hUMzFlR2Z5VVdtMnlzMEp1ME4rNnFjMGY3eHdtSmI5TUhnOGh4VklXKyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch series has been pushed as 5dd12a154d.. 9ea86f187d -----Original Message----- From: devel@edk2.groups.io On Behalf Of Zhang, Shen= glei Sent: Wednesday, September 11, 2019 8:27 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; G= ao, Liming Subject: [edk2-devel] [PATCH v2 0/2] Add error handling and initialize var= iables 1.Add error handling to enhance status checking. 2.Initialize the variables before used and add check before FreePool(). v2: Update copyright in 01/02. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Shenglei Zhang (2): MinPlatformPkg/AcpiTables: Initialize variables before used MinPlatformPkg/AcpiTables: Add error handling to SortCpuLocalApicInTable .../Acpi/AcpiTables/AcpiPlatform.c | 29 ++++++++++++------- 1 file changed, 18 insertions(+), 11 deletions(-) --=20 2.18.0.windows.1