From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Tue, 17 Sep 2019 14:42:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Sep 2019 14:42:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,518,1559545200"; d="scan'208";a="180915852" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga008.jf.intel.com with ESMTP; 17 Sep 2019 14:42:53 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX105.amr.corp.intel.com ([169.254.2.158]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 14:42:52 -0700 From: "Nate DeSimone" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chiu, Chasel" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers Thread-Topic: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers Thread-Index: AQHVaRV0kn3ItU3EP0CFm/kIatT4h6coZJpggAJEgQCABQwggIAAuJUg Date: Tue, 17 Sep 2019 21:42:52 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEEEFD69@ORSMSX114.amr.corp.intel.com> References: <20190912025442.36436-1-shenglei.zhang@intel.com> <15C3C5B9A4267C61.28831@groups.io> <4e8f9867-73b8-9ca8-aafc-b4a1567ca61c@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjdiMmE3MDktODE0Zi00MDQ3LWJmZWMtZDE0NjU4NGU2Yzg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMHNGQlpvWGw3Qkp3SndCKzkyNkxjNElNeWpTN05OZFFYdUo0cUJzTDA2a1oranJ0TWxSdloybGI1ZXFoU1RRSiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgU2hlbmdsZWksDQoNCllvdSBhcmUgcmlnaHQsICpHY2RJb01hcCB3aWxsIGFsd2F5cyBiZSBO VUxMIGJ1dCBHY2RJb01hcCBtYXkgbm90IGJlIGFzIHRoZSBmdW5jdGlvbiBkb2VzIG5vdCBleGl0 IGVhcmx5IGluIHRoZSBjYXNlIG9mIEdjZElvTWFwIGJlaW5nID09IE5VTEwsIHNvcnJ5IEkgbWlz cmVhZC4gUGxlYXNlIG1ha2Ugc3VyZSB5b3UgcHV0IGEgc3BhY2UgYmV0d2VlbiB5b3VyIGNsb3Np bmcgcGFyZW50aGVzaXMgYW5kIHlvdXIgb3BlbmluZyBjdXJseToNCg0KaWYgKEdjZElvTWFwICE9 IE5VTEwpIHsNCg0Kbm90Li4uDQoNCmlmIChHY2RJb01hcCAhPSBOVUxMKXsNCg0KQWxzbywgcGxl YXNlIGZpeCB0aGUgZG91YmxlIHNlbWljb2xvbiBhbmQgaWYgc3RhdGVtZW50IHdoaXRlc3BhY2U6 DQoNCiAgICBJZiAoQm9vdE9yZGVyID09IE5VTEwpIHsNCiAgICAgIHJldHVybiBFRklfTk9UX0ZP VU5EOw0KICAgIH0NCg0Kbm90Li4uDQoNCiAgICBpZihCb290T3JkZXIgPT0gTlVMTCkgew0KICAg ICAgcmV0dXJuIEVGSV9OT1RfRk9VTkQ7Ow0KICAgIH0NCg0KVGhlbiB5b3Ugd2lsbCBnZXQgYSBy ZXZpZXdlZC1ieS4NCg0KVGhhbmtzLA0KTmF0ZQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KRnJvbTogWmhhbmcsIFNoZW5nbGVpIDxzaGVuZ2xlaS56aGFuZ0BpbnRlbC5jb20+IA0KU2Vu dDogTW9uZGF5LCBTZXB0ZW1iZXIgMTYsIDIwMTkgODozNiBQTQ0KVG86IGRldmVsQGVkazIuZ3Jv dXBzLmlvOyBEZXNpbW9uZSwgTmF0aGFuaWVsIEwgPG5hdGhhbmllbC5sLmRlc2ltb25lQGludGVs LmNvbT4NCkNjOiBLdWJhY2tpLCBNaWNoYWVsIEEgPG1pY2hhZWwuYS5rdWJhY2tpQGludGVsLmNv bT47IENoaXUsIENoYXNlbCA8Y2hhc2VsLmNoaXVAaW50ZWwuY29tPjsgR2FvLCBMaW1pbmcgPGxp bWluZy5nYW9AaW50ZWwuY29tPg0KU3ViamVjdDogUkU6IFtlZGsyLWRldmVsXSBbUEFUQ0hdIE1p blBsYXRmb3JtUGtnL1Rlc3RQb2ludENoZWNrTGliOiBBZGQgY2hlY2sgZm9yIHBvaW50ZXJzDQoN CkhpIE5hdGhhbmllbCwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBE ZXNpbW9uZSwgTmF0aGFuaWVsIEwNCj4gU2VudDogU2F0dXJkYXksIFNlcHRlbWJlciAxNCwgMjAx OSA2OjMxIEFNDQo+IFRvOiBaaGFuZywgU2hlbmdsZWkgPHNoZW5nbGVpLnpoYW5nQGludGVsLmNv bT47IGRldmVsQGVkazIuZ3JvdXBzLmlvDQo+IENjOiBLdWJhY2tpLCBNaWNoYWVsIEEgPG1pY2hh ZWwuYS5rdWJhY2tpQGludGVsLmNvbT47IENoaXUsIENoYXNlbCANCj4gPGNoYXNlbC5jaGl1QGlu dGVsLmNvbT47IEdhbywgTGltaW5nIDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4gU3ViamVjdDog UmU6IFtlZGsyLWRldmVsXSBbUEFUQ0hdIE1pblBsYXRmb3JtUGtnL1Rlc3RQb2ludENoZWNrTGli OiANCj4gQWRkIGNoZWNrIGZvciBwb2ludGVycw0KPiANCj4gSGkgU2hlbmdsZWksDQo+IA0KPiBM b29raW5nIGF0IHRoaXMgcGF0Y2ggbW9yZSBjbG9zZWx5LiBUaGVyZSBhcHBlYXIgdG8gYmUgYnVn cy4uLiBwbGVhc2UgDQo+IHNlZSBiZWxvdy4gUGxlYXNlIGZpeCB0aGlzIGFsb25nIHdpdGggeW91 ciBwb29yIHVzZSBvZiBzZW1pLWNvbG9ucyBhbmQgDQo+IHdoaXRlLXNwYWNlLg0KPiANCj4gVGhh bmtzLA0KPiANCj4gTmF0ZQ0KPiANCj4gT24gOS8xMi8yMDE5IDExOjU0IEFNLCBOYXRlIERlU2lt b25lIHdyb3RlOg0KPiA+IFlvdXIgd2hpdGVzcGFjZSBkb2Vzbid0IHF1aXRlIG1hdGNoIHRoZSBl ZGsyIGNvZGluZyBzdHlsZSANCj4gPiBndWlkZWxpbmVzLCBidXQNCj4gd2UgY2FuIGZpeCB0aGF0 IGR1cmluZyBjb21taXQuDQo+ID4NCj4gPiBSZXZpZXdlZC1ieTogTmF0ZSBEZVNpbW9uZSA8bmF0 aGFuaWVsLmwuZGVzaW1vbmVAaW50ZWwuY29tPg0KPiA+DQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNz YWdlLS0tLS0NCj4gPiBGcm9tOiBaaGFuZywgU2hlbmdsZWkNCj4gPiBTZW50OiBXZWRuZXNkYXks IFNlcHRlbWJlciAxMSwgMjAxOSA3OjU1IFBNDQo+ID4gVG86IGRldmVsQGVkazIuZ3JvdXBzLmlv DQo+ID4gQ2M6IEt1YmFja2ksIE1pY2hhZWwgQSA8bWljaGFlbC5hLmt1YmFja2lAaW50ZWwuY29t PjsgQ2hpdSwgQ2hhc2VsDQo+IDxjaGFzZWwuY2hpdUBpbnRlbC5jb20+OyBEZXNpbW9uZSwgTmF0 aGFuaWVsIEwgDQo+IDxuYXRoYW5pZWwubC5kZXNpbW9uZUBpbnRlbC5jb20+OyBHYW8sIExpbWlu ZyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4gU3ViamVjdDogW1BBVENIXSBNaW5QbGF0Zm9y bVBrZy9UZXN0UG9pbnRDaGVja0xpYjogQWRkIGNoZWNrIGZvcg0KPiBwb2ludGVycw0KPiA+DQo+ ID4gSW4gRHhlQ2hlY2tCb290VmFyaWFibGUuYywgYWRkIGNoZWNrIGZvciBCb290T3JkZXIgYW5k IFZhcmlhYmxlIHRoYXQNCj4gcmV0dXJuIEVGSV9OT1RfRk9VTkQgd2hlbiB0aGV5IGFyZSBOVUxM Lg0KPiA+IEluIER4ZUNoZWNrR2NkLmMsIGFkZCBjaGVjayBmb3IgR2NkSW9NYXAgdG8gZW5zdXJl IGl0IG5vdCBOVUxMIHdoZW4NCj4gYWxsb2NhdGluZyBtZW1vcnkgdG8gd2hhdCBpdCBwb2ludHMg dG8uDQo+ID4NCj4gPiBDYzogTWljaGFlbCBLdWJhY2tpIDxtaWNoYWVsLmEua3ViYWNraUBpbnRl bC5jb20+DQo+ID4gQ2M6IENoYXNlbCBDaGl1IDxjaGFzZWwuY2hpdUBpbnRlbC5jb20+DQo+ID4g Q2M6IE5hdGUgRGVTaW1vbmUgPG5hdGhhbmllbC5sLmRlc2ltb25lQGludGVsLmNvbT4NCj4gPiBD YzogTGltaW5nIEdhbyA8bGltaW5nLmdhb0BpbnRlbC5jb20+DQo+ID4gU2lnbmVkLW9mZi1ieTog U2hlbmdsZWkgWmhhbmcgPHNoZW5nbGVpLnpoYW5nQGludGVsLmNvbT4NCj4gPiAtLS0NCj4gPg0K PiA+IHYyOiBVcGRhdGUgY29weXJpZ2h0DQo+ID4NCj4gPiAgIC4uLi9UZXN0L0xpYnJhcnkvVGVz dFBvaW50Q2hlY2tMaWIvRHhlQ2hlY2tCb290VmFyaWFibGUuYyB8IDggKysrKysrKy0NCj4gPiAg IC4uLi9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tMaWIvRHhlQ2hlY2tHY2QuYyAgICAgICAg ICB8IDYgKysrKy0tDQo+ID4gICAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0DQo+IGEvUGxhdGZvcm0vSW50ZWwvTWlu UGxhdGZvcm1Qa2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoZWMNCj4gaw0K PiBCb290VmFyaWFibGUuYw0KPiBiL1BsYXRmb3JtL0ludGVsL01pblBsYXRmb3JtUGtnL1Rlc3Qv TGlicmFyeS9UZXN0UG9pbnRDaGVja0xpYi9EeGVDaGVjDQo+IGsNCj4gQm9vdFZhcmlhYmxlLmMN Cj4gPiBpbmRleCA4NWJkNWIzZC4uOTgxMzA2ODMgMTAwNjQ0DQo+ID4gLS0tDQo+IGEvUGxhdGZv cm0vSW50ZWwvTWluUGxhdGZvcm1Qa2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4 ZUNoZWMNCj4gaw0KPiBCb290VmFyaWFibGUuYw0KPiA+ICsrKw0KPiBiL1BsYXRmb3JtL0ludGVs L01pblBsYXRmb3JtUGtnL1Rlc3QvTGlicmFyeS9UZXN0UG9pbnRDaGVja0xpYi9EeGVDaA0KPiA+ ICsrKyBlY2tCb290VmFyaWFibGUuYw0KPiA+IEBAIC0xLDYgKzEsNiBAQA0KPiA+ICAgLyoqIEBm aWxlDQo+ID4NCj4gPiAtQ29weXJpZ2h0IChjKSAyMDE3LCBJbnRlbCBDb3Jwb3JhdGlvbi4gQWxs IHJpZ2h0cyByZXNlcnZlZC48QlI+DQo+ID4gK0NvcHlyaWdodCAoYykgMjAxNy0yMDE5LCBJbnRl bCBDb3Jwb3JhdGlvbi4gQWxsIHJpZ2h0cyANCj4gPiArcmVzZXJ2ZWQuPEJSPg0KPiA+ICAgU1BE WC1MaWNlbnNlLUlkZW50aWZpZXI6IEJTRC0yLUNsYXVzZS1QYXRlbnQNCj4gPg0KPiA+ICAgKiov DQo+ID4gQEAgLTEzMCw2ICsxMzAsOSBAQCBUZXN0UG9pbnRDaGVja0xvYWRPcHRpb25WYXJpYWJs ZSAoDQo+ID4gICAgIGZvciAoTGlzdEluZGV4ID0gMDsgTGlzdEluZGV4IDwNCj4gc2l6ZW9mKG1M b2FkT3B0aW9uVmFyaWFibGVMaXN0KS9zaXplb2YobUxvYWRPcHRpb25WYXJpYWJsZUxpc3RbMF0p Ow0KPiBMaXN0SW5kZXgrKykgew0KPiA+ICAgICAgIFVuaWNvZGVTUHJpbnQgKEJvb3RPcmRlck5h bWUsIHNpemVvZihCb290T3JkZXJOYW1lKSwgDQo+ID4gTCIlc09yZGVyIiwNCj4gbUxvYWRPcHRp b25WYXJpYWJsZUxpc3RbTGlzdEluZGV4XSk7DQo+ID4gICAgICAgU3RhdHVzID0gR2V0VmFyaWFi bGUyIChCb290T3JkZXJOYW1lLCAmZ0VmaUdsb2JhbFZhcmlhYmxlR3VpZCwNCj4gKFZPSUQgKiop JkJvb3RPcmRlciwgJk9yZGVyU2l6ZSk7DQo+ID4gKyAgICBpZihCb290T3JkZXIgPT0gTlVMTCkg ew0KPiA+ICsgICAgICByZXR1cm4gRUZJX05PVF9GT1VORDs7DQo+ID4gKyAgICB9DQo+ID4gICAg ICAgaWYgKEVGSV9FUlJPUihTdGF0dXMpKSB7DQo+ID4gICAgICAgICBjb250aW51ZTsNCj4gPiAg ICAgICB9DQo+ID4gQEAgLTIyMiw2ICsyMjUsOSBAQCBUZXN0UG9pbnRDaGVja0tleU9wdGlvblZh cmlhYmxlICgNCj4gPiAgICAgICBmb3IgKEluZGV4ID0gMDsgOyBJbmRleCsrKSB7DQo+ID4gICAg ICAgICBVbmljb2RlU1ByaW50IChLZXlPcHRpb25OYW1lLCBzaXplb2YoS2V5T3B0aW9uTmFtZSks IA0KPiA+IEwiJXMlMDR4IiwNCj4gbUtleU9wdGlvblZhcmlhYmxlTGlzdFtMaXN0SW5kZXhdLCBJ bmRleCk7DQo+ID4gICAgICAgICBTdGF0dXMgPSBHZXRWYXJpYWJsZTIgKEtleU9wdGlvbk5hbWUs IA0KPiA+ICZnRWZpR2xvYmFsVmFyaWFibGVHdWlkLA0KPiAmVmFyaWFibGUsICZTaXplKTsNCj4g PiArICAgICAgaWYoVmFyaWFibGUgPT0gTlVMTCkgew0KPiA+ICsgICAgICAgIHJldHVybiBFRklf Tk9UX0ZPVU5EOzsNCj4gPiArICAgICAgfQ0KPiA+ICAgICAgICAgaWYgKCFFRklfRVJST1IoU3Rh dHVzKSkgew0KPiA+ICAgICAgICAgICBEdW1wS2V5T3B0aW9uIChLZXlPcHRpb25OYW1lLCBWYXJp YWJsZSwgU2l6ZSk7DQo+ID4gICAgICAgICB9IGVsc2Ugew0KPiA+IGRpZmYgLS1naXQNCj4gYS9Q bGF0Zm9ybS9JbnRlbC9NaW5QbGF0Zm9ybVBrZy9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tM aWIvRHhlQ2hlYw0KPiBrDQo+IEdjZC5jDQo+IGIvUGxhdGZvcm0vSW50ZWwvTWluUGxhdGZvcm1Q a2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoZWMNCj4gaw0KPiBHY2QuYw0K PiA+IGluZGV4IDgyNzA5ZDQ0Li5jOTBiMzdmMiAxMDA2NDQNCj4gPiAtLS0NCj4gYS9QbGF0Zm9y bS9JbnRlbC9NaW5QbGF0Zm9ybVBrZy9UZXN0L0xpYnJhcnkvVGVzdFBvaW50Q2hlY2tMaWIvRHhl Q2hlYw0KPiBrDQo+IEdjZC5jDQo+ID4gKysrDQo+IGIvUGxhdGZvcm0vSW50ZWwvTWluUGxhdGZv cm1Qa2cvVGVzdC9MaWJyYXJ5L1Rlc3RQb2ludENoZWNrTGliL0R4ZUNoDQo+ID4gKysrIGVja0dj ZC5jDQo+ID4gQEAgLTEsNiArMSw2IEBADQo+ID4gICAvKiogQGZpbGUNCj4gPg0KPiA+IC1Db3B5 cmlnaHQgKGMpIDIwMTcsIEludGVsIENvcnBvcmF0aW9uLiBBbGwgcmlnaHRzIHJlc2VydmVkLjxC Uj4NCj4gPiArQ29weXJpZ2h0IChjKSAyMDE3LTIwMTksIEludGVsIENvcnBvcmF0aW9uLiBBbGwg cmlnaHRzIA0KPiA+ICtyZXNlcnZlZC48QlI+DQo+ID4gICBTUERYLUxpY2Vuc2UtSWRlbnRpZmll cjogQlNELTItQ2xhdXNlLVBhdGVudA0KPiA+DQo+ID4gICAqKi8NCj4gPiBAQCAtMjQxLDcgKzI0 MSw5IEBAIFRlc3RQb2ludER1bXBHY2QgKA0KPiA+ICAgICAgICAgfQ0KPiA+ICAgICAgIH0NCj4g PiAgICAgICBpZiAoR2NkTWVtb3J5TWFwICE9IE5VTEwpIHsNCj4gPiAtICAgICAgKkdjZElvTWFw ID0gQWxsb2NhdGVDb3B5UG9vbCAoTnVtYmVyT2ZEZXNjcmlwdG9ycyAqDQo+IHNpemVvZihFRklf R0NEX0lPX1NQQUNFX0RFU0NSSVBUT1IpLCBJb01hcCk7DQo+ID4gKyAgICAgIGlmIChHY2RJb01h cCAhPSBOVUxMKXsNCj4gPiArICAgICAgICAqR2NkSW9NYXAgPSBBbGxvY2F0ZUNvcHlQb29sIChO dW1iZXJPZkRlc2NyaXB0b3JzICoNCj4gc2l6ZW9mKEVGSV9HQ0RfSU9fU1BBQ0VfREVTQ1JJUFRP UiksIElvTWFwKTsNCj4gPiArICAgICAgfQ0KPiANCj4gR2NkSW9NYXAgd2lsbCBhbHdheXMgYmUg TlVMTC4gUGxlYXNlIHNlZSBsaW5lIDE5OSBvZiB0aGlzIGZpbGUuIEkgDQo+IGJlbGlldmUgeW91 ciBwYXRjaCBpcyBpbnRyb2R1Y2luZyBhIG5ldyBidWcuDQoNCkkgZmFpbCB0byBnZXQgeW91ciBw b2ludC4gV291bGQgeW91IGV4cGxhaW4gd2h5IEdjZElvTWFwIHdpbGwgYWx3YXlzIGJlIE5VTEw/ ICBJdCBsb29rcyBsaWtlIGFuIGlucHV0IHBhcmFtZXRlciBmcm9tIG90aGVyIHBsYWNlLg0KDQpU aGFua3MsDQpTaGVuZ2xlaQ0KDQo+IA0KPiA+ICAgICAgICAgKkdjZElvTWFwTnVtYmVyT2ZEZXNj cmlwdG9ycyA9IE51bWJlck9mRGVzY3JpcHRvcnM7DQo+ID4gICAgICAgfQ0KPiA+ICAgICB9DQo+ ID4gLS0NCj4gPiAyLjE4LjAud2luZG93cy4xDQo+ID4NCj4gPg0KPiA+IA0KPiA+DQo=