From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>
Cc: "Sinha, Ankit" <ankit.sinha@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ
Date: Fri, 20 Sep 2019 23:30:25 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF06011@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190919030750.20364-1-michael.a.kubacki@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Wednesday, September 18, 2019 8:08 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068
This change sets the serial IRQ mode to continuous to allow the PS/2 keyboard and mouse to function properly in the OS. In the UEFI boot environment, the device uses a polling model so this change is not strictly required for that environment.
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
index 0bdd51d288..9cd2bc4d17 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSili
+++ conPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
@@ -148,6 +148,8 @@ if ((PcdGet8 (PcdSerialIoUartDebugEnable) == 1) &&
}
DEBUG_CODE_END();
+ FspsUpd->FspsConfig.PchSirqMode = PchContinuousMode;
+
return EFI_SUCCESS;
}
--
2.16.2.windows.1
prev parent reply other threads:[~2019-09-20 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 3:07 [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ Kubacki, Michael A
2019-09-20 23:30 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0AAEF06011@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox