[edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ

[edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ

[Kubacki, Michael A]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068

This change sets the serial IRQ mode to continuous to allow the PS/2
keyboard and mouse to function properly in the OS. In the UEFI boot
environment, the device uses a polling model so this change is not
strictly required for that environment.

Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
index 0bdd51d288..9cd2bc4d17 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
@@ -148,6 +148,8 @@ if ((PcdGet8 (PcdSerialIoUartDebugEnable) == 1) &&
   }
 DEBUG_CODE_END();
 
+  FspsUpd->FspsConfig.PchSirqMode = PchContinuousMode;
+
   return EFI_SUCCESS;
 }
 
-- 
2.16.2.windows.1

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kubacki, Michael A
Sent: Wednesday, September 18, 2019 8:08 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068

This change sets the serial IRQ mode to continuous to allow the PS/2 keyboard and mouse to function properly in the OS. In the UEFI boot environment, the device uses a polling model so this change is not strictly required for that environment.

Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Michael Kubacki <michael.a.kubacki@intel.com>
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
index 0bdd51d288..9cd2bc4d17 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSili
+++ conPolicyUpdateLibFsp/PeiPchPolicyUpdate.c
@@ -148,6 +148,8 @@ if ((PcdGet8 (PcdSerialIoUartDebugEnable) == 1) &&
   }
 DEBUG_CODE_END();
 
+  FspsUpd->FspsConfig.PchSirqMode = PchContinuousMode;
+
   return EFI_SUCCESS;
 }
 
--
2.16.2.windows.1