From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Fri, 20 Sep 2019 16:30:27 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2019 16:30:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,530,1559545200"; d="scan'208";a="339116615" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga004.jf.intel.com with ESMTP; 20 Sep 2019 16:30:26 -0700 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 20 Sep 2019 16:30:26 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX113.amr.corp.intel.com ([169.254.9.232]) with mapi id 14.03.0439.000; Fri, 20 Sep 2019 16:30:26 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Sinha, Ankit" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable continous mode Serial IRQ Thread-Index: AQHVbpdwVmfyTbFcqUqtLqGMZ/fIsqc1OTeQ Date: Fri, 20 Sep 2019 23:30:25 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF06011@ORSMSX114.amr.corp.intel.com> References: <20190919030750.20364-1-michael.a.kubacki@intel.com> In-Reply-To: <20190919030750.20364-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzIwMjU3ZTUtMjAyMi00MDFmLTk1MjItZjFlNzRjOGM2YWU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVlwvZXpsblBtSU5Ja25oNGgwNHI1T29jdUNFZGZ4ZThlR2RrSkVWc0ZLNDI5OHBxcE1qbEo3amw2MlJFUHdlejEifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Wednesday, September 18, 2019 8:08 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1x= xWU: Enable continous mode Serial IRQ REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2068 This change sets the serial IRQ mode to continuous to allow the PS/2 keybo= ard and mouse to function properly in the OS. In the UEFI boot environment,= the device uses a polling model so this change is not strictly required fo= r that environment. Cc: Ankit Sinha Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPoli= cyUpdateLibFsp/PeiPchPolicyUpdate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/Pe= iSiliconPolicyUpdateLibFsp/PeiPchPolicyUpdate.c b/Platform/Intel/ClevoOpenB= oardPkg/N1xxWU/FspWrapper/Library/PeiSiliconPolicyUpdateLibFsp/PeiPchPolicy= Update.c index 0bdd51d288..9cd2bc4d17 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSilico= nPolicyUpdateLibFsp/PeiPchPolicyUpdate.c +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/FspWrapper/Library/PeiSili +++ conPolicyUpdateLibFsp/PeiPchPolicyUpdate.c @@ -148,6 +148,8 @@ if ((PcdGet8 (PcdSerialIoUartDebugEnable) =3D=3D 1) && } DEBUG_CODE_END(); =20 + FspsUpd->FspsConfig.PchSirqMode =3D PchContinuousMode; + return EFI_SUCCESS; } =20 -- 2.16.2.windows.1