From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Mon, 23 Sep 2019 00:41:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 00:41:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="389392651" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga006.fm.intel.com with ESMTP; 23 Sep 2019 00:41:35 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 00:41:35 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX151.amr.corp.intel.com ([169.254.7.201]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 00:41:35 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Sinha, Ankit" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS Thread-Index: AQHVb1lWGgCGfvAcpEqOjnyEOxgv16c45dQg Date: Mon, 23 Sep 2019 07:41:34 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF0A491@ORSMSX114.amr.corp.intel.com> References: <20190920021538.27096-1-michael.a.kubacki@intel.com> In-Reply-To: <20190920021538.27096-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ2YmM5MjUtODY2NS00N2E2LTllODgtZDk3YTI3NzA3YTIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNFpyWG5cL3lFNTg0bHdOQ1kyTHFhVFg2UHgzc2pNdWgwOXd5aUJEcDJPbnNQZWt1aTZ0Z0IrcXhTaWhac3NDS1AifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Thursday, September 19, 2019 7:16 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1x= xWU: Enable Synaptics touchpad support in OS REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2068 Adds the ACPI device for the Synaptics touchpad. With this change, the tou= chpad device is functional in the OS. Cc: Ankit Sinha Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xxWUAcp= iTableLib.c | 2 +- Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl = | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/= DxeN1xxWUAcpiTableLib.c b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/B= oardAcpiLib/DxeN1xxWUAcpiTableLib.c index 96a3232fe5..d309bf4e1d 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1xx= WUAcpiTableLib.c +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAcpiLib/DxeN1 +++ xxWUAcpiTableLib.c @@ -54,7 +54,7 @@ N1xxWUUpdateGlobalNvs ( // mGlobalNvsArea.Area->LowPowerS0Idle =3D PcdGet8 (PcdLowPowerS0Idle); =20 - mGlobalNvsArea.Area->Ps2MouseEnable =3D FALSE; + mGlobalNvsArea.Area->Ps2MouseEnable =3D PcdGet8 (PcdPs2KbMsEnable); mGlobalNvsArea.Area->Ps2KbMsEnable =3D PcdGet8 (PcdPs2KbMsEnable); } =20 diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.= asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl index 6fbaf3a97f..3ef9aed1e6 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl @@ -55,10 +55,10 @@ scope (\_SB.PCI0.LPCB) { =20 } =20 - Device(PS2M) // PS/2 Mouse + Device(SYNM) // Synaptics Mouse { - Name(_HID,"MSFT0003") - Name(_CID,EISAID("PNP0F03")) + Name(_HID,"SYN1221") + Name(_CID,EISAID("PNP0F13")) =20 Method(_STA) { -- 2.16.2.windows.1