From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Mon, 23 Sep 2019 01:09:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 01:09:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,539,1559545200"; d="scan'208";a="182454374" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga008.jf.intel.com with ESMTP; 23 Sep 2019 01:09:33 -0700 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 01:09:33 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX115.amr.corp.intel.com ([169.254.4.199]) with mapi id 14.03.0439.000; Mon, 23 Sep 2019 01:09:33 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board Thread-Topic: [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash map to board Thread-Index: AQHVb+L9gqZWLsySR0SjjQn+Gvxs9qc47IuQ Date: Mon, 23 Sep 2019 08:09:32 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF0A671@ORSMSX114.amr.corp.intel.com> References: <20190920184030.6148-1-michael.a.kubacki@intel.com> <20190920184030.6148-7-michael.a.kubacki@intel.com> In-Reply-To: <20190920184030.6148-7-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjE5YWFmNDktYTMzNC00OTVjLTgzMzgtOTUxOWFjZWZlMWZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS0ROSGZVdVJyYmJMMTk0VFExTjg0M1hpS1Bjek83MDF1Vlg1eFhLek8xMVVVZk4xY3BUbjRFWEpKUmZuQVwvdzUifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A =20 Sent: Friday, September 20, 2019 11:40 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller = Subject: [edk2-platforms][PATCH V1 06/12] KabylakeOpenBoardPkg: Move flash = map to board REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 The flash map currently in KabylakeOpenBoardPkg is only applicable to the K= abylakeRvp3 board. This change moves the flash map to that board directory = to prepare for other boards to reside in the package. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/{ =3D> KabylakeRvp3}/Include/Fdf/Flash= MapInclude.fdf | 0 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg = | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclud= e.fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashM= apInclude.fdf similarity index 100% rename from Platform/Intel/KabylakeOpenBoardPkg/Include/Fdf/FlashMapInclude= .fdf rename to Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/Flas= hMapInclude.fdf diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.= fdf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf index 7267d478ad..2b8eab36a1 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf @@ -8,7 +8,7 @@ ## =20 [Defines] - !include $(PLATFORM_BOARD_PACKAGE)/Include/Fdf/FlashMapInclude.fdf + !include $(PROJECT)/Include/Fdf/FlashMapInclude.fdf =20 ##########################################################################= ###### # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.= cfg b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg index ab1a9a61c2..78f808bfaf 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg @@ -13,7 +13,7 @@ openssl_path =3D PLATFORM_BOARD_PACKAGE =3D KabylakeOpenBoardPkg PROJECT =3D KabylakeOpenB= oardPkg/KabylakeRvp3 BOARD =3D KabylakeRvp3 -FLASH_MAP_FDF =3D KabylakeOpe= nBoardPkg/Include/Fdf/FlashMapInclude.fdf +FLASH_MAP_FDF =3D=20 +KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclude.fdf PROJECT_DSC =3D KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc BOARD_PKG_PCD_DSC =3D KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds= c ADDITIONAL_SCRIPTS =3D KabylakeOpenBoardPkg/KabylakeRvp3/build_board.py -- 2.16.2.windows.1