From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 25 Sep 2019 15:36:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 15:36:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,549,1559545200"; d="scan'208";a="390382035" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 25 Sep 2019 15:36:51 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 15:36:50 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX116.amr.corp.intel.com ([169.254.7.232]) with mapi id 14.03.0439.000; Wed, 25 Sep 2019 15:36:50 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Sinha, Ankit" , Jeremy Soller Subject: Re: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse Thread-Topic: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe: Add Synaptics PS/2 mouse Thread-Index: AQHVcwPaL7A9pBACSEKG4od+kpS2zKc8/VcA Date: Wed, 25 Sep 2019 22:36:50 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF16693@ORSMSX114.amr.corp.intel.com> References: <20190924181248.12816-1-michael.a.kubacki@intel.com> <20190924181248.12816-14-michael.a.kubacki@intel.com> In-Reply-To: <20190924181248.12816-14-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWY4ZDYwM2ItYTY3Mi00YmZjLTk0MDQtZDFkNjljYmY5N2ZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWU5zaWR2bHozQXg2ZkZQV0ZDOUtTN3ZFSkkrRVJrNDFDNzdObEp5RWR4U2VrSHB1Q0JtUGs2V0xaZGg2MktxQiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A =20 Sent: Tuesday, September 24, 2019 11:13 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Sinha, Ankit ; Jeremy Soller = Subject: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiDxe= : Add Synaptics PS/2 mouse REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2207 Moves the Synaptics PS/2 mouse support required for the Galago Pro 3 trackp= ad to function from the previous location in ClevoOpenBoardPkg/N1xxWU to th= e common ASL file in KabylakeOpenBoardPkg. The board ID is used to determine which PS/2 mouse device to expose. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Ankit Sinha Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl | 41 += ++++++++++++++++++- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Lpc= B.asl b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl index 9f9d39c92c..d934c20beb 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.asl +++ b/Platform/Intel/KabylakeOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/LpcB.as +++ l @@ -1,11 +1,12 @@ /** @file ACPI DSDT table =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ =20 +#include "PlatformBoardId.h" =20 // LPC Bridge - Device 31, Function 0 scope (\_SB.PCI0.LPCB) { @@ -66,7 +67,43 @@ scope (\_SB.PCI0.LPCB) { { If (P2MK) //Ps2 Keyboard and Mouse Enable { - Return(0x000F) + If (LNotEqual(BDID,BoardIdGalagoPro3)) + { + Return(0x000F) + } + } + } + Return(0x0000) + } + + Name(_CRS,ResourceTemplate() + { + IRQ(Edge,ActiveHigh,Exclusive){0x0C} + }) + + Name(_PRS, ResourceTemplate(){ + StartDependentFn(0, 0) { + IRQNoFlags(){12} + } + EndDependentFn() + }) + } + + Device(SYNM) // Synaptics Mouse + { + Name(_HID,"SYN1221") + Name(_CID,EISAID("PNP0F13")) + + Method(_STA) + { + If (P2ME) //Ps2 Mouse Enable + { + If (P2MK) //Ps2 Keyboard and Mouse Enable + { + If (LEqual(BDID,BoardIdGalagoPro3)) + { + Return(0x000F) + } } } Return(0x0000) -- 2.16.2.windows.1