From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: nathaniel.l.desimone@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Thu, 03 Oct 2019 00:56:00 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 00:55:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,251,1566889200"; d="scan'208";a="195137011" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga003.jf.intel.com with ESMTP; 03 Oct 2019 00:55:59 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX101.amr.corp.intel.com ([169.254.8.204]) with mapi id 14.03.0439.000; Thu, 3 Oct 2019 00:55:59 -0700 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Jeremy Soller Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used. Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used. Thread-Index: AQHVePTCSPHjpEuPckCsGKGQvMU36KdII3fQgABqF0A= Date: Thu, 3 Oct 2019 07:55:58 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF2A749@ORSMSX114.amr.corp.intel.com> References: <20191002074031.3483-1-nathaniel.l.desimone@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTFiODkwMjktMjQ0Ny00NWM5LWFiMzktMzdkNzM3OTliMTA3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMFBhZVZGMExpUll1SFNjZitMYWE3MGdzNTBiUjFvdzVIS21aYWdmdW5ZSHBcL3FFcUo0NkFjc0RFM2xxVGVuRWgifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Michael. Another thing we should consider doing a some point in the = future is moving the PlatformSecLib implementation that supports dispatch m= ode from KabylakeOpenBoardPkg to MinPlatformPkg. -----Original Message----- From: Kubacki, Michael A =20 Sent: Wednesday, October 2, 2019 6:35 PM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel ; Jeremy Soller Subject: RE: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg:= Wrong instance of PlatformSecLib is used. Reviewed-by: Michael Kubacki > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nate=20 > DeSimone > Sent: Wednesday, October 2, 2019 12:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A=20 > ; Jeremy Soller > Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: > Wrong instance of PlatformSecLib is used. >=20 > The GalagoPro3 platform in KabylakeOpenBoardPkg is using the instance=20 > of PlatformSecLib in MinPlatformPkg instead of the instance in=20 > KabylakeOpenBoardPkg. The version in MinPlatformPkg does not support=20 > FSP 2.1 Dispatch Mode, whearas the version in KabylakeOpenBoardPkg does. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Jeremy Soller > Signed-off-by: Nate DeSimone > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > index d67e0cc000..f3dd2b0c91 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > @@ -85,7 +85,7 @@ >=20 > PlatformHookLib|$(PROJECT)/Library/BasePlatformHookLib/BasePlatformHo > okLib.inf > FspWrapperHobProcessLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/P > eiFspWrapperHobProcessLib/PeiFspWrapperHobProcessLib.inf- > PlatformSecLib|$(PLATFORM_PACKAGE)/FspWrapper/Library/SecFspWrapp > erPlatformSecLib/SecFspWrapperPlatformSecLib.inf+ > PlatformSecLib|$(PLATFORM_BOARD_PACKAGE)/FspWrapper/Library/SecFs > pWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf > FspWrapperApiLib|IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/Ba > seFspWrapperApiLib.inf > FspWrapperApiTestLib|IntelFsp2WrapperPkg/Library/PeiFspWrapperApiTest > Lib/PeiFspWrapperApiTestLib.inf-- > 2.23.0.windows.1 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#48362):=20 > https://edk2.groups.io/g/devel/message/48362 > Mute This Topic: https://groups.io/mt/34367442/1772268 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [michael.a.kubacki@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D