From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.6091.1570768289020734217 for ; Thu, 10 Oct 2019 21:31:29 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 21:31:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,282,1566889200"; d="scan'208";a="184643289" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga007.jf.intel.com with ESMTP; 10 Oct 2019 21:31:28 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Oct 2019 21:31:28 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.55]) by ORSMSX152.amr.corp.intel.com ([169.254.8.128]) with mapi id 14.03.0439.000; Thu, 10 Oct 2019 21:31:28 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Chiu, Chasel" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC include file section tags Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg: Add DSC include file section tags Thread-Index: AQHVfZeh+mdAVexCuUug8RnohfNdRqdU3i6g Date: Fri, 11 Oct 2019 04:31:27 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AAEF4CDC1@ORSMSX114.amr.corp.intel.com> References: <20191008051645.22052-1-michael.a.kubacki@intel.com> <20191008051645.22052-3-michael.a.kubacki@intel.com> In-Reply-To: <20191008051645.22052-3-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcwMWRjOTgtZTljYS00ODdhLTgwMjItYWUxODVjNjMzY2FmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVEZ6cU1WaVBZdE9Bc0NFVU9rV3pTV1RlYmU3M1JmT2p1eUErZmtoSmd3eHpnd1hQSGROSnVEaTNtWXRKNWFSZyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Monday, October 7, 2019 10:17 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel Subject: [edk2-devel] [edk2-platforms][PATCH V1 02/17] KabylakeSiliconPkg:= Add DSC include file section tags REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2245 The DSC LibraryClass files in KabylakeSiliconPkg that are intended to be i= ncluded elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc, and SiPkgCommon= Lib.dsc should have section tags so that they are not dependent on the top-= level DSC file to place the include file in the correct location in the DSC= file and better define the applicability of their library content. This change adds section tags for the library class related files. The component files may be built differently in the consuming package depe= nding on their architecture requirements so those are not modified. Cc: Sai Chaganty Cc: Chasel Chiu Signed-off-by: Michael Kubacki --- Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc | 6 ++++-- Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc | 5 +++-- Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc | 3 ++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc b/Silicon= /Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc index 920b02e410..fa9dd4a32d 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgCommonLib.dsc @@ -1,11 +1,13 @@ ## @file -# Component description file for the SkyLake SiPkg both Pei and Dxe libr= aries DSC file. +# Build description file for Kaby Lake silicon PEI and DXE libraries. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +[LibraryClasses.common] # # Silicon Init Common Library # diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc b/Silicon/In= tel/KabylakeSiliconPkg/SiPkgDxeLib.dsc index 8c194d8e7c..bc497c3531 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgDxeLib.dsc @@ -1,12 +1,13 @@ # @file -# Component description file for the SkyLake SiPkg DXE libraries. +# Build description file for Kaby Lake silicon DXE libraries. # -# Copyright (c) 2017, Intel Corporation. All rights reserved.
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## =20 +[LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIVER,Li +braryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,LibraryCl +asses.common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER] # # Silicon Init Dxe Library # diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc b/Silicon/In= tel/KabylakeSiliconPkg/SiPkgPeiLib.dsc index 86e34ff359..5334598544 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkgPeiLib.dsc @@ -1,5 +1,5 @@ ## @file -# Component description file for the SkyLake SiPkg PEI libraries. +# Build description file for Kaby Lake silicon PEI libraries. # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # @@ -7,6 +7,7 @@ # ## =20 +[LibraryClasses] # # Silicon Init Pei Library # -- 2.16.2.windows.1