From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module
Date: Fri, 25 Oct 2019 01:29:45 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5B744B4@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20191024022034.25768-2-prince.agyeman@intel.com>
Please remember to put the [edk2-platforms] header on the email next time.
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Agyeman, Prince <prince.agyeman@intel.com>
Sent: Wednesday, October 23, 2019 7:21 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2307
Updated SimicsX58SktPkg to use the source version of UefiCpuPkg/ResetVector/Vtf0. This will allow the Vtf0 binary to be removed from the edk2 repository
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc | 2 +-
Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
index af83c380b8..efa829ba9e 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
+++ b/Silicon/Intel/SimicsX58SktPkg/SktPkgPei.dsc
@@ -10,5 +10,5 @@
#
# SEC Phase modules
#
- UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+ UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
UefiCpuPkg/CpuMpPei/CpuMpPei.inf
diff --git a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
index 5019e362e3..dafca1ad36 100644
--- a/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
+++ b/Silicon/Intel/SimicsX58SktPkg/SktSecInclude.fdf
@@ -13,4 +13,4 @@
# The code in this FV handles the initial firmware startup, and # decompresses the PEI and DXE FVs which handles the rest of the boot sequence.
#
-INF RuleOverride=RESET_VECTOR USE = IA32 UefiCpuPkg/ResetVector/Vtf0/Bin/ResetVector.inf
+INF RuleOverride=RESET_VECTOR USE = IA32
+UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf
--
2.19.1.windows.1
next prev parent reply other threads:[~2019-10-25 1:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 2:20 [edk2-platforms] [PATCH 0/2] Replace vtf0 bin with source version Agyeman, Prince
2019-10-24 2:20 ` [PATCH 1/2] SimicsX58SktPkg: Replace vtf0 bin with source module Agyeman, Prince
2019-10-24 16:50 ` Kubacki, Michael A
2019-10-25 1:29 ` Nate DeSimone [this message]
2019-10-24 2:20 ` [PATCH 2/2] SimicsOpenBoardPkg: Update Vtf0 binary rule in Fdf Agyeman, Prince
2019-10-24 16:50 ` Kubacki, Michael A
2019-10-25 1:29 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0AB5B744B4@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox