Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH 1/3] EdkRepo: Multiple Command Package Configuration Support

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Desimone, Ashley E
Sent: Monday, October 28, 2019 4:23 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo][PATCH 1/3] EdkRepo: Multiple Command Package Configuration Support

Add support for a new required sections, command-packages and preferred-command-packages,to the GlobalConfig class.
Additionaly update the existing edkrepo.cfg file.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
---
 edkrepo/config/config_factory.py     | 12 +++++++++++-
 edkrepo_installer/Vendor/edkrepo.cfg |  6 ++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_factory.py
index 7a39554..38844d7 100644
--- a/edkrepo/config/config_factory.py
+++ b/edkrepo/config/config_factory.py
@@ -123,11 +123,21 @@ class GlobalConfig(BaseConfig):
                 CfgProp('sparsecheckout', 'always_exclude', 'sparsecheckout_always_exclude', None, True),
                 CfgProp('f2f-cherry-pick', 'ignored_folder_substrings', 'f2f_cp_ignored_folder_substrings'),
                 CfgProp('git-ver', 'minimum', 'minimum_req_git_ver', None, True),
-                CfgProp('git-ver', 'recommended', 'rec_git_ver', None, True)]
+                CfgProp('git-ver', 'recommended', 'rec_git_ver', None, True),
+                CfgProp('command-packages', 'packages', 'command_packages', None, True),
+                CfgProp('preferred-command-package', 
+ 'preferred-package', 'pref_pkg', None, True)]
         if not os.path.isfile(self.filename):
             raise EdkrepoGlobalConfigNotFoundException("edkrepo global config file {} does not exist".format(self.filename))
         super().__init__(self.filename, True)
 
+    @property
+    def command_packages_list(self):
+        initial_list = self.command_packages.split('|')
+        pkg_list = []
+        for pkg in initial_list:
+            pkg_list.append(pkg.strip())
+        return pkg_list
+
     @property
     def manifest_repo_abs_local_path(self):
         """Provides an absolute path to the manifest repo based on configuration file values."""
diff --git a/edkrepo_installer/Vendor/edkrepo.cfg b/edkrepo_installer/Vendor/edkrepo.cfg
index 08724fd..0312c74 100644
--- a/edkrepo_installer/Vendor/edkrepo.cfg
+++ b/edkrepo_installer/Vendor/edkrepo.cfg
@@ -7,6 +7,12 @@ LocalPath = manifest-master  minimum = 2.13.0  recommended = 2.16.2
 
+[command-packages]
+packages = edkrepo.commands
+
+[preferred-command-package]
+preferred-package = edkrepo.commands
+
 [sparsecheckout]
 always_include = BaseTools|Conf|*.*
 always_exclude =
--
2.16.2.windows.1