From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.240.1572484824744908959 for ; Wed, 30 Oct 2019 18:20:24 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 18:20:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,249,1569308400"; d="scan'208";a="230669558" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2019 18:20:23 -0700 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 18:20:12 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX121.amr.corp.intel.com ([169.254.10.88]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 18:20:12 -0700 From: "Nate DeSimone" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build Output Directory Thread-Topic: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build Output Directory Thread-Index: AQHVjpiKbTB1LPQafkaHtD8xDBIvIKdz9Wdg Date: Thu, 31 Oct 2019 01:20:11 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5B86F20@ORSMSX113.amr.corp.intel.com> References: <20191029203627.18964-1-prince.agyeman@intel.com> In-Reply-To: <20191029203627.18964-1-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzJmZTg3OTctYWUzYy00MmNiLTlhNmYtNzcwNGNhY2YyNTQzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRUZmVktPelpRR1FZR1pZcFZEbFpuQ3JSd3JMNm9DZEgxS1B4aHJ1ZWpKTmxJa2llajdLazgrU0hENUJIU1lLayJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Agyeman, Prince =20 Sent: Tuesday, October 29, 2019 1:36 PM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Change Build Output D= irectory REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2250 Changed BoardX558ich10's build directory to Build/SimicsOpenBoardPkg/BoardX58Ich10 to align it with align with the othe= r Intel board packages Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../BoardX58Ich10/OpenBoardPkg.dsc | 13 +++++++------ .../BoardX58Ich10/OpenBoardPkg.fdf | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.d= sc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index 4f8ab4170d..78f1e80990 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -20,16 +20,17 @@ DEFINE PCH_PKG =3D SimicsIch10Pkg DEFINE DXE_ARCH =3D X64 DEFINE PEI_ARCH =3D IA32 + DEFINE PROJECT =3D $(BOARD_PKG)/$(BOARD_NAME) =20 PLATFORM_NAME =3D SimicsX58 PLATFORM_GUID =3D EE8EBB5A-CC95-412f-9987-2AF70F88B69A PLATFORM_VERSION =3D 0.1 DSC_SPECIFICATION =3D 0x00010005 - OUTPUT_DIRECTORY =3D Build/SimicsX58Ia32X64 + OUTPUT_DIRECTORY =3D Build/$(PROJECT) SUPPORTED_ARCHITECTURES =3D IA32|X64 BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT - FLASH_DEFINITION =3D $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardP= kg.fdf + FLASH_DEFINITION =3D $(PROJECT)/OpenBoardPkg.fdf =20 DEFINE SMM_REQUIRE =3D TRUE =20 @@ -41,7 +42,7 @@ DEFINE NETWORK_ISCSI_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE =20 - !include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgPcd.dsc + !include $(PROJECT)/OpenBoardPkgPcd.dsc !include NetworkPkg/NetworkDefines.dsc.inc =20 ##########################################################################= ###### @@ -80,7 +81,7 @@ ####################################### # Build Option Includes ####################################### -!include $(BOARD_PKG)/$(BOARD_NAME)/OpenBoardPkgBuildOption.dsc +!include $(PROJECT)/OpenBoardPkgBuildOption.dsc =20 ##########################################################################= ###### # @@ -175,11 +176,11 @@ ##################################### $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf = { - BoardInitLib|$(BOARD_PKG)/$(BOARD_NAME)/Library/BoardInitLib/PeiBoar= dInitPreMemLib.inf + =20 + BoardInitLib|$(PROJECT)/Library/BoardInitLib/PeiBoardInitPreMemLib.inf } $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitPei/PlatformInitPostMem.inf= { - BoardInitLib|$(BOARD_PKG)/$(BOARD_NAME)/Library/BoardInitLib/PeiBoar= dInitPostMemLib.inf + =20 + BoardInitLib|$(PROJECT)/Library/BoardInitLib/PeiBoardInitPostMemLib.in + f } $(PLATFORM_PACKAGE)/PlatformInit/ReportFv/ReportFvPei.inf $(PLATFORM_PACKAGE)/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem= .inf diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.f= df b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index 0c27cb0ef2..39226251a7 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -13,7 +13,7 @@ # Build the variable store and the firmware code as one unified flash devi= ce # image. # -[FD.SIMICSX58IA32X64] +[FD.BOARDX58ICH10] BaseAddress =3D $(FW_BASE_ADDRESS) Size =3D $(FW_SIZE) ErasePolarity =3D 1 -- 2.19.1.windows.1