From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.323.1572485165822693019 for ; Wed, 30 Oct 2019 18:26:05 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 18:26:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,249,1569308400"; d="scan'208";a="401708534" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 30 Oct 2019 18:26:05 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX109.amr.corp.intel.com ([169.254.11.239]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 18:26:04 -0700 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chiu, Chasel" , Jeremy Soller Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct Platform Hook Library references Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg: Correct Platform Hook Library references Thread-Index: AQHVjq1jLx6+AY0od0udG67tPd/Kp6dz9qfQ Date: Thu, 31 Oct 2019 01:26:04 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5B86F79@ORSMSX113.amr.corp.intel.com> References: <20191029230513.38520-1-michael.a.kubacki@intel.com> <20191029230513.38520-2-michael.a.kubacki@intel.com> In-Reply-To: <20191029230513.38520-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODZkYzZjMDctZmUxZS00MDE0LWI4ZTQtMTU2ZmY0ZjAxOGM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVTYzTkdKVFJaY1pTNElGcmJPdE5oTzk4Q1wvTVpKVUZjSXh6cDR5aFFTZng0N2tmWGdmbnYzdWZNYVVFc1NtSncifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, October 29, 2019 4:05 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Jeremy Soller Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeOpenBoardPkg:= Correct Platform Hook Library references Many file descriptions reference "Platform Hook Library" when the file is = not related to the PlatformHookLib library class. This change updates those= references in KabylakeOpenBoardPkg to a more accurate description. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller Signed-off-by: Michael Kubacki --- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Dxe= BoardAcpiTableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Dxe= MultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= BoardAcpiEnableLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= MultiBoardAcpiSupportLib.inf | 2 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/SmmGa= lagoPro3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Dxe= BoardAcpiTableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Dxe= KabylakeRvp3AcpiTableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Dxe= MultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= BoardAcpiEnableLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= KabylakeRvp3AcpiEnableLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= MultiBoardAcpiSupportLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/Smm= SiliconAcpiEnableLib.c | 10 +++++----- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/Pei= BoardInitPostMemLib.c | 4 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/Pei= BoardInitPreMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/Pei= MultiBoardInitPostMemLib.c | 2 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/Pei= MultiBoardInitPreMemLib.c | 2 +- 16 files changed, 23 insertions(+), 23 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Boar= dAcpiLib/DxeBoardAcpiTableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/Kab= ylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib.inf index e7a30a726a..bfb58e868f 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/DxeBoardAcpiTableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeBoardAcpiTableLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 Board ACPI library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Bo= ardAcpiLib/DxeMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoa= rdPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSupportLib.inf index 0bd821ffbb..00cdbe80ce 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/DxeMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeMultiBoardAcpiSupportLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 Multi-Board ACPI Support library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Bo= ardAcpiLib/SmmBoardAcpiEnableLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/= KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLib.inf index cad0caa79c..46a714dc1d 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmBoardAcpiEnableLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmBoardAcpiEnableLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 SMM Board ACPI Enable library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Bo= ardAcpiLib/SmmMultiBoardAcpiSupportLib.inf b/Platform/Intel/KabylakeOpenBoa= rdPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf index 6628d30b6b..fca63c8314 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmMultiBoardAcpiSupportLib.inf +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmMultiBoardAcpiSupportLib.inf @@ -1,5 +1,5 @@ ### @file -# Platform Hook Library instance for Kaby Lake RVP3. +# Kaby Lake RVP 3 SMM Multi-Board ACPI Support library # # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/Boar= dAcpiLib/SmmGalagoPro3AcpiEnableLib.c b/Platform/Intel/KabylakeOpenBoardPkg= /GalagoPro3/Library/BoardAcpiLib/SmmGalagoPro3AcpiEnableLib.c index 265c00551a..b984e25ce3 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/= SmmGalagoPro3AcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi +++ b/SmmGalagoPro3AcpiEnableLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + System 76 Galago Pro 3 Board ACPI Enable library =20 Copyright (c) 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeBoardAcpiTableLib= .c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/= DxeBoardAcpiTableLib.c index 60c11290c0..8699f8d403 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/DxeBoardAcpiTableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeBoardAcpiTableLib.c @@ -1,7 +1,7 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Board ACPI library =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Boar= dAcpiLib/DxeKabylakeRvp3AcpiTableLib.c b/Platform/Intel/KabylakeOpenBoardPk= g/KabylakeRvp3/Library/BoardAcpiLib/DxeKabylakeRvp3AcpiTableLib.c index eceac3d037..d66283f7e8 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/DxeKabylakeRvp3AcpiTableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeKabylakeRvp3AcpiTableLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Board ACPI Library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/DxeMultiBoardAcpiSup= portLib.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardA= cpiLib/DxeMultiBoardAcpiSupportLib.c index 0c78342a1d..dfb1b028f1 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/DxeMultiBoardAcpiSupportLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/DxeMultiBoardAcpiSupportLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Multi-Board ACPI Support library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmBoardAcpiEnableLi= b.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib= /SmmBoardAcpiEnableLib.c index 3de0ae34a7..e89624ea03 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmBoardAcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmBoardAcpiEnableLib.c @@ -1,7 +1,7 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 SMM Board ACPI Enable library =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Boar= dAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c b/Platform/Intel/KabylakeOpenBoardP= kg/KabylakeRvp3/Library/BoardAcpiLib/SmmKabylakeRvp3AcpiEnableLib.c index c9d0cda831..54755dd176 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmKabylakeRvp3AcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmKabylakeRvp3AcpiEnableLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 SMM Board ACPI Enable library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmMultiBoardAcpiSup= portLib.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardA= cpiLib/SmmMultiBoardAcpiSupportLib.c index 96eaf6e6e8..fb678a19bc 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmMultiBoardAcpiSupportLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmMultiBoardAcpiSupportLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 SMM Multi-Board ACPI Support library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/SmmSiliconAcpiEnable= Lib.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiL= ib/SmmSiliconAcpiEnableLib.c index 185aa4ad2d..7f63a12bf4 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi= b/SmmSiliconAcpiEnableLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi +++ Lib/SmmSiliconAcpiEnableLib.c @@ -1,7 +1,7 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 SMM Silicon ACPI Enable library =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -68,7 +68,7 @@ SiliconEnableAcpi ( PCI_DEVICE_NUMBER_PCH_LPC, PCI_FUNCTION_NUMBER_PCH_LPC ); - + // // Get the ACPI Base Address // @@ -127,7 +127,7 @@ SiliconEnableAcpi ( OutputValue =3D IoRead32 (AcpiBaseAddr + 0x38); OutputValue =3D OutputValue & ~(1 << (UINTN) PcdGet8 (PcdSmcExtSmiBitPo= sition)); IoWrite32 (AcpiBaseAddr + 0x38, OutputValue); - + =20 // // Enable SCI @@ -149,7 +149,7 @@ SiliconDisableAcpi ( { UINT16 AcpiBaseAddr; UINT32 Pm1Cnt; - + // // Get the ACPI Base Address // diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Boar= dInitLib/PeiBoardInitPostMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Kab= ylakeRvp3/Library/BoardInitLib/PeiBoardInitPostMemLib.c index d88c4eb461..2e079a0387 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLi= b/PeiBoardInitPostMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit +++ Lib/PeiBoardInitPostMemLib.c @@ -1,7 +1,7 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Board Initialization Post-Memory library =20 -Copyright (c) 2017, Intel Corporation. All rights reserved.
+Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/Boar= dInitLib/PeiBoardInitPreMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/Kaby= lakeRvp3/Library/BoardInitLib/PeiBoardInitPreMemLib.c index f1829c287d..f5c695ecff 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLi= b/PeiBoardInitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit +++ Lib/PeiBoardInitPreMemLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Board Initialization Pre-Memory library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPos= tMemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardI= nitLib/PeiMultiBoardInitPostMemLib.c index 72cdeaa0b2..70e93e94da 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLi= b/PeiMultiBoardInitPostMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit +++ Lib/PeiMultiBoardInitPostMemLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Multi-Board Initialization Post-Memory library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent diff --git a/Platform/Intel/= KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/PeiMultiBoardInitPre= MemLib.c b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardIn= itLib/PeiMultiBoardInitPreMemLib.c index 3cf391c0bb..59b3177201 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLi= b/PeiMultiBoardInitPreMemLib.c +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit +++ Lib/PeiMultiBoardInitPreMemLib.c @@ -1,5 +1,5 @@ /** @file - Platform Hook Library instances + Kaby Lake RVP 3 Multi-Board Initialization Pre-Memory library =20 Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent -- 2.16.2.windows.1