From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.401.1572485604039779806 for ; Wed, 30 Oct 2019 18:33:24 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 18:33:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,249,1569308400"; d="scan'208";a="203373501" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 30 Oct 2019 18:33:23 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 30 Oct 2019 18:33:23 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX152.amr.corp.intel.com ([169.254.8.128]) with mapi id 14.03.0439.000; Wed, 30 Oct 2019 18:33:22 -0700 From: "Nate DeSimone" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Sinha, Ankit" , "Kubacki, Michael A" Subject: Re: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure Thread-Topic: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure Thread-Index: AQHVj0QebkC4kGSJvEu5s6zK2lqa8qdz9rJw Date: Thu, 31 Oct 2019 01:33:22 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5B86FB6@ORSMSX113.amr.corp.intel.com> References: <20191030170436.16708-1-prince.agyeman@intel.com> In-Reply-To: <20191030170436.16708-1-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzA2MWYzMzYtZTYzMC00MjA3LTkyNmQtYTBkMzFmZTA1MDhmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYnRxbytGZUtmMnFcL3JiNHp6TVJ4OGVJaUZZamRib3E3dTNSeXBKUUZXTmNjWm93NW16YVZiMWpsRVZyVzBsdzkifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Your whitespace doesn't quite match edk2 coding style guidelines, but we ca= n fix that during commit. Reviewed-by: Nate DeSimone -----Original Message----- From: Agyeman, Prince =20 Sent: Wednesday, October 30, 2019 10:05 AM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-platforms] [PATCH] SimicsOpenBoardPkg: Fix gcc build failure REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2225 Currently, gcc 5 encounters an error "unused-but-set-variable" in BdsPlatfo= rm.c as a result of a Status variable not being used after it's set. This was fixed by printing the Status variable when EfiBootManagerDeleteLoa= dOptionVariable function encounters an error Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../Library/PlatformBootManagerLib/BdsPlatform.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerL= ib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootMa= nagerLib/BdsPlatform.c index 7aa3860f75..a4b010be63 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsP= latform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/B +++ dsPlatform.c @@ -348,6 +348,10 @@ PlatformBootManagerBeforeConsole ( NvBootOptions =3D EfiBootManagerGetLoadOptions (&NvBootOptionCount, Load= OptionTypeBoot); for (Index =3D 0; Index < NvBootOptionCount; Index++) { Status =3D EfiBootManagerDeleteLoadOptionVariable (NvBootOptions[Index= ].OptionNumber, LoadOptionTypeBoot); + if(EFI_ERROR (Status)){ + DEBUG ((DEBUG_ERROR, + "%a: removing Boot#%04x %r\n", __FUNCTION__, (UINT32)NvBootOptio= ns[Index].OptionNumber, Status)); + } } =20 InstallDevicePathCallback (); -- 2.19.1.windows.1