From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com []) by mx.groups.io with SMTP id smtpd.web11.68.1573079952902835736 for ; Wed, 06 Nov 2019 14:39:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 14:39:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="227634226" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga004.fm.intel.com with ESMTP; 06 Nov 2019 14:39:14 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX110.amr.corp.intel.com ([169.254.10.200]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 14:39:13 -0800 From: "Nate DeSimone" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "Kubacki, Michael A" , "Chiu, Chasel" Subject: Re: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Topic: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds Thread-Index: AQHVlEEquiq2bAyaTEyowUcEvgJA9ad+vS9w Date: Wed, 6 Nov 2019 22:39:13 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BA471E@ORSMSX113.amr.corp.intel.com> References: <20191106012603.4724-1-prince.agyeman@intel.com> <20191106012603.4724-5-prince.agyeman@intel.com> In-Reply-To: <20191106012603.4724-5-prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTkzZTQ0NmItN2IxMy00MGU1LTgxM2ItMzhjNjBlY2NkNGY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNXA1dHdyeXhWRnpDWXhPNjYyNHBcL1FGRXZDR2FnaXFySnZtVms2Ujd6WjN3TFR2XC9KbFpLM2M2ZlVFOUZnaEorIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Agyeman, Prince =20 Sent: Tuesday, November 5, 2019 5:26 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build P= cds * Added ps2 keyboard and Uart enable PCDs. * Added PCDs to define IO ports for Uart1 and Uart2 Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Intel/BoardModulePkg/BoardModulePkg.dec | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec b/Platform/In= tel/BoardModulePkg/BoardModulePkg.dec index 8a811602e6..26e662f711 100644 --- a/Platform/Intel/BoardModulePkg/BoardModulePkg.dec +++ b/Platform/Intel/BoardModulePkg/BoardModulePkg.dec @@ -46,3 +46,24 @@ ## {7F4EE1A3-C1F3-43E4-BA1A-39DCDE46C343} gBoardModulePkgTokenSpaceGuid =3D { 0x7f4ee1a3, 0xc1f3, 0x43e4, { 0xba, = 0x1a, 0x39, 0xdc, 0xde, 0x46, 0xc3, 0x43 } } =20 +[PcdsFixedAtBuild] + ## PcdPs2KbMsEnable 0x0:Disable, 0x1:Enable + gBoardModulePkgTokenSpaceGuid.PcdPs2KbMsEnable|0x00|UINT8|0x00000001 + + ## SuperIo Pci ISA Bridge info. It is an array that contains the=20 + Segment, Bus, Device and Function # information describing the PCI=20 + Device Info. The first byte is the segment number, # the second is=20 + the bus number, third byte is the device number, the fourth byte # is t= he Function. + gBoardModulePkgTokenSpaceGuid.PcdSuperIoPciIsaBridgeDevice|{0xFF,=20 + 0xFF, 0xFF, 0xFF}|VOID*|0x00000002 + + ## PcdUart1Enable 0x0:Disable, 0x1:Enable + gBoardModulePkgTokenSpaceGuid.PcdUart1Enable|0x00|UINT8|0x00000003 + =20 + gBoardModulePkgTokenSpaceGuid.PcdUart1IrqMask|0x0010|UINT16|0x00000004 + gBoardModulePkgTokenSpaceGuid.PcdUart1IoPort|0x03F8|UINT16|0x00000005 + gBoardModulePkgTokenSpaceGuid.PcdUart1Length|0x08|UINT8|0x00000006 + + ## PcdUart2Enable 0x0:Disable, 0x1:Enable + gBoardModulePkgTokenSpaceGuid.PcdUart2Enable|0x00|UINT8|0x00000007 + =20 + gBoardModulePkgTokenSpaceGuid.PcdUart2IrqMask|0x0008|UINT16|0x00000008 + gBoardModulePkgTokenSpaceGuid.PcdUart2IoPort|0x02F8|UINT16|0x00000009 + gBoardModulePkgTokenSpaceGuid.PcdUart2Length|0x08|UINT8|0x0000000A -- 2.19.1.windows.1