From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.194.1573080278223986807 for ; Wed, 06 Nov 2019 14:44:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 14:44:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="227635887" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga004.fm.intel.com with ESMTP; 06 Nov 2019 14:44:37 -0800 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 6 Nov 2019 14:44:37 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.28]) by ORSMSX126.amr.corp.intel.com ([169.254.4.48]) with mapi id 14.03.0439.000; Wed, 6 Nov 2019 14:44:37 -0800 From: "Nate DeSimone" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Pandya, Puja" Subject: Re: [edk2-devel][edk2-staging/EdkRepo][PATCH v2 8/8] EdkRepo: Argument Strings Refactor - EdkRepo Command Thread-Topic: [edk2-devel][edk2-staging/EdkRepo][PATCH v2 8/8] EdkRepo: Argument Strings Refactor - EdkRepo Command Thread-Index: AQHVlPMcDsaCrLybZUmghupFSfjBZqd+vQtQ Date: Wed, 6 Nov 2019 22:44:36 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BA48B4@ORSMSX113.amr.corp.intel.com> References: <20191106223944.18036-1-ashley.e.desimone@intel.com> <20191106223944.18036-8-ashley.e.desimone@intel.com> In-Reply-To: <20191106223944.18036-8-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjI2MWRiMGYtOTU5MS00NjZkLWIwMjMtNWViMzAxMTk2ODAwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSHpUY0xFcTRMZ1ZvRVwvY2NBR2hcL1BYMmJYbmhublJUSFwvVEhSUDFzR01ZeXNGcWRCOWhFN0hVaUN1YlgrVmNObSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Desimone, Ashley E =20 Sent: Wednesday, November 6, 2019 2:40 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH v2 8/8] EdkRepo: Argument= Strings Refactor - EdkRepo Command Move all argument strings for edkrepo_command.py to edkrepo/commands/argume= nts/edkrepo_cmd_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- .../arguments/edkrepo_cmd_args.py} | 9 +++------ edkrepo/commands/edkrepo_command.py | 16 ++++++------= ---- 2 files changed, 9 insertions(+), 16 deletions(-) rename edkrepo/{common/= argument_strings.py =3D> commands/arguments/edkrepo_cmd_args.py} (65%) diff --git a/edkrepo/common/argument_strings.py b/edkrepo/commands/argument= s/edkrepo_cmd_args.py similarity index 65% rename from edkrepo/common/argument_strings.py rename to edkrepo/commands/arguments/edkrepo_cmd_args.py index 75e13ee..f2d7eb6 100644 --- a/edkrepo/common/argument_strings.py +++ b/edkrepo/commands/arguments/edkrepo_cmd_args.py @@ -7,15 +7,12 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent # =20 -'''Contains help and description strings for arguments in command meta dat= a.''' +'''Contains help and description strings for arguments in the=20 +edkrepo_command meta data. +''' =20 -#Args for edk_command.py -VERBOSE_DESCRIPTION =3D 'Enable verbose output' VERBOSE_HELP =3D 'Increases command verbosity' -DRY_RUN_DESCRIPTION =3D "Don't actually do anything" DRY_RUN_HELP =3D "Don't actually do anything" OVERRIDE_HELP =3D 'Ignore warnings' SUBMODULE_SKIP_HELP =3D 'Skip the pull or sync of any submodules.' COLOR_HELP =3D 'Force color output (useful with \'less -r\')' - - diff --git a/edkrepo/commands/edkrepo_command.py b/edkrepo/commands/edkrepo= _command.py index 75b6f35..f69bdb8 100644 --- a/edkrepo/commands/edkrepo_command.py +++ b/edkrepo/commands/edkrepo_command.py @@ -7,9 +7,7 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent # =20 -# Our modules -from edkrepo.common.argument_strings import VERBOSE_DESCRIPTION, VERBOSE_H= ELP, DRY_RUN_DESCRIPTION, DRY_RUN_HELP, COLOR_HELP -from edkrepo.common.arg= ument_strings import OVERRIDE_HELP, SUBMODULE_SKIP_HELP +import edkrepo.commands.arguments.edkrepo_cmd_args as arguments =20 =20 class EdkrepoCommand(object): @@ -25,30 +23,28 @@ VerboseArgument =3D {'name': 'verbose', 'short-name': 'v', 'positional': False, 'required': False, - 'description': VERBOSE_DESCRIPTION , - 'help-text': VERBOSE_HELP} + 'help-text': arguments.VERBOSE_HELP} =20 =20 DryRunArgument =3D {'name': 'dry-run', 'positional': False, 'required': False, - 'description': DRY_RUN_DESCRIPTION, - 'help-text': DRY_RUN_HELP} + 'help-text': arguments.DRY_RUN_HELP} =20 OverrideArgument =3D {'name': 'override', 'short-name': 'o', 'positional': False, 'required': False, - 'help-text': OVERRIDE_HELP} + 'help-text': arguments.OVERRIDE_HELP} =20 ColorArgument =3D {'name' : 'color', 'short-name': 'c', 'positional' : False, 'required' : False, - 'help-text' : COLOR_HELP} + 'help-text' : arguments.COLOR_HELP} =20 SubmoduleSkipArgument =3D {'name': 'skip-submodule', 'short-name' : 's', 'positional' : False, 'required' : False, - 'help-text' : SUBMODULE_SKIP_HELP} + 'help-text' : arguments.SUBMODULE_SKIP_HELP} -- 2.16.2.windows.1