public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>
Subject: Re: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py
Date: Thu, 14 Nov 2019 23:17:53 +0000	[thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BD2061@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20191114224658.21900-1-ashley.e.desimone@intel.com>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Thursday, November 14, 2019 2:47 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>
Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py

Add traceback to the case where the preferred entry point cannot be loaded.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
---
 edkrepo/edkrepo_entry_point.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.py index d63d8cb..76a5a18 100644
--- a/edkrepo/edkrepo_entry_point.py
+++ b/edkrepo/edkrepo_entry_point.py
@@ -90,8 +90,9 @@ def main():
         mod = importlib.import_module(pref_entry)
         func = getattr(mod, pref_entry_func)
         func()
-    except:
+    except Exception as e:
         print('Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py')
+        traceback.print_exc()
         import edkrepo.edkrepo_cli
         edkrepo.edkrepo_cli.main()
 
@@ -100,4 +101,4 @@ if __name__ == "__main__":
         sys.exit(main())
     except Exception as e:
         traceback.print_exc()
-        sys.exit(1)
\ No newline at end of file
+        sys.exit(1)
--
2.16.2.windows.1


      reply	other threads:[~2019-11-14 23:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 22:46 [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py Desimone, Ashley E
2019-11-14 23:17 ` Nate DeSimone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02A34F284D1DA44BB705E61F7180EF0AB5BD2061@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox