From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.609.1573861631870345414 for ; Fri, 15 Nov 2019 15:47:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:47:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="208281838" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 15 Nov 2019 15:47:10 -0800 Received: from orsmsx115.amr.corp.intel.com (10.22.240.11) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 15:47:10 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX115.amr.corp.intel.com ([169.254.4.121]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:47:09 -0800 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Agyeman, Prince" , "Chiu, Chasel" , "Bi, Dandan" , "Dong, Eric" , "Oram, Isaac W" , "Gao, Liming" , "Chaganty, Rangasai V" , "Wei, David Y" Subject: Re: [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor Thread-Topic: [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor Thread-Index: AQHVmdJt3rqXm3mb3EqID7uz87E7iKeMxNKg Date: Fri, 15 Nov 2019 23:47:09 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB064@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjE3MGQxZjgtZTc5Yi00YzU4LWFmNzYtNWQ4YWVlYzFlNjRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmJRR1JWNmR5SnFuZEpzRWpraFhNXC91XC95SnRjUmFpOVNJbW9vNFA0bmgrWGZlRXF0YWxWTmVxUDUrdVErZHo5In0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, I have completed reviewing your considerably large patch series. Overall, I= have approved 80% of your patches without modification. I do have feedback= for 10 of the patches however. In the interest of efficiency, please reuse= my "Reviewed-by" for 39 patches that I have already approved for subsequen= t versions of the patch series. Also, in the interest of efficiency, I have= consolidated my feedback for the entire series below. General Feedback: 1. This is a vast improvement over the current mechanisms for advanced feat= ures! In particular I found the MUXing capability you implemented in Advanc= edFeaturePkg/Include/AdvancedFeatures.dsc excellent. It reminds me of KConf= ig and I think it will make it a lot easier to get started with a new MinPl= atform board port! Thank you! 2. With the addition of Leif's recent changes to Maintainers.txt, your patc= h series no longer cleanly applies to the tip of master. Please rebase your= patch series. 3. Please at least fill in the "Purpose" section of all the new Readme.md f= iles you are creating, don't leave the entire file as TODOs. This feedback applies for the following patches: Patch 14/49 - Features/Intel: Add S3FeaturePkg Patch 16/49 - Features/Intel/IpmiFeaturePkg: Add initial package Patch 20/49 - Features/Intel/SmbiosFeaturePkg: Add initial package Patch 25/49 - Features/Intel/Usb3DebugFeaturePkg: Add initial package Patch 27/49 - Features/Intel/UserAuthFeaturePkg: Add initial package Patch 28/49 - Features/Intel/NetworkFeaturePkg: Add initial package Patch 04/49 - Features/Intel: Add Readme.md 1. Readme.md, line 211: Please also add a Linux/Mac example. Patch 17/49 - Features/Intel/IpmiFeaturePkg: Add libraries 1. IpmiFeaturePkg/Include/Library/IpmiCommandLib.h - Update copyright year 2. IpmiFeaturePkg/Include/Library/IpmiPlatformHookLib.h - Update copyright = year 3. IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c - Update = copyright year Patch 18/49 - Features/Intel/IpmiFeaturePkg: Add modules 1. IpmiFeaturePkg/BmcAcpi/BmcSsdt/BmcSsdt.asl - Update copyright year. 2. IpmiFeaturePkg/BmcAcpi/BmcSsdt/IpmiOprRegions.asi - Update copyright yea= r. 3. IpmiFeaturePkg/Frb/FrbDxe.c - Update copyright year. 4. IpmiFeaturePkg/IpmiInit/DxeIpmiInit.c - Update copyright year 5. IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c - Upd= ate copyright year 6. IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c - U= pdate copyright year 7. IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.c= - Update copyright year Patch 20/49 - Features/Intel/SmbiosFeaturePkg: Add initial package 1. SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasic.h - Update copyright year 2. SmbiosFeaturePkg/SmbiosBasicDxe/Type0BiosVendorFunction.c - Update copyr= ight year 3. SmbiosFeaturePkg/SmbiosBasicDxe/Type1SystemManufacturerFunction.c - Upda= te copyright year 4. SmbiosFeaturePkg/SmbiosBasicDxe/Type2BaseBoardManufacturerFunction.c - U= pdate copyright year 5. SmbiosFeaturePkg/SmbiosBasicDxe/Type32BootInformationFunction.c - Update= copyright year 6. SmbiosFeaturePkg/SmbiosBasicDxe/Type3ChassisManufacturerFunction.c - Upd= ate copyright year Patch 25/49 - Features/Intel/Usb3DebugFeaturePkg: Add initial package: 1. Why rename Usb3DebugPortParameterLib.h to Library/Usb3DebugPortParamLib.= h? Patch 43/49 - Platform/Intel/Readme.md Content update 1. Readme.md, line 269: Please also add a Linux/Mac example. I look forward to your second series! Regards, Nate -----Original Message----- From: Kubacki, Michael A =20 Sent: Tuesday, November 12, 2019 7:27 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Bi, Dandan ; Dong, Eric ; Oram, Isaac W ; Gao, Liming ; Desimone, Nathaniel L ; Chaganty, Rang= asai V ; Wei, David Y Subject: [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor RFC:https://edk2.groups.io/g/devel/message/49880 This patch series introduces a consistent design for Intel advanced feature= s. Advanced features in this context refer to the definition stated in the EDK II Minimum Platform specification. Information regarding this feature design is provided in Features/Intel/Readme.md. An RFC was sent to the mailing list on 11/1/2019 that stated the intention of creating the Features directory in edk2-platforms for this purpose and that change is implemented in this patch series. Testing performed: * Feature packages and board packages build successfully * Board packages boot successfully to their supported OS * Board package Stage 4 and Stage 6 tested The actual feature source implementation was not functionally modified. Any issues reported by PatchCheck.py were fixed. Future changes will be made to individually address improving the quality of each feature and to add new features. This patch series is intended to provide a foundation for future changes to the advanced feature design as an incremental improvement over the current state and should not be considered the final state. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Dandan Bi Cc: Eric Dong Cc: Isaac W Oram Cc: Liming Gao Cc: Nate DeSimone Cc: Sai Chaganty Cc: Wei David Y Signed-off-by: Michael Kubacki Michael Kubacki (49): AdvancedFeaturePkg: Package DSC style cleanup DebugFeaturePkg: Package DSC style cleanup UserInterfaceFeaturePkg: Package DSC style cleanup Features/Intel: Add Readme.md Features/Intel/PowerManagement: Add Readme.md Features/Intel/OutOfBandManagement: Add Readme.md Features/Intel/SystemInformation: Add Readme.md Features/Intel/Debug: Add Readme.md Features/Intel/UserInterface: Add Readme.md Features/Intel/Network: Add Readme.md TemplateFeaturePkg: Add initial package SimicsOpenBoardPkg: Remove advanced feature references AdvancedFeaturePkg: Remove the S3 feature Features/Intel: Add S3FeaturePkg AdvancedFeaturePkg: Remove the IPMI feature Features/Intel/IpmiFeaturePkg: Add initial package Features/Intel/IpmiFeaturePkg: Add libraries Features/Intel/IpmiFeaturePkg: Add modules AdvancedFeaturePkg: Remove the SMBIOS feature Features/Intel/SmbiosFeaturePkg: Add initial package Features/Intel/SmbiosFeaturePkg: Update default strings DebugFeaturePkg: Remove the ACPI Debug feature Features/Intel/AcpiDebugFeaturePkg: Add initial package DebugFeaturePkg: Remove the USB3 Debug feature Features/Intel/Usb3DebugFeaturePkg: Add initial package UserInterfaceFeaturePkg: Remove the User Authentication feature Features/Intel/UserAuthFeaturePkg: Add initial package Features/Intel/NetworkFeaturePkg: Add initial package AdvancedFeaturePkg: Remove remaining contents AdvancedFeaturePkg: Move to Features/Intel AdvancedFeaturePkg: Add feature build support AdvancedFeaturePkg: Add temporary build workaround AdvancedFeaturePkg: Add FDF include files KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH KabylakeOpenBoardPkg/GalagoPro3: Add PEI_ARCH and DXE_ARCH WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add PEI_ARCH and DXE_ARCH SimicsOpenBoardPkg/BoardX58Ich10: Use PEI_ARCH and DXE_ARCH MinPlatformPkg: Add FvAdvancedPreMemory KabylakeOpenBoardPkg/KabylakeRvp3: Add FvAdvancedPreMemory KabylakeOpenBoardPkg/GalagoPro3: Add FvAdvancedPreMemory WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add FvAdvancedPreMemory Platform/Intel: Add advanced feature build support Platform/Intel/Readme.md Content update KabylakeOpenBoardPkg/GalagoPro3: Enable advanced features KabylakeOpenBoardPkg/KabylakeRvp3: Enable advanced features WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features SimicsOpenBoardPkg: Enable advanced features MinPlatformPkg: Install advanced feature FVs by stage enabled Maintainers.txt: Update Intel feature maintainers Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec = = | 31 +++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = = | 39 ++++ Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec = = | 57 +++++ Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dec = = | 30 +++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec = = | 46 ++++ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec = = | 30 +++ Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec = = | 172 +++++++++++= ++++ Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dec = = | 30 +++ Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec =3D> Fe= atures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec = | 24 +- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec = = | 153 -----------= -- Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec = = | 66 ------ Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = = | 4 + Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = = | 53 +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc = = | 56 +++++ Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildW= orkaround.dsc = | 74 +++++++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc = = | 30 +++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = = | 125 +++++++++++ Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc = = | 149 +++++++++++= ++ Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc = = | 30 +++ Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc = = | 152 +++++++++++= ++ Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc = = | 30 +++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = = | 144 +++++++++++= + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc = = | 31 +++ Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc = = | 122 ++++++++++ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc = = | 30 +++ Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.ds= c = | 115 ++++++++++ Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc = = | 30 +++ Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc = = | 113 ++++++++++ Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc = = | 30 +++ Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.ds= c = | 141 +++++++++++= + Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc = = | 30 +++ Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = = | 156 -----------= -- Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc = = | 19 -- Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedPeiInclude.dsc = = | 9 - Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc = = | 101 --------- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc = = | 62 +++--- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc = = | 1 + Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc = = | 61 +++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc = = | 1 + Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = = | 25 ++- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc = = | 12 +- Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc = = | 80 ------- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc = = | 60 +++-- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc= = | 1 + Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf = = | 57 +++++ Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf = = | 57 +++++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = = | 11 + Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PreMemory.fdf = = | 8 + Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/PostMemory.fdf = = | 8 + Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/PreMemory.fdf = = | 8 + Features/Intel/Network/NetworkFeaturePkg/Include/PostMemory.fdf = = | 10 + Features/Intel/Network/NetworkFeaturePkg/Include/PreMemory.fdf = = | 8 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf = = | 16 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf = = | 11 + Features/Intel/PowerManagement/S3FeaturePkg/Include/PostMemory.fdf = = | 8 + Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf = = | 10 + Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf = = | 10 + Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PreMemory.fdf = = | 8 + Features/Intel/TemplateFeaturePkg/Include/PostMemory.fdf = = | 8 + Features/Intel/TemplateFeaturePkg/Include/PreMemory.fdf = = | 8 + Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf = = | 12 + Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PreMemory.fdf = = | 8 + Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf = = | 20 -- Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPostMemoryInclud= e.fdf = | 8 - Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPreMemoryInclude= .fdf = | 9 - Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude= .fdf = | 20 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf = = | 48 ++-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclu= de.fdf = | 30 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = = | 48 ++-- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = = | 10 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/FlashMa= pInclude.fdf = | 24 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf = = | 48 ++-- Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildW= orkaround.inf = | 57 +++++ {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debugging/Ac= piDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebugDxe.inf = | 10 +- {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debugging/Ac= piDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebugSmm.inf = | 11 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.inf = | 12 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIoMmu.inf = | 12 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.inf = | 3 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.inf = | 10 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIoMmu.inf = | 10 +- Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Usb3DebugPortParamLib= Pcd/Usb3DebugPortParamLibPcd.inf = | 31 +++ {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcAcpi/BmcAcpi.inf = | 9 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcElog/BmcElog.inf = | 5 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Frb/FrbDxe.inf = | 10 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Frb/FrbPei.inf = | 10 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiFru/IpmiFru.inf = | 4 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiInit/DxeIpmiInit.inf = | 6 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiInit/PeiIpmiInit.inf = | 6 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLib.inf = | 6 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNu= ll.inf | 9 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/OsWdt/OsWdt.inf = | 7 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/SolStatus/SolStatus.inf = | 13 +- {Platform/Intel/AdvancedFeaturePkg/S3 =3D> Features/Intel/PowerManagement/= S3FeaturePkg/S3Pei}/S3Pei.inf = | 16 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBas= icDxe.inf = | 83 +++++++ {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPasswordLibNull= .inf | 5 +- {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/UserPasswordLib/UserPasswordLib.inf = | 2 +- {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/UserPasswordUiLib/UserPasswordUiLib.inf = | 2 +- {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= ication2Dxe.inf | 3 +- {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxe.inf | 3 +- {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationSmm.inf | 2 +- Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.inf= = | 28 --- Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf= = | 83 ------- Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/Usb3De= bugPortParameterLibPcd.inf = | 31 --- Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepor= tFvLib.inf = | 43 ++-- Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf = = | 1 - {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Include/Library/Usb3DebugPortLib.h = | 0 Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortParameterLib.h= =3D> Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Library/Usb3Debu= gPortParamLib.h | 0 {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibInternal.h = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Include/Library/IpmiCommandLib.h = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Include/Library/IpmiPlatformHookLib.h = | 0 {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/SmbiosBasic.h = | 4 +- {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Include/Guid/UserAuthentication.h = | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Include/Library/PlatformPasswordLib.h = | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Include/Library/UserPasswordLib.h = | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Include/Library/UserPasswordUiLib.h = | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/KeyService.= h | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= ication2Dxe.h | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxe.h | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxeFormset.h | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationSmm.h | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxeVfr.vfr | 0 Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildW= orkaround.c = | 31 +++ {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debugging/Ac= piDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebug.c = | 54 +++-- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/MiscServices.c = | 0 {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortDataTransfer.c = | 2 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortInitialize.c = | 2 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.c = | 4 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIoMmu.c = | 4 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.c = | 0 {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.c = | 2 +- {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3DebugFea= turePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIoMmu.c = | 2 +- Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd/Usb3De= bugPortParameterLibPcd.c =3D> Features/Intel/Debugging/Usb3DebugFeaturePkg/= Library/Usb3DebugPortParamLibPcd/Usb3DebugPortParamLibPcd.c | 2 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcAcpi/BmcAcpi.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcElog/BmcElog.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Frb/FrbDxe.c = | 2 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Frb/FrbPei.c = | 4 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiFru/IpmiFru.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiInit/DxeIpmiInit.c = | 8 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/IpmiInit/PeiIpmiInit.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c= | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNu= ll.c | 0 {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/OsWdt/OsWdt.c = | 2 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/SolStatus/SolStatus.c = | 6 +- {Platform/Intel/AdvancedFeaturePkg/S3 =3D> Features/Intel/PowerManagement/= S3FeaturePkg/S3Pei}/S3Pei.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/SmbiosBasicEntryPoint.c = | 8 +- {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type0BiosVendorFunction.c = | 2 +- {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type1SystemManufacturerFunction.c = | 2 +- {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type2BaseBoardManufacturerFunction.c= | 0 {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type32BootInformationFunction.c = | 0 {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/SystemInform= ation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type3ChassisManufacturerFunction.c = | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPasswordLibNull= .c | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/UserPasswordLib/UserPasswordLib.c = | 0 {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/UserPasswordUiLib/UserPasswordUiLib.c = | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/KeyService.= c | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= ication2Dxe.c | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxe.c | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxePassword.c | 0 {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationSmm.c | 0 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibNull/IpmiLibNull.c = = | 45 ---- Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepor= tFvLib.c = | 38 +++- {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debugging/Ac= piDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebug.asl = | 3 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md = = | 121 ++++++++++ Features/Intel/Debugging/Readme.md = = | 7 + Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = = | 86 ++++++++ Features/Intel/Network/NetworkFeaturePkg/Readme.md = = | 89 ++++++++ Features/Intel/Network/Readme.md = = | 5 + {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcAcpi/BmcSsdt/BmcSsdt.asl = | 8 +- {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBandManag= ement/IpmiFeaturePkg}/BmcAcpi/BmcSsdt/IpmiOprRegions.asi = | 10 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md = = | 86 ++++++++ Features/Intel/OutOfBandManagement/Readme.md = = | 8 + Features/Intel/PowerManagement/Readme.md = = | 10 + Features/Intel/PowerManagement/S3FeaturePkg/Readme.md = = | 86 ++++++++ Features/Intel/Readme.md = = | 232 +++++++++++= +++++++++ Features/Intel/SystemInformation/Readme.md = = | 8 + Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md = = | 86 ++++++++ Features/Intel/TemplateFeaturePkg/Readme.md = = | 71 ++++++ Features/Intel/UserInterface/Readme.md = = | 9 + {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInterface/= UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPasswordLibNull= .uni | 0 Features/Intel/UserInterface/UserAuthFeaturePkg/Readme.md = = | 86 ++++++++ {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Features/I= ntel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/UserAuthent= icationDxeStrings.uni | 0 Maintainers.txt = = | 26 +-- Platform/Intel/DebugFeaturePkg/AcpiDebug/Readme.txt = = | 31 --- Platform/Intel/Readme.md = = | 14 +- Platform/Intel/build.cfg = = | 1 + Platform/Intel/build_bios.py = = | 3 + 188 files changed, 3854 insertions(+), 1285 deletions(-) create mode 100644 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.de= c create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugF= eaturePkg.dec create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugF= eaturePkg.dec create mode 100644 Features/Intel/Network/NetworkFeaturePkg/NetworkFeature= Pkg.dec create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiF= eaturePkg.dec create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePk= g.dec create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Smbio= sFeaturePkg.dec create mode 100644 Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.de= c rename Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec = =3D> Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec= (53%) delete mode 100644 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.de= c delete mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dec create mode 100644 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.ds= c create mode 100644 Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatu= res.dsc create mode 100644 Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaro= und/TemporaryBuildWorkaround.dsc create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugF= eaturePkg.dsc create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/Ac= piDebugFeature.dsc create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Us= b3DebugFeature.dsc create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugF= eaturePkg.dsc create mode 100644 Features/Intel/Network/NetworkFeaturePkg/Include/Networ= kFeature.dsc create mode 100644 Features/Intel/Network/NetworkFeaturePkg/NetworkFeature= Pkg.dsc create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/IpmiFeature.dsc create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiF= eaturePkg.dsc create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/Include/S3F= eature.dsc create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePk= g.dsc create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Inclu= de/SmbiosFeature.dsc create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Smbio= sFeaturePkg.dsc create mode 100644 Features/Intel/TemplateFeaturePkg/Include/TemplateFeatu= re.dsc create mode 100644 Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.ds= c create mode 100644 Features/Intel/UserInterface/UserAuthFeaturePkg/Include= /UserAuthFeature.dsc create mode 100644 Features/Intel/UserInterface/UserAuthFeaturePkg/UserAut= hFeaturePkg.dsc delete mode 100644 Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.ds= c delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvan= cedDxeInclude.dsc delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvan= cedPeiInclude.dsc delete mode 100644 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc delete mode 100644 Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFea= turePkg.dsc create mode 100644 Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fd= f create mode 100644 Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Network/NetworkFeaturePkg/Include/PostMe= mory.fdf create mode 100644 Features/Intel/Network/NetworkFeaturePkg/Include/PreMem= ory.fdf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Inclu= de/PreMemory.fdf create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/Include/Pos= tMemory.fdf create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/Include/Pre= Memory.fdf create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Inclu= de/PreMemory.fdf create mode 100644 Features/Intel/TemplateFeaturePkg/Include/PostMemory.fd= f create mode 100644 Features/Intel/TemplateFeaturePkg/Include/PreMemory.fdf create mode 100644 Features/Intel/UserInterface/UserAuthFeaturePkg/Include= /PostMemory.fdf create mode 100644 Features/Intel/UserInterface/UserAuthFeaturePkg/Include= /PreMemory.fdf delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvan= cedLateInclude.fdf delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvan= cedPostMemoryInclude.fdf delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvan= cedPreMemoryInclude.fdf create mode 100644 Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaro= und/TemporaryBuildWorkaround.inf rename {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debug= ging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebugDxe.inf (77%) rename {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debug= ging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebugSmm.inf (74%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.inf (74%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIoMmu.inf (78%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.inf (92%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.inf (74%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIoMmu.inf (76%) create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Library/Us= b3DebugPortParamLibPcd/Usb3DebugPortParamLibPcd.inf rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcAcpi/BmcAcpi.inf (78%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcElog/BmcElog.inf (78%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Frb/FrbDxe.inf (77%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Frb/FrbPei.inf (64%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiFru/IpmiFru.inf (78%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiInit/DxeIpmiInit.inf (79%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiInit/PeiIpmiInit.inf (78%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLib.inf (80%= ) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiPlatformHookLibNull/IpmiPlatformHo= okLibNull.inf (74%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/OsWdt/OsWdt.inf (79%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/SolStatus/SolStatus.inf (66%) rename {Platform/Intel/AdvancedFeaturePkg/S3 =3D> Features/Intel/PowerMana= gement/S3FeaturePkg/S3Pei}/S3Pei.inf (52%) create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Smbio= sBasicDxe/SmbiosBasicDxe.inf rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPassword= LibNull.inf (88%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/UserPasswordLib/UserPasswordLib.inf (91%= ) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/UserPasswordUiLib/UserPasswordUiLib.inf = (91%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= Authentication2Dxe.inf (92%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxe.inf (93%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationSmm.inf (92%) delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibN= ull/IpmiLibNull.inf delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe= /SmbiosBasicDxe.inf delete mode 100644 Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortPar= ameterLibPcd/Usb3DebugPortParameterLibPcd.inf rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Include/Library/Usb3DebugPortLib.h (100%) rename Platform/Intel/DebugFeaturePkg/Include/Library/Usb3DebugPortParamet= erLib.h =3D> Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Library/U= sb3DebugPortParamLib.h (100%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibInternal.h (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Include/Library/IpmiCommandLib.h (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Include/Library/IpmiPlatformHookLib.h (100%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/SmbiosBasic.h (90%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Include/Guid/UserAuthentication.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Include/Library/PlatformPasswordLib.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Include/Library/UserPasswordLib.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Include/Library/UserPasswordUiLib.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/KeyS= ervice.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= Authentication2Dxe.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxe.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxeFormset.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationSmm.h (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxeVfr.vfr (100%) create mode 100644 Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaro= und/TemporaryBuildWorkaround.c rename {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debug= ging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebug.c (90%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/MiscServices.c (100%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortDataTransfer.c (96%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortInitialize.c (96%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxe.c (95%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibDxeIoMmu.c (95%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibNull.c (100%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPei.c (95%) rename {Platform/Intel/DebugFeaturePkg =3D> Features/Intel/Debugging/Usb3D= ebugFeaturePkg}/Library/Usb3DebugPortLib/Usb3DebugPortLibPeiIoMmu.c (95%) rename Platform/Intel/DebugFeaturePkg/Library/Usb3DebugPortParameterLibPcd= /Usb3DebugPortParameterLibPcd.c =3D> Features/Intel/Debugging/Usb3DebugFeat= urePkg/Library/Usb3DebugPortParamLibPcd/Usb3DebugPortParamLibPcd.c (92%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcAcpi/BmcAcpi.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcElog/BmcElog.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Frb/FrbDxe.c (95%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Frb/FrbPei.c (94%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiFru/IpmiFru.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiInit/DxeIpmiInit.c (93%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/IpmiInit/PeiIpmiInit.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.= c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnChas= sis.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnStor= age.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiCommandLib/IpmiCommandLibNetFnTran= sport.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/Library/IpmiPlatformHookLibNull/IpmiPlatformHo= okLibNull.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/OsWdt/OsWdt.c (94%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/SolStatus/SolStatus.c (94%) rename {Platform/Intel/AdvancedFeaturePkg/S3 =3D> Features/Intel/PowerMana= gement/S3FeaturePkg/S3Pei}/S3Pei.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/SmbiosBasicEntryPoint.c (89%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type0BiosVendorFunction.c (95= %) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type1SystemManufacturerFuncti= on.c (96%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type2BaseBoardManufacturerFun= ction.c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type32BootInformationFunction= .c (100%) rename {Platform/Intel/AdvancedFeaturePkg/Smbios =3D> Features/Intel/Syste= mInformation/SmbiosFeaturePkg}/SmbiosBasicDxe/Type3ChassisManufacturerFunct= ion.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPassword= LibNull.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/UserPasswordLib/UserPasswordLib.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/UserPasswordUiLib/UserPasswordUiLib.c (1= 00%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/KeyS= ervice.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= Authentication2Dxe.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxe.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxePassword.c (100%) rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationSmm.c (100%) delete mode 100644 Platform/Intel/AdvancedFeaturePkg/Ipmi/Library/IpmiLibN= ull/IpmiLibNull.c rename {Platform/Intel/DebugFeaturePkg/AcpiDebug =3D> Features/Intel/Debug= ging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm}/AcpiDebug.asl (95%) create mode 100644 Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md create mode 100644 Features/Intel/Debugging/Readme.md create mode 100644 Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md create mode 100644 Features/Intel/Network/NetworkFeaturePkg/Readme.md create mode 100644 Features/Intel/Network/Readme.md rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcAcpi/BmcSsdt/BmcSsdt.asl (87%) rename {Platform/Intel/AdvancedFeaturePkg/Ipmi =3D> Features/Intel/OutOfBa= ndManagement/IpmiFeaturePkg}/BmcAcpi/BmcSsdt/IpmiOprRegions.asi (91%) create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readm= e.md create mode 100644 Features/Intel/OutOfBandManagement/Readme.md create mode 100644 Features/Intel/PowerManagement/Readme.md create mode 100644 Features/Intel/PowerManagement/S3FeaturePkg/Readme.md create mode 100644 Features/Intel/Readme.md create mode 100644 Features/Intel/SystemInformation/Readme.md create mode 100644 Features/Intel/SystemInformation/SmbiosFeaturePkg/Readm= e.md create mode 100644 Features/Intel/TemplateFeaturePkg/Readme.md create mode 100644 Features/Intel/UserInterface/Readme.md rename {Platform/Intel/UserInterfaceFeaturePkg =3D> Features/Intel/UserInt= erface/UserAuthFeaturePkg}/Library/PlatformPasswordLibNull/PlatformPassword= LibNull.uni (100%) create mode 100644 Features/Intel/UserInterface/UserAuthFeaturePkg/Readme.= md rename {Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication =3D> Fea= tures/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm}/User= AuthenticationDxeStrings.uni (100%) delete mode 100644 Platform/Intel/DebugFeaturePkg/AcpiDebug/Readme.txt --=20 2.16.2.windows.1