From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.615.1573861657256740880 for ; Fri, 15 Nov 2019 15:47:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:47:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="208281863" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 15 Nov 2019 15:47:22 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX108.amr.corp.intel.com ([169.254.2.82]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:47:22 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Bi, Dandan" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 03/49] UserInterfaceFeaturePkg: Package DSC style cleanup Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 03/49] UserInterfaceFeaturePkg: Package DSC style cleanup Thread-Index: AQHVmdJzPC3V4gOSwEukEg7lKdZS16eMqswg Date: Fri, 15 Nov 2019 23:47:22 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB083@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-4-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-4-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFiMThkYWEtN2VhMy00YzZhLThmZTEtNDE1M2E4MDE4Y2U3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWUtUSDNQU01UZTVNaDhwTjJEekZYWXN1OERIY1pMZXhwbmNhdW9WNzhnQlJrNlRaSktiMjluK3hERFVDZVFqQiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:27 PM To: devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 03/49] UserInterfaceFeatur= ePkg: Package DSC style cleanup This change refactors UserInterfaceFeaturePkg.dsc to consolidate redundant= sections and better group file content to improve maintainability and read= ability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc | 45 += +++++++++++++------ 1 file changed, 33 insertions(+), 12 deletions(-) diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePk= g.dsc b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc index 6c5f77b59b..bd09052f3c 100644 --- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc +++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc @@ -1,5 +1,6 @@ ## @file # This package provides UI related modules. +# This package should only depend on EDKII Core packages and MinPlatformP= kg. # # The DEC files are used by the utilities that parse DSC and # INF files= to generate AutoGen.c and AutoGen.h files @@ -22,32 +23,45 @@ SKUID_IDENTIFIER =3D DEFAULT =20 [LibraryClasses] - UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntr= yPoint.inf + ####################################### + # Edk2 Packages + ####################################### BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf - UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo= otServicesTableLib.inf - UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/= UefiRuntimeServicesTableLib.inf - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf - UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServi= cesLib.inf - HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf - TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTempla= te.inf - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf + DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf + HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf + IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf + PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf + PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf + + TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTempl + ate.inf + UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiB + ootServicesTableLib.inf + UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEnt + ryPoint.inf + UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServ + icesLib.inf UefiLib|MdePkg/Library/UefiLib/UefiLib.inf + + UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib + /UefiRuntimeServicesTableLib.inf + + ##################################### + # User Interface Feature Package + ##################################### PlatformPasswordLib|UserInterfaceFeaturePkg/Library/PlatformPasswordLib= Null/PlatformPasswordLibNull.inf UserPasswordLib|UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPas= swordLib.inf =20 [LibraryClasses.common.DXE_DRIVER] + ####################################### + # Edk2 Packages + ####################################### MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAl= locationLib.inf =20 [LibraryClasses.common.DXE_SMM_DRIVER] + ####################################### + # Edk2 Packages + ####################################### + BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMemoryAllo= cationLib.inf SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesTable= Lib.inf - BaseCryptLib|CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf =20 #########################################################################= ########################## # @@ -68,10 +82,17 @@ # #########################################################################= ########################## [Components] + ##################################### + # User Interface Feature Package + ##################################### + + # Add library instances here that are not included in package=20 + components and should be tested # in the package build. UserInterfaceFeaturePkg/Library/PlatformPasswordLibNull/PlatformPasswor= dLibNull.inf UserInterfaceFeaturePkg/Library/UserPasswordLib/UserPasswordLib.inf UserInterfaceFeaturePkg/Library/UserPasswordUiLib/UserPasswordUiLib.inf =20 + # Add components here that should be included in the package build. UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationDxe.inf UserInterfaceFeaturePkg/UserAuthentication/UserAuthentication2Dxe.inf UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf -- 2.16.2.windows.1