From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.607.1573861687486016862 for ; Fri, 15 Nov 2019 15:48:07 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:48:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="214871374" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga001.fm.intel.com with ESMTP; 15 Nov 2019 15:48:07 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX109.amr.corp.intel.com ([169.254.11.161]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:48:06 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Wei, David Y" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 12/49] SimicsOpenBoardPkg: Remove advanced feature references Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 12/49] SimicsOpenBoardPkg: Remove advanced feature references Thread-Index: AQHVmdKKvvshJrnpP02chZhT//sHcqeMqvoA Date: Fri, 15 Nov 2019 23:48:06 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB14D@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-13-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-13-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDczNjk4MWMtNjUwNy00YmQ3LTk3NmUtMGMxOWJmZDQxOWM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSXZnV25HZXpoTUg4blVRZUxWeEZZeTIzQ1V5Yzg1TlV3Z2pWQXZFWGFGNHczY0g2UVl1MCtQVVdPa0haNHFEZiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms][PATCH V1 12/49] SimicsOpenBoardPkg:= Remove advanced feature references Removes references to advanced features in the package to prepare for an a= dvanced feature refactor that will impact the location of features and deta= ils such as package names and PCD token space identifiers. Cc: Wei David Y Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = | 17 ----------------- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc = | 6 ------ Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = | 8 -------- Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf= | 1 - 4 files changed, 32 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.= dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index 35a8c7c765..761874de73 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -34,16 +34,7 @@ =20 DEFINE SMM_REQUIRE =3D TRUE =20 - # - # PLATFORMX64_ENABLE is set to TRUE when PEI is IA32 and DXE is X64 pla= tform - # - DEFINE PLATFORMX64_ENABLE =3D TRUE - DEFINE NETWORK_TLS_ENABLE =3D FALSE - DEFINE NETWORK_ISCSI_ENABLE =3D FALSE - DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE - !include $(PROJECT)/OpenBoardPkgPcd.dsc - !include NetworkPkg/NetworkDefines.dsc.inc =20 #########################################################################= ####### # @@ -76,7 +67,6 @@ =20 [Components.X64] !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc -!include AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc =20 ####################################### # Build Option Includes @@ -271,13 +261,6 @@ $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf !endif =20 - ####################################### - # Advanced Feature Package - ####################################### -!if gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable =3D=3D TRUE - AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf -!endif - ####################################### # Board Package ####################################### diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgP= cd.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds= c index cd95755f91..1383a63d36 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds +++ c @@ -96,8 +96,6 @@ ###################################### # Advanced Feature Configuration ###################################### - gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable|TRUE - gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable|TRUE =20 [PcdsFeatureFlag.X64] ###################################### @@ -252,10 +250,6 @@ ###################################### # Advanced Feature Configuration ###################################### - gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosReleaseDate|"= 2019-08-09" - gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosVersion|"Ver.= 1.0.0" - gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType1StringProductName|"QSP = UEFI BIOS" - gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosType2StringProductName|"QSP = UEFI BIOS" =20 [PcdsDynamicExDefault] ###################################### diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.= fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index ef6b35c92f..d29835f606 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -155,7 +155,6 @@ INF MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.= inf INF MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf INF MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.= inf !include MinPlatformPkg/Include/Fdf/CoreSecurityPreMemoryInclude.fdf -!include AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPreMemoryInclude.fdf INF $(BOARD_PKG)/SimicsPei/SimicsPei.inf !include $(SKT_PKG)/SktPostMemoryInclude.fdf !include $(PCH_PKG)/IchPostMemoryInclude.fdf @@ -163,7 +162,6 @@ INF $(BOARD_PKG)/SimicsPei/SimicsPei.inf INF MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPostMem.inf INF MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPostMem= .inf !include MinPlatformPkg/Include/Fdf/CoreSecurityPostMemoryInclude.fdf -!include AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPostMemoryInclude.fdf =20 INF UefiCpuPkg/Universal/Acpi/S3Resume2Pei/S3Resume2Pei.inf INF $(SKT_PKG)/Smm/Access/SmmAccessPei.inf @@ -238,12 +236,6 @@ INF ShellPkg/Application/Shell/Shell.inf # INF SimicsIch10BinPkg/UndiBinary/UndiDxe.inf =20 -!include AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf - -!if gAdvancedFeaturePkgTokenSpaceGuid.PcdSmbiosEnable =3D=3D TRUE - INF AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf -!endif - !include MinPlatformPkg/Include/Fdf/CoreSecurityLateInclude.fdf =20 [FV.FVMAIN_COMPACT] diff --git a/Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPla= tformDxe.inf b/Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPl= atformDxe.inf index 3cc6a03564..f8ecab08e6 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDx= e.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatform +++ Dxe.inf @@ -31,7 +31,6 @@ MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec SimicsOpenBoardPkg/OpenBoardPkg.dec - AdvancedFeaturePkg/AdvancedFeaturePkg.dec BoardModulePkg/BoardModulePkg.dec =20 [LibraryClasses] -- 2.16.2.windows.1