From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.630.1573861691717060591 for ; Fri, 15 Nov 2019 15:48:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:48:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="257897472" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by FMSMGA003.fm.intel.com with ESMTP; 15 Nov 2019 15:48:11 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 15:48:11 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX157.amr.corp.intel.com ([169.254.9.64]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:48:10 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 13/49] AdvancedFeaturePkg: Remove the S3 feature Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 13/49] AdvancedFeaturePkg: Remove the S3 feature Thread-Index: AQHVmdKHEf/iuLHrb0etXVOrA6piY6eMqvbQ Date: Fri, 15 Nov 2019 23:48:10 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB164@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-14-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-14-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY2ODZkM2YtZjhjZS00ZjY0LWE1NmYtOTIwMWQ4OWFjZWNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWh6cXBNWHF4MldxeGxwSmRSc2k3WFwvcGppaEc3YnVuTW9VbTZ0aWlIaEIwa0lGbmZmOHFCblwvZVVTMHVkQU90In0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 13/49] AdvancedFeaturePkg:= Remove the S3 feature Removes the S3 feature from AdvancedFeaturePkg. The feature does not follo= w the advanced feature design. A future change will add the feature back fo= llowing the advanced feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 6 ---- Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf | 31 -----------= ------ Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c | 36 -----------= --------- 3 files changed, 73 deletions(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Pl= atform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index b83e72b48c..885b84e2df 100644 --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -102,11 +102,6 @@ MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllo= cationLib.inf PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf =20 - ####################################### - # Silicon Initialization Package - ####################################### - SmmAccessLib|IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/= PeiSmmAccessLib.inf - [LibraryClasses.common.DXE_CORE,LibraryClasses.common.DXE_SMM_DRIVER,Libr= aryClasses.common.SMM_CORE,LibraryClasses.common.DXE_DRIVER,LibraryClasses.= common.DXE_RUNTIME_DRIVER,LibraryClasses.common.UEFI_DRIVER,LibraryClasses.= common.UEFI_APPLICATION] ####################################### # Edk2 Packages @@ -158,7 +153,6 @@ AdvancedFeaturePkg/Ipmi/IpmiInit/PeiIpmiInit.inf AdvancedFeaturePkg/Ipmi/OsWdt/OsWdt.inf AdvancedFeaturePkg/Ipmi/SolStatus/SolStatus.inf - AdvancedFeaturePkg/S3/S3Pei.inf AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf =20 [BuildOptions] diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf b/Platform/Int= el/AdvancedFeaturePkg/S3/S3Pei.inf deleted file mode 100644 index 847edd20c0..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf +++ /dev/null @@ -1,31 +0,0 @@ -### @file -# Component information file for the S3 PEI module. -# -# Copyright (c) 2019, Intel Corporation. All rights reserved.
-# -# S= PDX-License-Identifier: BSD-2-Clause-Patent -# -### - -[Defines] - INF_VERSION =3D 0x00010017 - BASE_NAME =3D S3Pei - FILE_GUID =3D 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9 - VERSION_STRING =3D 1.0 - MODULE_TYPE =3D PEIM - ENTRY_POINT =3D S3PeiEntryPoint - -[LibraryClasses] - PeimEntryPoint - PeiServicesLib - SmmAccessLib - -[Packages] - MdePkg/MdePkg.dec - IntelSiliconPkg/IntelSiliconPkg.dec - -[Sources] - S3Pei.c - -[Depex] - gEfiPeiMemoryDiscoveredPpiGuid diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c b/Platform/Intel= /AdvancedFeaturePkg/S3/S3Pei.c deleted file mode 100644 index b0aaa04962..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c +++ /dev/null @@ -1,36 +0,0 @@ -/** @file - Source code file for S3 PEI module - -Copyright (c) 2019, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#include -#include - -/** - S3 PEI module entry point - - @param[in] FileHandle Not used. - @param[in] PeiServices General purpose services available to = every PEIM. - - @retval EFI_SUCCESS The function completes successfully - @retval EFI_OUT_OF_RESOURCES Insufficient resources to create datab= ase -**/ -EFI_STATUS -EFIAPI -S3PeiEntryPoint ( - IN EFI_PEI_FILE_HANDLE FileHandle, - IN CONST EFI_PEI_SERVICES **PeiServices - ) -{ - EFI_STATUS Status; - - // - // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case - // - Status =3D PeiInstallSmmAccessPpi (); - - return Status; -} -- 2.16.2.windows.1