From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.664.1573861828895986558 for ; Fri, 15 Nov 2019 15:50:28 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:50:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="214871628" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga001.fm.intel.com with ESMTP; 15 Nov 2019 15:50:28 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX109.amr.corp.intel.com ([169.254.11.161]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:50:27 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 29/49] AdvancedFeaturePkg: Remove remaining contents Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 29/49] AdvancedFeaturePkg: Remove remaining contents Thread-Index: AQHVmdKp3Vq6X4TU702vax3EYEhWsKeMq0Fg Date: Fri, 15 Nov 2019 23:50:27 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB2E5@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-30-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-30-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTMzNzE2MTUtZjA4Zi00Zjk0LWJlMmYtMTRjMTFkZjY2NzA4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTTBtaWZHdHNrSlFvTHp0WmNHdlBGZmhhU21LaXZaaWJaY09yOWlvTUtVRnArVkNPaG41UG9kRHM0MlR2b3lXTiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 29/49] AdvancedFeaturePkg:= Remove remaining contents This change removes the remaining files in AdvancedFeaturePkg that are no = longer part of the Minimum Platform Advanced Feature design. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec = | 4 -- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 56 -------------------- Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc = | 15 ------ Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedPeiInclude.dsc = | 9 ---- Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude.fdf= | 14 ----- Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPostMemoryInclu= de.fdf | 8 --- Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvanced= PreMemoryInclude.fdf | 9 ---- 7 files changed, 115 deletions(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec b/Pl= atform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec index 6cd333d498..7342539198 100644 --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec @@ -11,15 +11,12 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent # ## - - [Defines] DEC_SPECIFICATION =3D 0x00010017 PACKAGE_NAME =3D AdvancedFeaturePkg PACKAGE_VERSION =3D 0.1 PACKAGE_GUID =3D 290127D9-ABED-4DD8-A35D-73DCB4261BCB =20 - [Includes] Include =20 @@ -27,4 +24,3 @@ Include gAdvancedFeaturePkgTokenSpaceGuid =3D {0xa8514688, 0x6693, 0x4ab= 5, {0xaa, 0xc8, 0xcc, 0xa9, 0x8d, 0xde, 0x90, 0xe1}} =20 [PcdsFeatureFlag] - gAdvancedFeaturePkgTokenSpaceGuid.PcdNetworkEnable |FALSE|BOOL= EAN|0xF00000A1 diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Pl= atform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 4b8ccf3375..38298e15e4 100644 --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -21,59 +21,3 @@ SUPPORTED_ARCHITECTURES =3D IA32|X64 BUILD_TARGETS =3D DEBUG|RELEASE SKUID_IDENTIFIER =3D DEFAULT - -#########################################################################= ####### -# -# SKU Identification section - list of all SKU IDs supported. -# -#########################################################################= ####### -[SkuIds] - 0|DEFAULT # The entry: 0|DEFAULT is reserved and always re= quired. - -#########################################################################= ####### -# -# Pcd Section - list of all EDK II PCD Entries defined by this package. -# -#########################################################################= ####### - -[PcdsFeatureFlag] - -#########################################################################= ####### -# -# Library Class section - list of all Library Classes needed by this pack= age. -# -#########################################################################= ####### - -[LibraryClasses.common] - -#########################################################################= ########################## -# -# Components Section - list of the modules and components that will be pr= ocessed by compilation -# tools and the EDK II tools to generate PE32/PE32+/= Coff image files. -# -# Note: The EDK II DSC file is not used to specify how compiled binary im= ages get placed -# into firmware volume images. This section is just a list of modul= es to compile from -# source into UEFI-compliant binaries. -# It is the FDF file that contains information on combining binary = files into firmware -# volume images, whose concept is beyond UEFI and is described in P= I specification. -# Binary modules do not need to be listed in this section, as they = should be -# specified in the FDF file. For example: Shell binary (Shell_Full.= efi), FAT binary (Fat.efi), -# Logo (Logo.bmp), and etc. -# There may also be modules listed in this section that are not req= uired in the FDF file, -# When a module listed here is excluded from FDF file, then UEFI-co= mpliant binary will be -# generated for it, but the binary will not be put into any firmwar= e volume. -# -#########################################################################= ########################## - -[Components] - ####################################### - # Advanced Feature Package - ####################################### - - # Add library instances here that are not included in package component= s and should be tested - # in the package build. - - # Add components here that should be included in the package build. - -[BuildOptions] - *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES diff --git a/Pl= atform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc b/Pl= atform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude.dsc deleted file mode 100644 index b74c0ef2bc..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude= .dsc +++ /dev/null @@ -1,15 +0,0 @@ -## @file -# Platform description. -# -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
= -# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -## - - - # - # UEFI network modules - # - !include NetworkPkg/NetworkComponents.dsc.inc - diff --git a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedPei= Include.dsc b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedPei= Include.dsc deleted file mode 100644 index 86b1ebfed0..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedPeiInclude= .dsc +++ /dev/null @@ -1,9 +0,0 @@ -## @file -# Platform description. -# -# Copyright (c) 2017, Intel Corporation. All rights reserved.
-# -# S= PDX-License-Identifier: BSD-2-Clause-Patent -# -## - diff --git a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLat= eInclude.fdf b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLa= teInclude.fdf deleted file mode 100644 index a86ecdc9d1..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud= e.fdf +++ /dev/null @@ -1,14 +0,0 @@ -## @file -# FDF file of Platform. -# -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.
= -# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -## - - -# -# UEFI network modules -# -!include NetworkPkg/Network.fdf.inc diff --git a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPos= tMemoryInclude.fdf b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdva= ncedPostMemoryInclude.fdf deleted file mode 100644 index 3c2716d672..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPostMemory= Include.fdf +++ /dev/null @@ -1,8 +0,0 @@ -## @file -# FDF file of Platform. -# -# Copyright (c) 2017, Intel Corporation. All rights reserved.
-# -# S= PDX-License-Identifier: BSD-2-Clause-Patent -# -## diff --git a/Platform/In= tel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPreMemoryInclude.fdf b/Platf= orm/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPreMemoryInclude.fdf deleted file mode 100644 index 5b21f781a7..0000000000 --- a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedPreMemoryI= nclude.fdf +++ /dev/null @@ -1,9 +0,0 @@ -## @file -# FDF file of Platform. -# -# Copyright (c) 2017, Intel Corporation. All rights reserved.
-# -# S= PDX-License-Identifier: BSD-2-Clause-Patent -# -## - -- 2.16.2.windows.1