From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.657.1573861844111071496 for ; Fri, 15 Nov 2019 15:50:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:50:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="208282595" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 15 Nov 2019 15:50:43 -0800 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 15:50:43 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX111.amr.corp.intel.com ([169.254.12.253]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:50:43 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 31/49] AdvancedFeaturePkg: Add feature build support Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 31/49] AdvancedFeaturePkg: Add feature build support Thread-Index: AQHVmdKryYIAJGzickS2/KgUBY2gBaeMq07A Date: Fri, 15 Nov 2019 23:50:42 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB326@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-32-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-32-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjhmYTg5YjgtNWU2Yy00ZDJhLTlmZmQtMjI3OTAzNzQ5MzU3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid2NGbkttd3haNldsT0pvdXJPRzdWOEFkNVVKejNlRTVCcmVSbzhMdCtWdlQrWU96WGlHWWlmRnhRNjhTdjlOWiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 31/49] AdvancedFeaturePkg:= Add feature build support This change adds the ability to build all currently available advanced fea= tures using the AdvancedFeaturePkg build. To build all advanced features, f= ollow the instructions in the Feature/Intel/Readme.md file. The actual buil= d is performed by executing the following command in the Features/Intel dir= ectory: "build -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc -a IA32 -a X64" Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 9 +++- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 28 +++++= +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc | 56 +++++= +++++++++++++++ 3 files changed, 91 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec b/Fe= atures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec index 7342539198..36c72b98e1 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec @@ -1,6 +1,11 @@ ## @file -# This package provides the modules that build for a full feature platfor= m. -# This AdvancedFeaturePkg should only depend on EDKII Core packages and M= inPlatformPkg. +# Advanced Feature Package build declaration file. +# +# Advanced features allow a board package to be extended with advanced fu= nctionality. +# +# This package should not contain any specific advanced features. The pac= kage has two responsibilities: +# 1. Present a consolidated and simplified view of all available advanced= features to board packages. +# 2. Provide a simple, single package build for all available advanced fe= atures. # # The DEC files are used by the utilities that parse DSC and # INF files= to generate AutoGen.c and AutoGen.h files diff --git a/Features/Intel/Adva= ncedFeaturePkg/AdvancedFeaturePkg.dsc b/Features/Intel/AdvancedFeaturePkg/A= dvancedFeaturePkg.dsc index 38298e15e4..50c0e81048 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -1,6 +1,12 @@ ## @file # Advanced Feature Package build description file. # +# Advanced features allow a board package to be extended with advanced fu= nctionality. +# +# This package should not contain any specific advanced features. The pac= kage has two responsibilities: +# 1. Present a consolidated and simplified view of all available advanced= features to board packages. +# 2. Provide a simple, single package build for all available advanced fe= atures. +# # Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
= # # SPDX-License-Identifier: BSD-2-Clause-Patent @@ -21,3 +27,25 @@ SUPPORTED_ARCHITECTURES =3D IA32|X64 BUILD_TARGETS =3D DEBUG|RELEASE SKUID_IDENTIFIER =3D DEFAULT + PEI_ARCH =3D IA32 + DXE_ARCH =3D X64 + +####################################################################### +######### +# +# Advanced Feature Enable section - all advanced features are enabling fo= r the +# AdvancedFeaturePkg build. +# +####################################################################### +######### +[PcdsFeatureFlag] + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |TRUE + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |TRUE + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |TRUE + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |TRUE + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |TRUE + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |TRUE + gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |TRUE + +# +# This package builds all advanced features. +# +!include Include/AdvancedFeatures.dsc diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.ds= c b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc new file mode 100644 index 0000000000..649774edf7 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc @@ -0,0 +1,56 @@ +## @file +# DSC file for advanced features. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally built by enabling the respectiv= e feature via its FeaturePCD. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +# +# Debug Advanced Features +# +!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc +!endif +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc +!endif + +# +# Network Advanced Features +# +!if gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable =3D=3D TRUE + !include Network/NetworkFeaturePkg/Include/NetworkFeature.dsc +!endif + +# +# Out-of-Band Management Advanced Features # !if=20 +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable =3D=3D TRUE + !include OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +!endif + +# +# Power Management Advanced Features +# +!if gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable =3D=3D TRUE + !include PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +!endif + +# +# System Information Advanced Features +# +!if gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable =3D=3D TRUE + !include SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc +!endif + +# +# User Interface Advanced Features +# +!if=20 +gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable =3D= =3D=20 +TRUE + !include UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc +!endif -- 2.16.2.windows.1