From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.676.1573861875822063732 for ; Fri, 15 Nov 2019 15:51:15 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:50:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="195543353" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2019 15:50:58 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX101.amr.corp.intel.com ([169.254.8.229]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:50:58 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 33/49] AdvancedFeaturePkg: Add FDF include files Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 33/49] AdvancedFeaturePkg: Add FDF include files Thread-Index: AQHVmdKtZatEC4n3k0eKdtvOeRfUXqeMq1fw Date: Fri, 15 Nov 2019 23:50:57 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB359@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-34-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-34-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTE2YTlmZDctYTU0MS00NTJlLWFjMjgtYzM3ZGZhMjgwYTNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicFhIenp1SnBVY1dDK0hJQnY5UlpsTTh4UVZrajVLZGUwMXordEd2TWRoOW1jMVwvWjVxUzViSHBqM29XQzBkWUUifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V1 33/49] AdvancedFeaturePkg:= Add FDF include files Adds FDF files that group all currently available advanced features so the= y can be conveniently included into board packages. The Minimum Platform defines two firmware volumes for advanced features: FvAdvancedPreMemory and FvAdvanced. This change provides all pre-memory advanced feature modules to be include= d in FvAdvancedPreMemory via AdvancedFeaturePkg/Include/PreMemory.fdf. All = post-memory advanced feature modules to be included in FvAdvanced are avail= able in AdvancedFeaturePkg/Include/PostMemory.fdf. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf | 57 +++++++++++= +++++++++ Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf | 57 ++= ++++++++++++++++++ 2 files changed, 114 insertions(+) diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf b/Fe= atures/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf new file mode 100644 index 0000000000..57b29a42b9 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf @@ -0,0 +1,57 @@ +## @file +# FDF file for post-memory advanced features. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +# +# Debug Advanced Features +# +!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf +!endif +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/Usb3DebugFeaturePkg/Include/PostMemory.fdf +!endif + +# +# Network Advanced Features +# +!if gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable =3D=3D TRUE + !include Network/NetworkFeaturePkg/Include/PostMemory.fdf +!endif + +# +# Out-of-Band Management Advanced Features # !if=20 +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable =3D=3D TRUE + !include OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf +!endif + +# +# Power Management Advanced Features +# +!if gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable =3D=3D TRUE + !include PowerManagement/S3FeaturePkg/Include/PostMemory.fdf +!endif + +# +# System Information Advanced Features +# +!if gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable =3D=3D TRUE + !include SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf +!endif + +# +# User Interface Advanced Features +# +!if=20 +gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable =3D= =3D=20 +TRUE + !include UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf +!endif diff --git a/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf b/Fea= tures/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf new file mode 100644 index 0000000000..20d25dd173 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf @@ -0,0 +1,57 @@ +## @file +# FDF file for pre-memory advanced features. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +# +# Debug Advanced Features +# +!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/AcpiDebugFeaturePkg/Include/PreMemory.fdf +!endif +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/Usb3DebugFeaturePkg/Include/PreMemory.fdf +!endif + +# +# Network Advanced Features +# +!if gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable =3D=3D TRUE + !include Network/NetworkFeaturePkg/Include/PreMemory.fdf +!endif + +# +# Out-of-Band Management Advanced Features # !if=20 +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable =3D=3D TRUE + !include OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf +!endif + +# +# Power Management Advanced Features +# +!if gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable =3D=3D TRUE + !include PowerManagement/S3FeaturePkg/Include/PreMemory.fdf +!endif + +# +# System Information Advanced Features +# +!if gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable =3D=3D TRUE + !include SystemInformation/SmbiosFeaturePkg/Include/PreMemory.fdf +!endif + +# +# User Interface Advanced Features +# +!if=20 +gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable =3D= =3D=20 +TRUE + !include UserInterface/UserAuthFeaturePkg/Include/PreMemory.fdf +!endif -- 2.16.2.windows.1