From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.673.1573861877379207119 for ; Fri, 15 Nov 2019 15:51:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 15:51:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="195543409" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2019 15:51:15 -0800 Received: from orsmsx154.amr.corp.intel.com (10.22.226.12) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 15:51:15 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX154.amr.corp.intel.com ([169.254.11.36]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 15:51:15 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Wei, David Y" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 37/49] SimicsOpenBoardPkg/BoardX58Ich10: Use PEI_ARCH and DXE_ARCH Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 37/49] SimicsOpenBoardPkg/BoardX58Ich10: Use PEI_ARCH and DXE_ARCH Thread-Index: AQHVmdK5P4H8cIazkku9juDZ2DOrtqeMq3Ww Date: Fri, 15 Nov 2019 23:51:14 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB3A2@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-38-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-38-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTNhNmNjNDQtMDAzNi00MDg0LTk5ODktODQyMzUwZjljY2I2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicGZQaFUrYlZHMEdcLzhCY1NlZnl2dHUwenpjakhGYlMwYllobDVrXC81bVVSSVwvNStkZjd6XC9TdHhkS1dUdGxaMDYifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms][PATCH V1 37/49] SimicsOpenBoardPkg/= BoardX58Ich10: Use PEI_ARCH and DXE_ARCH This change updates OpenBoardPkg.dsc to use the PEI_ARCH and DXE_ARCH spec= ified in the DSC file for the board package components. An EDK II build limitation currently prevents the macros from being able t= o be used, so a todo has been placed with the action needed when the BaseTo= ols update is completed as described in the following Bugzilla item: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2308 The intention of this macro is to ensure that all DSC files that compose t= he package build (such as those included from MinPlatformPkg or an advanced= feature package) build phase-specific drivers for the architecture defined= by the board package. This is a macro that is required in all Minimum Platform board packages. Cc: Wei David Y Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 14 +++= +++++++++++ 1 file changed, 14 insertions(+) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.= dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index 761874de73..c6b2beee4d 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -61,10 +61,14 @@ ####################################### # Component Includes ####################################### +# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugz= illa.tianocore.org/show_bug.cgi?id=3D2308 +# is completed [Components.IA32] !include $(PLATFORM_PACKAGE)/Include/Dsc/CorePeiInclude.dsc !include $(SKT_PKG)/SktPkgPei.dsc =20 +# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugz= illa.tianocore.org/show_bug.cgi?id=3D2308 +# is completed [Components.X64] !include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc =20 @@ -143,6 +147,11 @@ ####################################### SpiFlashCommonLib|$(PCH_PKG)/Library/SmmSpiFlashCommonLib/SmmSpiFlashCo= mmonLib.inf =20 +####################################### +# PEI Components +####################################### +# @todo: Change below line to [Components.$(PEI_ARCH)] after https://bugz= illa.tianocore.org/show_bug.cgi?id=3D2308 +# is completed [Components.IA32] ####################################### # Edk2 Packages @@ -192,6 +201,11 @@ PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf } =20 +####################################### +# DXE Components +####################################### +# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugz= illa.tianocore.org/show_bug.cgi?id=3D2308 +# is completed [Components.X64] ####################################### # Edk2 Packages -- 2.16.2.windows.1