From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.1183.1573864479315041876 for ; Fri, 15 Nov 2019 16:34:39 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 16:34:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="203534148" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga008.fm.intel.com with ESMTP; 15 Nov 2019 16:34:38 -0800 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 16:34:37 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX123.amr.corp.intel.com ([169.254.1.236]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 16:34:37 -0800 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" , "Agyeman, Prince" Subject: Re: [edk2-platforms][PATCH V1 42/49] Platform/Intel: Add advanced feature build support Thread-Topic: [edk2-platforms][PATCH V1 42/49] Platform/Intel: Add advanced feature build support Thread-Index: AQHVmdK8IyoJ7H78P0uMXgDO3IW4p6eMq34g Date: Sat, 16 Nov 2019 00:34:37 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB5FC@ORSMSX114.amr.corp.intel.com> References: <20191113032816.4056-1-michael.a.kubacki@intel.com> <20191113032816.4056-43-michael.a.kubacki@intel.com> In-Reply-To: <20191113032816.4056-43-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzYwZDU3M2MtZDdjNC00Y2ZiLThhMzMtOTUzZjVhNDFlOTMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNWphRVY4VUlnQ1QwZjRaT2hCaWNFQldzNnlsWiszWEpkRjBiVFhTZExoRFwveGVZWlwvbWx4bDBqaFkwNGhyaGYxIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A =20 Sent: Tuesday, November 12, 2019 7:28 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming ; Agyeman, Prince = Subject: [edk2-platforms][PATCH V1 42/49] Platform/Intel: Add advanced feat= ure build support This change adds the ability for board packages built with build_bios.py to= build advanced features located in Features/Intel. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/build.cfg | 1 + Platform/Intel/build_bios.py | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index e42d= b243f6..86a9115021 100644 --- a/Platform/Intel/build.cfg +++ b/Platform/Intel/build.cfg @@ -12,6 +12,7 @@ WORKSPACE_FSP_BIN =3D FSP EDK_TOOLS_BIN =3D edk2-BaseToo= ls-win32 EDK_BASETOOLS =3D BaseTools WORKSPACE_DRIVERS =3D edk2-platforms= /Drivers +WORKSPACE_FEATURES =3D edk2-platforms/Features/Intel WORKSPACE_PLATFORM =3D edk2-platforms/Platform/Intel WORKSPACE_SILICON = =3D edk2-platforms/Silicon/Intel WORKSPACE_PLATFORM_BIN =3D diff --git a/P= latform/Intel/build_bios.py b/Platform/Intel/build_bios.py index ea098de705= ..1ef35aca0a 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -104,6 +104,8 @@ def pre_build(build_config, build_type=3D"DEBUG", silen= t=3DFalse, toolchain=3DNone): config["WORKSPACE_PLATFORM= "]) config["WORKSPACE_SILICON"] =3D os.path.join(config["WORKSPACE"], config["WORKSPACE_SILICON"]= ) + config["WORKSPACE_FEATURES"] =3D os.path.join(config["WORKSPACE"], + =20 + config["WORKSPACE_FEATURES"]) config["WORKSPACE_DRIVERS"] =3D os.path.join(config["WORKSPACE"], config["WORKSPACE_DRIVERS"]= ) config["WORKSPACE_PLATFORM_BIN"] =3D \ @@ -117,6 +119,7 @@ def pre_bui= ld(build_config, build_type=3D"DEBUG", silent=3DFalse, toolchain=3DNone): config["PACKAGES_PATH"] =3D config["WORKSPACE_PLATFORM"] config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON"] config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON_BI= N"] + config["PACKAGES_PATH"] +=3D os.pathsep +=20 + config["WORKSPACE_FEATURES"] config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_DRIVERS"] config["PACKAGES_PATH"] +=3D os.pathsep + \ os.path.join(config["WORKSPACE"], "FSP") -- 2.16.2.windows.1