From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.1156.1573864496663437343 for ; Fri, 15 Nov 2019 16:34:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Nov 2019 16:34:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,310,1569308400"; d="scan'208";a="195552606" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga007.jf.intel.com with ESMTP; 15 Nov 2019 16:34:56 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 Nov 2019 16:34:55 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX157.amr.corp.intel.com ([169.254.9.64]) with mapi id 14.03.0439.000; Fri, 15 Nov 2019 16:34:55 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Wei, David Y" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 47/49] SimicsOpenBoardPkg: Enable advanced features Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V1 47/49] SimicsOpenBoardPkg: Enable advanced features Thread-Index: AQHVmdwyBwAk+gYJ60qQKqQoYgvTGKeMq+Gg Date: Sat, 16 Nov 2019 00:34:55 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BDB65A@ORSMSX114.amr.corp.intel.com> References: <20191113043742.23488-1-michael.a.kubacki@intel.com> <20191113043742.23488-8-michael.a.kubacki@intel.com> In-Reply-To: <20191113043742.23488-8-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTg4Mzc3YTgtN2RkZC00MzE4LTlmNWQtMTNkNDkxNzIyYjA5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicVlrazNPc1NYbUdVT01IZzFEQTlpd1FVYUxhbjJpck1MeGMzK3B3a1lCNFBXa1A4NHdpekFOUERoUXpFNzhrSiJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Tuesday, November 12, 2019 8:38 PM To: devel@edk2.groups.io Cc: Wei, David Y ; Agyeman, Prince Subject: [edk2-devel] [edk2-platforms][PATCH V1 47/49] SimicsOpenBoardPkg:= Enable advanced features This change adds the SMBIOS and Network advanced features to SimicsOpenBoa= rdPkg. These features were previously used in SimicsOpenBoardPkg prior to a= n advanced feature refactor. Note that SimicsOpenBoardPkg depends upon these advanced features even whe= n the boot stage is less than the advanced feature stage. This bug was not fixed in this commit and is filed to be resolved in the f= ollowing Bugzilla item: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2165 Cc: Wei David Y Cc: Agyeman Prince Signed-off-by: Michael Kubacki --- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 10 = ++++++++++ Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc | 6 = ++++++ Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 2 = ++ 3 files changed, 18 insertions(+) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.= dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc index c6b2beee4d..7576648d57 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc @@ -34,7 +34,17 @@ =20 DEFINE SMM_REQUIRE =3D TRUE =20 + # + # PLATFORMX64_ENABLE is set to TRUE when PEI is IA32 and DXE is X64=20 + platform # + DEFINE PLATFORMX64_ENABLE =3D TRUE + DEFINE NETWORK_TLS_ENABLE =3D FALSE + DEFINE NETWORK_ISCSI_ENABLE =3D FALSE + DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE + + !include=20 + AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildWorkaround.d + sc !include $(PROJECT)/OpenBoardPkgPcd.dsc + !include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc =20 #########################################################################= ####### # diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgP= cd.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds= c index 1383a63d36..cd98d09f01 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds +++ c @@ -96,6 +96,8 @@ ###################################### # Advanced Feature Configuration ###################################### + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable|TRUE + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable|TRUE =20 [PcdsFeatureFlag.X64] ###################################### @@ -250,6 +252,10 @@ ###################################### # Advanced Feature Configuration ###################################### + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosReleaseDate|"20= 19-08-09" + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType0StringBiosVersion|"Ver.1.= 0.0" + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType1StringProductName|"QSP UE= FI BIOS" + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosType2StringProductName|"QSP UE= FI BIOS" =20 [PcdsDynamicExDefault] ###################################### diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.= fdf b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf index d29835f606..e0a1daddee 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf @@ -155,6 +155,7 @@ INF MinPlatformPkg/PlatformInit/ReportFv/ReportFvPei.= inf INF MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf INF MinPlatformPkg/PlatformInit/SiliconPolicyPei/SiliconPolicyPeiPreMem.= inf !include MinPlatformPkg/Include/Fdf/CoreSecurityPreMemoryInclude.fdf +!include AdvancedFeaturePkg/Include/PreMemory.fdf INF $(BOARD_PKG)/SimicsPei/SimicsPei.inf !include $(SKT_PKG)/SktPostMemoryInclude.fdf !include $(PCH_PKG)/IchPostMemoryInclude.fdf @@ -197,6 +198,7 @@ INF MdeModulePkg/Bus/Pci/SataControllerDxe/SataContro= llerDxe.inf INF UefiCpuPkg/CpuDxe/CpuDxe.inf =20 !include MinPlatformPkg/Include/Fdf/CoreOsBootInclude.fdf +!include AdvancedFeaturePkg/Include/PostMemory.fdf INF MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf INF MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutor= Dxe.inf INF UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf -- 2.16.2.windows.1