From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web10.263.1574383912318373681 for ; Thu, 21 Nov 2019 16:51:52 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 16:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,227,1571727600"; d="scan'208";a="205251006" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga008.fm.intel.com with ESMTP; 21 Nov 2019 16:51:51 -0800 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 16:51:51 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX160.amr.corp.intel.com ([169.254.13.204]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 16:51:51 -0800 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" , "Gao, Liming" , "Oram, Isaac W" , Jeremy Soller Subject: Re: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib Cleanup Thread-Topic: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib Cleanup Thread-Index: AQHVoEoJW71Dfjo+RUiBdal9CnLA/aeV5tewgAB0maA= Date: Fri, 22 Nov 2019 00:51:50 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5BF0FA2@ORSMSX114.amr.corp.intel.com> References: <20191121085853.2626-1-nathaniel.l.desimone@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmE4YTU4MTctY2IzYi00ZTRiLTk5YmYtOGY4YjJkNTM1NWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiXC9qVVJNdU1sOXZFRm10bkxodFBaRndJXC9EWktmcjNlaEVrK3lwVW9aVTZMSGtsTm9raDMzaEwxdUtqb1wvRlFZUCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yeah sure: 1. Rebased with the newest version of master branch 2. Fixed the coding style issue in FspWrapperPlatformSecLib.c line 179 3. Removed BoardInitLib from SecFspWrapperPlatformSecLib.inf 4. Removed the duplicate definition of EFI_HOB_GENERIC_HEADER and EFI_HOB_G= UID_TYPE in TcoWdtHob.h 5. Changed the comments in SiliconInitLib to refer to Silicon instead of PC= H 6. Marked SiliconInitLib as a SEC + PEIM library instead of just PEIM. Thanks, Nate -----Original Message----- From: Kubacki, Michael A =20 Sent: Thursday, November 21, 2019 9:52 AM To: Desimone, Nathaniel L ; devel@edk2.grou= ps.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Gao, Liming ; Oram, Isaac W ; Jeremy Soller Subject: RE: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib = Cleanup Can you please summarize the changes in V2 of the series? Thanks, Michael > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Thursday, November 21, 2019 12:59 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A=20 > ; Chaganty, Rangasai V=20 > ; Gao, Liming ;=20 > Oram, Isaac W ; Jeremy Soller=20 > > Subject: [edk2-platforms] [PATCH V2 00/14] SecFspWrapperPlatformSecLib=20 > Cleanup >=20 > This patch series cleans up two outstanding problems with > SecFspWrapperPlatformSecLib: >=20 > 1. There are several copies of SecFspWrapperPlatformSecLib > thoughout the codebase, this patch series consolidates > the various implementations down to a single implementation > contained in MinPlatformPkg. >=20 > The WhiskeylakeOpenBoardPkg implementation of=20 > SecFspWrapperPlatformSecLib diverged from MinPlatformPkg by halting=20 > the TCO watch dog timer early in SEC instead of early in PEI. Analysis=20 > of this change has shown that it is unnessesary, so this patch series=20 > move that code back to PEI. >=20 > The KabylakeOpenBoardPkg implementation of SecFspWrapperPlatformSecLib=20 > contains support for FSP dispatch mode. This was integrated into=20 > MinPlatformPkg, eliminating the need for KabylakeOpenBoardPkg version. >=20 > 2. Due to EFI_PEI_TEMPORARY_RAM_DONE_PPI being implemented > by SecMain, the BoardInitLib event callbacks for > BeforeTempRamExit() and AfterTempRamExit() are currently > linked by PlatformSecLib. Linking BoardInitLib in SEC > phase places a lot of restrictions on how BoardInitLib > is implemented. To mitigate this, the BoardInitLib calls > have been moved to a PlatformInitPreMem. > PlatformInitPreMem is invoked by PlatformSecLib using the > new PLATFORM_INIT_TEMP_RAM_EXIT_PPI, which then invokes > the BoardInitLib event callbacks. >=20 > This patch series also includes some general cleanup. >=20 > Cc: Chasel Chiu > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Isaac W Oram > Cc: Jeremy Soller > Signed-off-by: Nate DeSimone >=20 > Nate DeSimone (14): > KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM > KabylakeOpenBoardPkg: Update location of SiliconInitLib > KabylakeSiliconPkg: Cleanup old comments > CoffeeLakeSiliconPkg: Move TcoWdtHob.h > CoffeeLakeSiliconPkg: TcoWdtHob.h Cleanup > CoffeelakeSiliconPkg: Add SiliconInitLib > WhiskeylakeOpenBoardPkg: Add SiliconInitLib APIs to BoardInitLib > WhiskeylakeOpenBoardPkg: Whitespace cleanup in BoardInitLib > WhiskeylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib override > MinPlatformPkg: FSP Dispatch Mode Support for PlatformSecLib > MinPlatformPkg: Coding style cleanups in MinPlatformPkg.dec > KabylakeOpenBoardPkg: Add support for=20 > PcdFspDispatchModeUseFspPeiMain > KabylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib override > MinPlatformPkg: Remove BoardInitLib dependency from PlatformSecLib >=20 > .../FspWrapperPlatformSecLib.c | 186 --------- > .../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 -- > .../SecFspWrapperPlatformSecLib/Ia32/Fsp.h | 42 -- > .../Ia32/PeiCoreEntry.nasm | 130 ------- > .../Ia32/SecEntry.nasm | 361 ------------------ > .../Ia32/Stack.nasm | 72 ---- > .../PlatformInit.c | 47 --- > .../SecFspWrapperPlatformSecLib.inf | 97 ----- > .../SecGetPerformance.c | 89 ----- > .../SecPlatformInformation.c | 78 ---- > .../SecRamInitData.c | 36 -- > .../SecTempRamDone.c | 73 ---- > .../GalagoPro3/OpenBoardPkg.dsc | 4 +- > .../KabylakeRvp3/OpenBoardPkg.dsc | 4 +- > .../KabylakeRvp3/OpenBoardPkg.fdf | 5 +- > .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 20 + > .../FspWrapperPlatformSecLib.c | 34 +- > .../SecFspWrapperPlatformSecLib.inf | 9 +- > .../SecTempRamDone.c | 72 +++- > .../Include/Ppi/PlatformInitTempRamExitPpi.h | 55 +++ > .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 313 ++++++++------- > .../PlatformInitPei/PlatformInitPreMem.c | 76 +++- > .../PlatformInitPei/PlatformInitPreMem.inf | 1 + > .../FspWrapperPlatformSecLib.c | 163 -------- > .../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 -- > .../SecFspWrapperPlatformSecLib/Ia32/Fsp.h | 43 --- > .../Ia32/PeiCoreEntry.nasm | 130 ------- > .../Ia32/SecEntry.nasm | 361 ------------------ > .../Ia32/Stack.nasm | 72 ---- > .../PlatformInit.c | 54 --- > .../SecFspWrapperPlatformSecLib.inf | 97 ----- > .../SecGetPerformance.c | 90 ----- > .../SecPlatformInformation.c | 79 ---- > .../SecRamInitData.c | 37 -- > .../SecTempRamDone.c | 48 --- > .../Include/Guid/TcoWdtHob.h | 41 -- > .../BoardInitLib/PeiBoardInitPostMemLib.inf | 1 + > .../BoardInitLib/PeiBoardInitPreMemLib.inf | 1 + > .../PeiMultiBoardInitPostMemLib.inf | 1 + > .../PeiMultiBoardInitPreMemLib.inf | 2 +- > .../PeiWhiskeylakeURvpInitPostMemLib.c | 191 +++++---- > .../PeiWhiskeylakeURvpInitPreMemLib.c | 346 +++++++---------- > .../BoardInitLib/WhiskeylakeURvpInit.h | 1 + > .../WhiskeylakeURvp/OpenBoardPkg.dsc | 7 +- > .../Include/Guid/TcoWdtHob.h | 22 ++ > .../Include/Library/SiliconInitLib.h | 28 ++ > .../PeiSiliconInitLib/PeiSiliconInitLib.inf | 46 +++ > .../Library/PeiSiliconInitLib/SiliconInit.c | 19 + > .../PeiSiliconInitLib/SiliconInitPreMem.c | 109 ++++++ > .../PeiSiliconInitLib.inf} | 5 +- > .../SiliconInit.c | 3 + > .../SiliconInitPreMem.c | 4 +- > 52 files changed, 890 insertions(+), 2995 deletions(-) delete mode=20 > 100644=20 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FspWrapperPlatformSecLib.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/FsptCoreUpd.h > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/Fsp.h > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/PeiCoreEntry.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/SecEntry.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/Ia32/Stack.nasm > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/PlatformInit.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecFspWrapperPlatformSecLib.inf > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecGetPerformance.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecPlatformInformation.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecRamInitData.c > delete mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper > PlatformSecLib/SecTempRamDone.c > create mode 100644 > Platform/Intel/MinPlatformPkg/Include/Ppi/PlatformInitTempRamExitPpi.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/FspWrapperPlatformSecLib.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/FsptCoreUpd.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/Fsp.h > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/PeiCoreEntry.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/SecEntry.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/Ia32/Stack.nasm > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/PlatformInit.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecFspWrapperPlatformSecLib.inf > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecGetPerformance.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecPlatformInformation.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecRamInitData.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/SecFspWra > pperPlatformSecLib/SecTempRamDone.c > delete mode 100644 > Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Include/Library/SiliconInitLib.h > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/PeiSilico > nInitLib.in > f > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/SiliconIn > it.c > create mode 100644 > Silicon/Intel/CoffeelakeSiliconPkg/Library/PeiSiliconInitLib/SiliconIn > itPreMem > .c > rename > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib/SiliconInitLi > b.inf =3D> PeiSiliconInitLib/PeiSiliconInitLib.inf} (86%) rename=20 > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D>=20 > PeiSiliconInitLib}/SiliconInit.c (95%) rename=20 > Silicon/Intel/KabylakeSiliconPkg/Library/{SiliconInitLib =3D>=20 > PeiSiliconInitLib}/SiliconInitPreMem.c (95%) >=20 > -- > 2.24.0.windows.2