From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com []) by mx.groups.io with SMTP id smtpd.web10.445.1575417459945456390 for ; Tue, 03 Dec 2019 15:57:42 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Dec 2019 15:57:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,275,1571727600"; d="scan'208";a="223018398" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga002.jf.intel.com with ESMTP; 03 Dec 2019 15:57:41 -0800 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 3 Dec 2019 15:57:41 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.67]) by ORSMSX116.amr.corp.intel.com ([169.254.7.11]) with mapi id 14.03.0439.000; Tue, 3 Dec 2019 15:57:40 -0800 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/AdvancedFeaturePkg: Add package Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/AdvancedFeaturePkg: Add package Thread-Index: AQHVpYhE3drlnOIa6E2/10iYw2vUfaepHyIQ Date: Tue, 3 Dec 2019 23:57:40 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5C13E31@ORSMSX114.amr.corp.intel.com> References: <20191128010614.43628-1-michael.a.kubacki@intel.com> <20191128010614.43628-23-michael.a.kubacki@intel.com> In-Reply-To: <20191128010614.43628-23-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGFmOGYyODItYWU1OC00MjFjLThmYTAtNjdiNDk2Y2IxMGY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTm5TOGZqc3JvVG9Gem80Mjd0d0tZY1c3aFpob1gwRVJEc3psRFk1QURKS2hHYys5OU12NTIxM3dZSFVuOHB2WCJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: devel@edk2.groups.io On Behalf Of Kubacki, Mi= chael A Sent: Wednesday, November 27, 2019 5:06 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/Adva= ncedFeaturePkg: Add package This change adds AdvancedFeaturePkg to the Features/Intel directory. Advan= cedFeaturePkg is a special package that is located at the root level of Fea= tures/Intel. All advanced features can be built using the AdvancedFeaturePkg build. To = build all advanced features, follow the instructions in the Feature/Intel/R= eadme.md file. The actual build is performed by executing the following com= mand in the Features/Intel directory: "build -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc -a IA32 -a X64" Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 31 +++++= ++++++ Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 51 +++++= +++++++++++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc | 56 +++++= +++++++++++++++ 3 files changed, 138 insertions(+) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec b/Fe= atures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec new file mode 100644 index 0000000000..797a1eeb98 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec @@ -0,0 +1,31 @@ +## @file +# Advanced Feature Package build declaration file. +# +# Advanced features allow a board package to be extended with advanced fu= nctionality. +# +# This package should not contain any specific advanced features. The pac= kage has two responsibilities: +# 1. Present a consolidated and simplified view of all available advanced= features to board packages. +# 2. Provide a simple, single package build for all available advanced fe= atures. +# +# The DEC files are used by the utilities that parse DSC and # INF=20 +files to generate AutoGen.c and AutoGen.h files # for the build=20 +infrastructure. +# +# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ##=20 +[Defines] DEC_SPECIFICATION =3D 0x00010017 +PACKAGE_NAME =3D AdvancedFeaturePkg +PACKAGE_VERSION =3D 0.1 +PACKAGE_GUID =3D 086F1F68-76CD-4F40-A712-06939A0BDD12 + +[Includes] +Include + +[Guids] +gAdvancedFeaturePkgTokenSpaceGuid =3D {0xa8514688, 0x6693, 0x4ab= 5, {0xaa, 0xc8, 0xcc, 0xa9, 0x8d, 0xde, 0x90, 0xe1}} + +[PcdsFeatureFlag] diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fe= atures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc new file mode 100644 index 0000000000..50c0e81048 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -0,0 +1,51 @@ +## @file +# Advanced Feature Package build description file. +# +# Advanced features allow a board package to be extended with advanced fu= nctionality. +# +# This package should not contain any specific advanced features. The pac= kage has two responsibilities: +# 1. Present a consolidated and simplified view of all available advanced= features to board packages. +# 2. Provide a simple, single package build for all available advanced fe= atures. +# +# Copyright (c) 2017 - 2019, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +####################################################################### +######### +# +# Defines Section - statements that will be processed to create a Makefil= e. +# +####################################################################### +######### +[Defines] + PLATFORM_NAME =3D AdvancedFeaturePkg + PLATFORM_GUID =3D 5E4C05BC-C5F0-4843-BAE1-3AAFE26= 9DB8F + PLATFORM_VERSION =3D 0.1 + DSC_SPECIFICATION =3D 0x00010005 + OUTPUT_DIRECTORY =3D Build/AdvancedFeaturePkg + SUPPORTED_ARCHITECTURES =3D IA32|X64 + BUILD_TARGETS =3D DEBUG|RELEASE + SKUID_IDENTIFIER =3D DEFAULT + PEI_ARCH =3D IA32 + DXE_ARCH =3D X64 + +####################################################################### +######### +# +# Advanced Feature Enable section - all advanced features are enabling fo= r the +# AdvancedFeaturePkg build. +# +####################################################################### +######### +[PcdsFeatureFlag] + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable = |TRUE + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable = |TRUE + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable = |TRUE + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |TRUE + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |TRUE + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |TRUE + gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |TRUE + +# +# This package builds all advanced features. +# +!include Include/AdvancedFeatures.dsc diff --git a/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.ds= c b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc new file mode 100644 index 0000000000..649774edf7 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc @@ -0,0 +1,56 @@ +## @file +# DSC file for advanced features. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally built by enabling the respectiv= e feature via its FeaturePCD. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# #=20 +SPDX-License-Identifier: BSD-2-Clause-Patent # ## + +# +# Debug Advanced Features +# +!if gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc +!endif +!if gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable =3D=3D= =20 +TRUE + !include Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc +!endif + +# +# Network Advanced Features +# +!if gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable =3D=3D TRUE + !include Network/NetworkFeaturePkg/Include/NetworkFeature.dsc +!endif + +# +# Out-of-Band Management Advanced Features # !if=20 +gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable =3D=3D TRUE + !include OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc +!endif + +# +# Power Management Advanced Features +# +!if gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable =3D=3D TRUE + !include PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +!endif + +# +# System Information Advanced Features +# +!if gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable =3D=3D TRUE + !include SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.dsc +!endif + +# +# User Interface Advanced Features +# +!if=20 +gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable =3D= =3D=20 +TRUE + !include UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.dsc +!endif -- 2.16.2.windows.1