From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"Kubacki, Michael A" <michael.a.kubacki@intel.com>
Subject: Re: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing
Date: Thu, 12 Dec 2019 23:06:32 +0000 [thread overview]
Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5C47702@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20191212011314.6860-1-prince.agyeman@intel.com>
Hi Prince,
Is 256KB really necessary? Could you try the 152KB (0x26000) that we had previously?
Thanks,
Nate
-----Original Message-----
From: Agyeman, Prince <prince.agyeman@intel.com>
Sent: Wednesday, December 11, 2019 5:13 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Kubacki, Michael A <michael.a.kubacki@intel.com>
Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2409
Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing.
This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP binary (v 7.0.68.41)
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
.../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc
index 906f7b7ade..b3e1da3970 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk
+++ gPcd.dsc
@@ -54,15 +54,14 @@
gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000
#
- # FSP API mode does not share stack with the boot loader,
- # so FSP needs more temporary memory for FSP heap + stack size.
+ # When sharing stack with boot loader, FSP only needs small temp ram
+ for heap
#
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000
+
#
- # FSP API mode does not need to enlarge the boot loader stack size
- # since the stacks are separate.
+ # Boot loader stack size has to be big enough to executing FSP
#
- gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
+ gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000
gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000
--
2.19.1.windows.1
next prev parent reply other threads:[~2019-12-12 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 1:13 [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Agyeman, Prince
2019-12-12 11:38 ` Chiu, Chasel
2019-12-12 18:13 ` Kubacki, Michael A
2019-12-12 23:06 ` Nate DeSimone [this message]
2019-12-13 16:25 ` Agyeman, Prince
2019-12-13 22:13 ` Nate DeSimone
[not found] ` <15E00DF9E44B8812.24131@groups.io>
2019-12-13 22:27 ` [edk2-devel] " Nate DeSimone
2019-12-13 23:39 ` Agyeman, Prince
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02A34F284D1DA44BB705E61F7180EF0AB5C47702@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox