From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.11447.1576524945067198467 for ; Mon, 16 Dec 2019 11:35:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 11:35:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,322,1571727600"; d="scan'208";a="227223991" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga002.jf.intel.com with ESMTP; 16 Dec 2019 11:35:44 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.106]) by ORSMSX110.amr.corp.intel.com ([169.254.10.84]) with mapi id 14.03.0439.000; Mon, 16 Dec 2019 11:35:44 -0800 From: "Nate DeSimone" To: "Kubacki, Michael A" , "Chiu, Chasel" , "Agyeman, Prince" CC: "devel@edk2.groups.io" Subject: Re: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVsh3gZxN3vT3u5U+DsCwTR4vgdae8cnUAgAEdugD//5sFUA== Date: Mon, 16 Dec 2019 19:35:42 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5C50554@ORSMSX114.amr.corp.intel.com> References: <8d09f32eda0d6e8fdc40c7be6e8472323db4c1c5.1576286588.git.prince.agyeman@intel.com> <3C3EFB470A303B4AB093197B6777CCEC505CA6B9@PGSMSX111.gar.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGQ3NWVhZWYtZTI2My00MTMzLWFhNGYtZTFjOWI3ODkxYjY1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRys0RzNHVTYwUW1tUUh4ME5ERlJCNEd5bXlyQmo3TWZaMEdkeklkSjFFU0RBTTNJVkFjYWNxVHFiUkxQZFd4cSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It's a careful balancing act. The more you allocate to temp ram the less wi= ll be available to cache the SPI flash, which can impact responsiveness dep= ending on the size of your IBB. I agree that 192KB is probably a good compr= omise. Thanks, Nate -----Original Message----- From: Kubacki, Michael A =20 Sent: Monday, December 16, 2019 9:35 AM To: Chiu, Chasel ; Agyeman, Prince ; Desimone, Nathaniel L Cc: devel@edk2.groups.io Subject: RE: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PC= Ds to enable stack sharing I agree with Chasel. There should be enough T-RAM available to expand this = to 0x30000 without a problem and reduce potential thrash in the future. Thanks, Michael > -----Original Message----- > From: Chiu, Chasel > Sent: Sunday, December 15, 2019 4:32 PM > To: Agyeman, Prince ; Desimone, Nathaniel L=20 > > Cc: Kubacki, Michael A ;=20 > devel@edk2.groups.io > Subject: RE: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: > Update PCDs to enable stack sharing >=20 >=20 > Hi Nate, Prince, >=20 > I would recommend that we set larger > gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize so we do not have to=20 > update this again and again later when required temporary ram=20 > increased by enabling some boot loader features. > How about set it to 0x30000? >=20 > Thanks, > Chasel >=20 > > -----Original Message----- > > From: Agyeman, Prince > > Sent: Saturday, December 14, 2019 9:29 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L=20 > > ; Kubacki, Michael A=20 > > > > Subject: [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update=20 > > PCDs to enable stack sharing > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 > > > > Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. > > This fixes the boot failure seen with the latest Coffee Lake (CFL)=20 > > FSP binary (v > > 7.0.68.41) > > > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Michael Kubacki > > > > Signed-off-by: Prince Agyeman > > --- > > .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 11 > > +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > index 906f7b7ade..cfe42883be 100644 > > --- > > > a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > kgPcd.dsc > > +++ > > > b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoard > P > > k > > +++ gPcd.dsc > > @@ -54,15 +54,14 @@ > > gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 > > > > # > > - # FSP API mode does not share stack with the boot loader, > > - # so FSP needs more temporary memory for FSP heap + stack size. > > + # When sharing stack with boot loader, FSP only needs small temp=20 > > + ram for heap > > # > > - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 > > + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 > > + > > # > > - # FSP API mode does not need to enlarge the boot loader stack=20 > > size > > - # since the stacks are separate. > > + # Boot loader stack size has to be big enough to executing FSP > > # > > - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 > > + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x28000 > > > > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 > > > > > gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 > > -- > > 2.19.1.windows.1 >=20