From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3656.1576624257503720800 for ; Tue, 17 Dec 2019 15:10:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 15:10:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="417013146" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga006.fm.intel.com with ESMTP; 17 Dec 2019 15:10:56 -0800 Received: from orsmsx121.amr.corp.intel.com (10.22.225.226) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 15:10:56 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.106]) by ORSMSX121.amr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Tue, 17 Dec 2019 15:10:56 -0800 From: "Nate DeSimone" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Topic: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing Thread-Index: AQHVtSypJqdrrcF7/EipIkv/jP43Iqe+9Aag Date: Tue, 17 Dec 2019 23:10:55 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5C639F1@ORSMSX114.amr.corp.intel.com> References: <20191217225134.40000-1-michael.a.kubacki@intel.com> In-Reply-To: <20191217225134.40000-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2E3OGY0NzctOTdjYS00Njg0LWE0NzItY2RlN2YyMGNlMzRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQW5YS0hPK2VVOWdZUFV0ZUVIcGZuQ2hkaWVxSnJwUFc5UDhTZ2J3Nkl2ME9FaUdrYUFGWk5KR1NVY3dzNllMcyJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Kubacki, Michael A =20 Sent: Tuesday, December 17, 2019 2:52 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH V3 1/1] WhiskeylakeOpenBoardPkg: Update PCD= s to enable stack sharing From: "Agyeman, Prince" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2409 Updated WhiskeylakeURvp PCDs to enable FSP/BL stack sharing. This fixes the boot failure seen with the latest Coffee Lake (CFL) FSP bina= ry (v 7.0.68.41). Cc: Chasel Chiu Cc: Nate DeSimone Cc: Michael Kubacki Co-authored-by: Michael Kubacki Signed-off-by: Prince Agyeman Reviewed-by: Chasel Chiu --- Notes: 1. Michael Kubacki is taking over patch ownership since Prince is out of office. =20 V3 Change: - Changed the value of PcdPeiTemporaryRamStackSize to 0x30000 to exceed the minimum stack size specified in the Coffee Lake FSP Integration Guide (160KB / 0x28000) with some padding. =20 V2 Change: - The value of PcdPeiTemporaryRamStackSize was changed from 0x40000 to 0x28000 to exactly meet the minimum stack size specified in the Coffee Lake FSP Integration Guide. Note that the memory initialization code in the FSP previously exceeded the available stack size. Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPcd.dsc= | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoa= rdPkgPcd.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenB= oardPkgPcd.dsc index 906f7b7ade..1ae51d9d5e 100644 --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkgPc= d.dsc +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPk +++ gPcd.dsc @@ -54,15 +54,14 @@ gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 =20 # - # FSP API mode does not share stack with the boot loader, - # so FSP needs more temporary memory for FSP heap + stack size. + # When sharing stack with boot loader, FSP only needs small temp ram=20 + for heap # - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x26000 + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize|0x10000 + # - # FSP API mode does not need to enlarge the boot loader stack size - # since the stacks are separate. + # Boot loader stack size has to be big enough to executing FSP # - gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x30000 =20 gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 gMinPlatformPkgTokenSpaceGuid.PcdPciExpressRegionLength|0x10000000 -- 2.16.2.windows.1