public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string
@ 2020-01-10 21:44 Desimone, Ashley E
  2020-01-17  0:47 ` Nate DeSimone
  0 siblings, 1 reply; 3+ messages in thread
From: Desimone, Ashley E @ 2020-01-10 21:44 UTC (permalink / raw)
  To: devel; +Cc: Nate DeSimone, Puja Pandya, Erik Bjorge, Bret Barkelew

Remove unused string NOT_IN_INDEX. The contents of this string
was the same as VERIFY_PROJ_NOT_IN_INDEX.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 edkrepo/common/humble.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/edkrepo/common/humble.py b/edkrepo/common/humble.py
index 7f28d08..3ad03ac 100644
--- a/edkrepo/common/humble.py
+++ b/edkrepo/common/humble.py
@@ -95,8 +95,6 @@ MIRROR_PRIMARY_REPOS_MISSING = 'The edkrepo global configuration file missing [p
 MIRROR_DECODE_WARNING = 'WARNING: Could not decode so assuming a primary repo: {}'
 MAX_PATCH_SET_INVALID = 'Invalid value detected in user configuration file for max-patch-set (must be an integer).'
 
-NOT_IN_INDEX = 'The selected project cannot be found in the global manifest repository'
-
 # Manifest verification error messages
 VERIFY_ERROR_HEADER = 'Manifest repository verification errors:'
 VERIFY_EXCEPTION_MSG = 'Manifest repository verification failed'
-- 
2.16.2.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string
  2020-01-10 21:44 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string Desimone, Ashley E
@ 2020-01-17  0:47 ` Nate DeSimone
  2020-01-17  0:55   ` [edk2-devel] " Bjorge, Erik C
  0 siblings, 1 reply; 3+ messages in thread
From: Nate DeSimone @ 2020-01-17  0:47 UTC (permalink / raw)
  To: Desimone, Ashley E, devel@edk2.groups.io
  Cc: Pandya, Puja, Bjorge, Erik C, Bret Barkelew

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, January 10, 2020 1:44 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string

Remove unused string NOT_IN_INDEX. The contents of this string was the same as VERIFY_PROJ_NOT_IN_INDEX.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 edkrepo/common/humble.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/edkrepo/common/humble.py b/edkrepo/common/humble.py index 7f28d08..3ad03ac 100644
--- a/edkrepo/common/humble.py
+++ b/edkrepo/common/humble.py
@@ -95,8 +95,6 @@ MIRROR_PRIMARY_REPOS_MISSING = 'The edkrepo global configuration file missing [p  MIRROR_DECODE_WARNING = 'WARNING: Could not decode so assuming a primary repo: {}'
 MAX_PATCH_SET_INVALID = 'Invalid value detected in user configuration file for max-patch-set (must be an integer).'
 
-NOT_IN_INDEX = 'The selected project cannot be found in the global manifest repository'
-
 # Manifest verification error messages
 VERIFY_ERROR_HEADER = 'Manifest repository verification errors:'
 VERIFY_EXCEPTION_MSG = 'Manifest repository verification failed'
--
2.16.2.windows.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string
  2020-01-17  0:47 ` Nate DeSimone
@ 2020-01-17  0:55   ` Bjorge, Erik C
  0 siblings, 0 replies; 3+ messages in thread
From: Bjorge, Erik C @ 2020-01-17  0:55 UTC (permalink / raw)
  To: devel@edk2.groups.io, Desimone, Nathaniel L, Desimone, Ashley E
  Cc: Pandya, Puja, Bret Barkelew

Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, January 16, 2020 4:47 PM
To: Desimone, Ashley E <ashley.e.desimone@intel.com>; devel@edk2.groups.io
Cc: Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Desimone, Ashley E <ashley.e.desimone@intel.com> 
Sent: Friday, January 10, 2020 1:44 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string

Remove unused string NOT_IN_INDEX. The contents of this string was the same as VERIFY_PROJ_NOT_IN_INDEX.

Signed-off-by: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 edkrepo/common/humble.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/edkrepo/common/humble.py b/edkrepo/common/humble.py index 7f28d08..3ad03ac 100644
--- a/edkrepo/common/humble.py
+++ b/edkrepo/common/humble.py
@@ -95,8 +95,6 @@ MIRROR_PRIMARY_REPOS_MISSING = 'The edkrepo global configuration file missing [p  MIRROR_DECODE_WARNING = 'WARNING: Could not decode so assuming a primary repo: {}'
 MAX_PATCH_SET_INVALID = 'Invalid value detected in user configuration file for max-patch-set (must be an integer).'
 
-NOT_IN_INDEX = 'The selected project cannot be found in the global manifest repository'
-
 # Manifest verification error messages
 VERIFY_ERROR_HEADER = 'Manifest repository verification errors:'
 VERIFY_EXCEPTION_MSG = 'Manifest repository verification failed'
--
2.16.2.windows.1





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-01-17  0:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-10 21:44 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Remove unused string Desimone, Ashley E
2020-01-17  0:47 ` Nate DeSimone
2020-01-17  0:55   ` [edk2-devel] " Bjorge, Erik C

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox