From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.1188.1581492632442981988 for ; Tue, 11 Feb 2020 23:30:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 23:30:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="226725621" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga007.fm.intel.com with ESMTP; 11 Feb 2020 23:30:32 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Feb 2020 23:30:31 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.140]) by ORSMSX157.amr.corp.intel.com ([169.254.9.95]) with mapi id 14.03.0439.000; Tue, 11 Feb 2020 23:30:31 -0800 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Zeng, Star" Subject: Re: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues Thread-Topic: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues Thread-Index: AQHV38Wu5lkL9zyXsUmOkUWO1GwfbqgXLPPQ Date: Wed, 12 Feb 2020 07:30:31 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5D43D7C@ORSMSX114.amr.corp.intel.com> References: <20200210035329.19432-1-chasel.chiu@intel.com> In-Reply-To: <20200210035329.19432-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjFlNDQ2ZTAtZjY1ZC00ODUzLTkwNGEtYTE5NWQ2OWRkYjQyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ2UxUkwrdUJSVkFcLzhZQVcxUHMrZGgwM2pLTmNOUjdCSVhZZHJrQUZmdDVYT0QyR0gydkkyRjMwUjJCQk8wY1AifQ== x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: nathaniel.l.desimone@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the patch series... Reviewed-by: Nate DeSimone -----Original Message----- From: Chiu, Chasel =20 Sent: Sunday, February 9, 2020 7:53 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues GenCfgOpt.py: Issue was: invalid_operation: Invalid operation on null-like value "Base". Fixed it by initializing Base to 0 before entering while loop. SplitFspBin.py: Issues were: 1. copy_paste_error: PeOptHdr vs PePlusOptHdr. 2. invalid_operation: Invalid operation on null-like value "roffset". 3. invalid_operation: Invalid operation on null-like value "rsize". Fixed them by initializing roffset and rsize as PE32 image type and overrid= ing them when PE32+ header found. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Chasel Chiu (2): IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues. IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues. IntelFsp2Pkg/Tools/GenCfgOpt.py | 3 ++- IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++----- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.13.3.windows.1