From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.8161.1582772706846606489 for ; Wed, 26 Feb 2020 19:05:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 19:05:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,490,1574150400"; d="scan'208";a="238259987" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2020 19:05:05 -0800 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.140]) by ORSMSX103.amr.corp.intel.com ([169.254.5.43]) with mapi id 14.03.0439.000; Wed, 26 Feb 2020 19:05:05 -0800 From: "Nate DeSimone" To: Pankaj Bansal , "Qian, Yi" , Ard Biesheuvel , Marcin Wojtas , "Sun, Zailiang" , "Steele, Kelly" , "Gao, Liming" , "Chiu, Chasel" , "Kinney, Michael D" , Leif Lindholm , "Meenakshi Aggarwal" , Varun Sethi , "Pete Batard" CC: "devel@edk2.groups.io" , Pankaj Bansal Subject: Re: [PATCH edk2-platforms v2 1/1] Platform: Add SerialUartClockLib for all platforms Thread-Topic: [PATCH edk2-platforms v2 1/1] Platform: Add SerialUartClockLib for all platforms Thread-Index: AQHV59qOjzb53q5zfEWHPX8om0iHUqguZJVQ Date: Thu, 27 Feb 2020 03:05:05 +0000 Message-ID: <02A34F284D1DA44BB705E61F7180EF0AB5D8EEAD@ORSMSX114.amr.corp.intel.com> References: <20200220160241.13488-1-pankaj.bansal@oss.nxp.com> In-Reply-To: <20200220160241.13488-1-pankaj.bansal@oss.nxp.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzcxOTk5OWItOGNhZi00ZTExLTlkMGItMDFlYTUyNDJjZDFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiY2owMmVKMW1URDZ5enNtT0hHSFU4TDFcL3ZjRXhOcThxb0cralwvVXdPOUNIMGZ0R1A3ZGdXdmxDYVhhT2NKc3BrIn0= x-ctpclassification: CTP_NT x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Pankaj, Assuming that your other patch (https://edk2.groups.io/g/devel/message/5462= 9) is approved and merged to edk2, this patch looks good at least for the I= ntel platforms. Once https://edk2.groups.io/g/devel/message/54629 is merged... Reviewed-by: Nate DeSimone -----Original Message----- From: Pankaj Bansal =20 Sent: Thursday, February 20, 2020 8:03 AM To: Qian, Yi ; Ard Biesheuvel ; Marcin Wojtas ; Sun, Zailiang ;= Steele, Kelly ; Gao, Liming = ; Desimone, Nathaniel L ; Chiu, Chasel ; Kinney, Michael D ; Leif L= indholm ; Meenakshi Aggarwal ; Varun Sethi ; Pete Batard Cc: devel@edk2.groups.io; Pankaj Bansal Subject: [PATCH edk2-platforms v2 1/1] Platform: Add SerialUartClockLib for= all platforms From: Pankaj Bansal BaseSerialPortLib16550 has been modified to use SerialUartClockLib. Therefore, add the default implementation of SerialUartClockLib for all the= platforms using BaseSerialPortLib16550. Signed-off-by: Pankaj Bansal --- Notes: V2: - removed RaspberryPi3 and RaspberryPi4 platforms from patch as these platforms no longer use BaseSerialPortLib16550.inf Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 1 + Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 ++++++ Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 ++++++ Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 1 + Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 1 + Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + 10 files changed, 20 insertions(+) diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Pla= tform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index b83e72b48c47..90cd72aff0d5 100644 --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -74,6 +74,7 @@ [LibraryClasses.common] PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseRepor= tStatusCodeLibNull.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/= Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc index 23ab53dbfe12..172ba6822419 100644 --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc @@ -20,6 +20,7 @@ [LibraryClasses.common] DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiA= pplicationEntryPoint.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf =20 diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/Qua= rkPlatformPkg/Quark.dsc index a02adb64e695..b275298a5ddb 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -213,6 +213,7 @@ [LibraryClasses] # IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf I2cLib|QuarkSocPkg/QuarkSouthCluster/Library/I2cLib/I2cLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf =20 diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/= QuarkPlatformPkg/QuarkMin.dsc index 3dbf616c664d..cffd777a6721 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -185,6 +185,7 @@ [LibraryClasses] # IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf I2cLib|QuarkSocPkg/QuarkSouthCluster/Library/I2cLib/I2cLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf =20 diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platfor= m/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc index 463b952e6582..91b2754ea509 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc @@ -184,6 +184,7 @@ [LibraryClasses.common] SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf !else DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.in= f + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !endif =20 @@ -200,6 +201,7 @@ [LibraryClasses.common] !if $(SOURCE_DEBUG_ENABLE) =3D= =3D TRUE PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDeb= ug/PeCoffExtraActionLibDebug.inf DebugCommunicationLib|SourceLevelDebugPkg/Library/DebugCommunicationLibS= erialPort/DebugCommunicationLibSerialPort.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !else PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf @@ -280,6 +282,7 @@ [LibraryClasses.IA32.PEIM, LibraryClasses.IA32.PEI_CORE= , LibraryClasses.IA32.SEC SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf !else DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebug= LibReportStatusCode.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !endif =20 @@ -779,6 +782,7 @@ [Components.IA32] PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgen= tLib.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePla= tformHookLibNull.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } !endif @@ -933,6 +937,7 @@ [Components.IA32] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmm.inf @@ -1223,6 +1228,7 @@ [Components.IA32] DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPor= t.inf PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } !endif diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform= /Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc index ee18b45c9712..749a2dd4948b 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -186,6 +186,7 @@ [LibraryClasses.common] SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf !else DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.in= f + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !endif =20 @@ -202,6 +203,7 @@ [LibraryClasses.common] !if $(SOURCE_DEBUG_ENABLE) =3D= =3D TRUE PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDeb= ug/PeCoffExtraActionLibDebug.inf DebugCommunicationLib|SourceLevelDebugPkg/Library/DebugCommunicationLibS= erialPort/DebugCommunicationLibSerialPort.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !else PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf @@ -282,6 +284,7 @@ [LibraryClasses.IA32.PEIM, LibraryClasses.IA32.PEI_CORE= , LibraryClasses.IA32.SEC SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull= .inf !else DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebug= LibReportStatusCode.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf !endif =20 @@ -781,6 +784,7 @@ [Components.IA32] PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgen= tLib.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePla= tformHookLibNull.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } !endif @@ -948,6 +952,7 @@ [Components.X64] MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmm.inf @@ -1238,6 +1243,7 @@ [Components.X64] DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPor= t.inf PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerial= PortLib16550.inf } !endif diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/So= cionext/DeveloperBox/DeveloperBox.dsc index 9f8cb68cdd26..281de3197d0c 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc @@ -32,6 +32,7 @@ [LibraryClasses] !if $(DEBUG_ON_UART1) =3D=3D FALSE SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortL= ib.inf !else + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc b/Platform/= Socionext/DeveloperBox/DeveloperBoxMm.dsc index 00f6d4496377..ef3ed0f20911 100644 --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc @@ -35,6 +35,7 @@ [LibraryClasses] StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint= /StandaloneMmDriverEntryPoint.inf StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmL= ib.inf =20 + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf diff --git a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc b/Silicon/Intel/Quar= kSocPkg/QuarkSocPkg.dsc index e743a5e272e4..2e4bf8c1259c 100644 --- a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc +++ b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc @@ -105,6 +105,7 @@ [LibraryClasses] # Quark South Cluster # IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf # diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvel= l/Armada7k8k/Armada7k8k.dsc.inc index 42f8bbba926c..4cf6429d7476 100644 --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc @@ -87,6 +87,7 @@ [LibraryClasses.common] UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf =20 # Serial port libraries + =20 + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSer + ialUartClockLib.inf SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPort= Lib16550.inf PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatfor= mHookLibNull.inf =20 -- 2.17.1