public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: edk2-devel@lists.01.org,
	"Leif Lindholm (Linaro address)" <leif.lindholm@linaro.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: load boot options from platform
Date: Tue, 17 Apr 2018 11:45:24 +0200	[thread overview]
Message-ID: <02a34f37-b883-2b62-9621-23a69f82ca1d@redhat.com> (raw)
In-Reply-To: <05a9ecea-7ef2-1271-4326-9470078095d5@redhat.com>

On 04/17/18 11:02, Laszlo Ersek wrote:

> Whereas, if the option is *not* found in the original array, then you
> add it -- and then EfiBootManagerAddLoadOptionVariable() *modifies*
> "NewOption.OptionNumber", from "LoadOptionNumberUnassigned" to the
> actual #### assigned.

This may not have been obvious from the
EfiBootManagerAddLoadOptionVariable() prototype and/or documentation;
I've just submitted a patch to fix that:

[edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: fix
AddLoadOptionVariable docs/prototype

Laszlo


  reply	other threads:[~2018-04-17  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17  5:11 [PATCH v2 0/1] load boot options from platform Haojian Zhuang
2018-04-17  5:11 ` [PATCH v2 1/1] ArmPkg/PlatformBootManagerLib: " Haojian Zhuang
2018-04-17  9:02   ` Laszlo Ersek
2018-04-17  9:45     ` Laszlo Ersek [this message]
2018-04-19  9:30     ` Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02a34f37-b883-2b62-9621-23a69f82ca1d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox