From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.9066.1599120473166191129 for ; Thu, 03 Sep 2020 01:07:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NSUo7ELB; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599120472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KLnhtu2AmgpGnqvQ5FgQg5beaGM/6PWaOHPIXW+U7yM=; b=NSUo7ELBY9yqD47V5B+e0V0DVJ0EX5FhbTykqRxOVFnLIS5Cs4tp+Gr97i9p5i2hG67KkX 3p+nLQe/HK/DAM0MV/9iGRh50Fge6aDu9HkTdcp8dl273z/zrgAksxuutq1HC/ma793nUS jMGTC7GxnQefTQzgt1zeEXQx2dpza2E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-HB9gBC3fN2eisNFDGX0TCw-1; Thu, 03 Sep 2020 04:07:42 -0400 X-MC-Unique: HB9gBC3fN2eisNFDGX0TCw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 65B031008564; Thu, 3 Sep 2020 08:07:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-168.ams2.redhat.com [10.36.112.168]) by smtp.corp.redhat.com (Postfix) with ESMTP id F2524672CF; Thu, 3 Sep 2020 08:07:39 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] Revert ".pytool/EccCheck: Disable Ecc error code 10014 for open CI" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao References: <20200903065608.110000-1-shenglei.zhang@intel.com> From: "Laszlo Ersek" Message-ID: <02a524e2-d2ae-a602-decb-e920c1877baf@redhat.com> Date: Thu, 3 Sep 2020 10:07:38 +0200 MIME-Version: 1.0 In-Reply-To: <20200903065608.110000-1-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 09/03/20 08:56, Zhang, Shenglei wrote: > This reverts commit d4e0b9607c9a64a8eff20724b2e35ea2cd5bd33f. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2951 > Previously false positive Ecc issue whose error code is 10014 was reported > under Linux OS. So we disabled it in EccCheck plugin for edk2 open CI. > As the bug is fixed, we need to revert the change and re-enbale it. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .pytool/Plugin/EccCheck/EccCheck.py | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccCheck/EccCheck.py > index 3eaad0bf5623..eee1ff7a77b5 100644 > --- a/.pytool/Plugin/EccCheck/EccCheck.py > +++ b/.pytool/Plugin/EccCheck/EccCheck.py > @@ -301,7 +301,6 @@ class EccCheck(ICiBuildPlugin): > "10011", > "10012", > "10013", > - "10014", #need to be removed after BZ2904 is fixed > "10015", > "10016", > "10017", > Reviewed-by: Laszlo Ersek Liming, can you please merge this? If so, please fix a typo in the commit message: "re-enbale" should be "re-enable". Thanks! Laszlo