From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by mx.groups.io with SMTP id smtpd.web10.3544.1582163072020092495 for ; Wed, 19 Feb 2020 17:44:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hSxt9ThQ; spf=pass (domain: gmail.com, ip: 209.85.214.194, mailfrom: newexplorerj@gmail.com) Received: by mail-pl1-f194.google.com with SMTP id y8so866767pll.13 for ; Wed, 19 Feb 2020 17:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=ODgFA3El/kPRVY/FqAogfgsMXDalL7oe4TlYVx/InWM=; b=hSxt9ThQRtGmNl89ExLMRjwU6ZV/GnDGhT1jYM3iBM11v5bFJNW8TH1FcaS/nT903U DKWofZD76E5kKO+BxlwUs0ALl9ndlTZAgJiIbScAFVeeJk/p2+wqEwuprxCtuZzaHwXZ fg1hee4YBZ751UW4R7c6hUVx3lVehnwQcagsyPacgsv5eMwPePQCUdGe9hHy9GdQpkSk haYSaTkHOGmdSFi0UaYGh2shRxrrWxL7ujwcIVv1IkKXs/0WDqbQ3bCLNmnowpdmayST G1JjV1ZKyfthg+Z6NHrKFehHi8I106TaNRR1Fjq8nsftNftIUkvARPuRf4m9wVJwb5Rb zZ5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ODgFA3El/kPRVY/FqAogfgsMXDalL7oe4TlYVx/InWM=; b=Ad+9NC3EJEP5EoDMbaAXGH3Zi1FmKGLfxp8D8+6Cii+0y8xpJ6Hqm2XtB6tLxdaZbU SgDzdfByxGppSOYVD196I+F2173iHluTvPdPxQfNZQA5ymK40/Ae8p7Lur1yzKmvjzXX YOrJo3njOa0FkFJiKyGzRA7ukrRBM4HtytsOltov986EtjQcFFBCEOwPoqkeY52/t83S 3Hw8yKgJqtS6STFKUYg3X2P3rT3r9FF93BXCVjfWOYD6+2SaHzi1noOusmxSt/DnXE8x zJU7BMviNA/wCSWnA0QHDCTt53jmHMf6/g07rOemkWM2qk6QY9MiHaHi0C4x0yYJORM/ e7Jw== X-Gm-Message-State: APjAAAWVv/ple6Eh9NdrTxaSH2Kh8NOi4yhg8XzBk2rpbwTPg4UbbnGA H3lCxu/PjO37gBuktvdLVvKMi0phy34= X-Google-Smtp-Source: APXvYqzN7lv1+SgKCUXOUd/8IzKxYkWsofCwFq9mWcFMWlMtbOAtl1tlMA1fKi930ey+bxyKaXaQAA== X-Received: by 2002:a17:902:d683:: with SMTP id v3mr29193966ply.134.1582163071108; Wed, 19 Feb 2020 17:44:31 -0800 (PST) Return-Path: Received: from localhost.localdomain ([223.104.4.131]) by smtp.gmail.com with ESMTPSA id v4sm858258pff.174.2020.02.19.17.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 17:44:30 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [PATCH] UnitTestFrameworkPkg: Invalid index may be used. Date: Thu, 20 Feb 2020 09:41:56 +0800 Message-Id: <02ae08887ff10e981ee247a74ce2e89eb1a4d747.1582162590.git.newexplorerj@gmail.com> X-Mailer: git-send-email 2.17.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2535 The UINT_TEST_STATUS and FAILURE_TYPE have used 0 as status, so use 0 as unknown is confused, remove it from array enumeration but keep it location in the array. Signed-off-by: GuoMinJ --- .../Library/UnitTestResultReportLib/UnitTestResultReportLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c index 687a04f55d..eba68e330c 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c +++ b/UnitTestFrameworkPkg/Library/UnitTestResultReportLib/UnitTestResultReportLib.c @@ -65,7 +65,7 @@ GetStringForUnitTestStatus ( { UINTN Index; - for (Index = 0; Index < ARRAY_SIZE (mStatusStrings); Index++) { + for (Index = 0; Index < ARRAY_SIZE (mStatusStrings) - 1; Index++) { if (mStatusStrings[Index].Status == Status) { // // Return string from matching entry @@ -87,7 +87,7 @@ GetStringForFailureType ( { UINTN Index; - for (Index = 0; Index < ARRAY_SIZE (mFailureTypeStrings); Index++) { + for (Index = 0; Index < ARRAY_SIZE (mFailureTypeStrings) - 1; Index++) { if (mFailureTypeStrings[Index].Type == Failure) { // // Return string from matching entry -- 2.17.1