* Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
[not found] <20240102172630.111466-1-pierre.gondois@...>
@ 2024-01-08 8:48 ` PierreGondois
2024-01-12 14:36 ` Sami Mujawar
0 siblings, 1 reply; 4+ messages in thread
From: PierreGondois @ 2024-01-08 8:48 UTC (permalink / raw)
To: devel
Cc: Kinney, Michael D, Liming Gao, Zhiguang Liu, Leif Lindholm,
Sami Mujawar, Ray Ni, Pierre Gondois
Hello MdePkg Maintainers,
I forgot to include Liming's Reviewed-by tag:
https://edk2.groups.io/g/devel/message/112348
Regards,
Pierre
On 1/2/24 18:26, PierreGondois wrote:
> Add definitions for:
> - _PSD version: added in ACPI 3.0
> - C-state Coordination Types: added in ACPI 3.0
> - _CPC version: added in ACPI 5.0
>
> Signed-off-by: Pierre Gondois <pierre.gondois@...>
> Reviewed-by: Sami Mujawar <sami.mujawar@...>
> ---
>
> Notes:
> v2:
> - Correct EFI_ACPI_5_1_AML_CPC_REVISION value [Sami]
>
> MdePkg/Include/IndustryStandard/Acpi30.h | 14 ++++++++++++++
> MdePkg/Include/IndustryStandard/Acpi40.h | 5 +++++
> MdePkg/Include/IndustryStandard/Acpi50.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi51.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi60.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi61.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi62.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi63.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi64.h | 10 ++++++++++
> MdePkg/Include/IndustryStandard/Acpi65.h | 10 ++++++++++
> 10 files changed, 99 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi30.h b/MdePkg/Include/IndustryStandard/Acpi30.h
> index 29f0d5535593..cb50b1d8f71a 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi30.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi30.h
> @@ -17,6 +17,20 @@
>
> #define ACPI_EXTENDED_ADDRESS_SPACE_DESCRIPTOR 0x8B
>
> +///
> +/// C-state Coordination Types
> +/// See s8.4.2.2 _CSD (C-State Dependency)
> +///
> +#define ACPI_AML_COORD_TYPE_SW_ALL 0xFC
> +#define ACPI_AML_COORD_TYPE_SW_ANY 0xFD
> +#define ACPI_AML_COORD_TYPE_HW_ALL 0xFE
> +
> +///
> +/// _PSD Revision for ACPI 3.0
> +// See s8.4.4.5 _PSD (P-State Dependency)
> +///
> +#define EFI_ACPI_3_0_AML_PSD_REVISION 0
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi40.h b/MdePkg/Include/IndustryStandard/Acpi40.h
> index a2da09346f1c..0e30f4f8417d 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi40.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi40.h
> @@ -10,6 +10,11 @@
>
> #include <IndustryStandard/Acpi30.h>
>
> +///
> +/// _PSD Revision for ACPI 4.0
> +///
> +#define EFI_ACPI_4_0_AML_PSD_REVISION 0
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi50.h b/MdePkg/Include/IndustryStandard/Acpi50.h
> index 76706aa640f8..a00b8259b8f7 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi50.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi50.h
> @@ -23,6 +23,16 @@
> #define ACPI_GPIO_CONNECTION_DESCRIPTOR 0x8C
> #define ACPI_GENERIC_SERIAL_BUS_CONNECTION_DESCRIPTOR 0x8E
>
> +///
> +/// _PSD Revision for ACPI 5.0
> +///
> +#define EFI_ACPI_5_0_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 5.0
> +///
> +#define EFI_ACPI_5_0_AML_CPC_REVISION 1
> +
> #pragma pack(1)
>
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi51.h b/MdePkg/Include/IndustryStandard/Acpi51.h
> index 01ef544c3a29..4241b8f198f1 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi51.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi51.h
> @@ -13,6 +13,16 @@
>
> #include <IndustryStandard/Acpi50.h>
>
> +///
> +/// _PSD Revision for ACPI 5.1
> +///
> +#define EFI_ACPI_5_1_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 5.1
> +///
> +#define EFI_ACPI_5_1_AML_CPC_REVISION 2
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi60.h b/MdePkg/Include/IndustryStandard/Acpi60.h
> index 5ac3be6ad71c..3757d3f82792 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi60.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi60.h
> @@ -12,6 +12,16 @@
>
> #include <IndustryStandard/Acpi51.h>
>
> +///
> +/// _PSD Revision for ACPI 6.0
> +///
> +#define EFI_ACPI_6_0_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.0
> +///
> +#define EFI_ACPI_6_0_AML_CPC_REVISION 2
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi61.h b/MdePkg/Include/IndustryStandard/Acpi61.h
> index 7af67d832bb2..c3facc6e376e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi61.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi61.h
> @@ -12,6 +12,16 @@
>
> #include <IndustryStandard/Acpi60.h>
>
> +///
> +/// _PSD Revision for ACPI 6.1
> +///
> +#define EFI_ACPI_6_1_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.1
> +///
> +#define EFI_ACPI_6_1_AML_CPC_REVISION 2
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi62.h b/MdePkg/Include/IndustryStandard/Acpi62.h
> index e27775a85ade..4dd3e21c2325 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi62.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi62.h
> @@ -29,6 +29,16 @@
> #define ACPI_PIN_GROUP_FUNCTION_DESCRIPTOR 0x91
> #define ACPI_PIN_GROUP_CONFIGURATION_DESCRIPTOR 0x92
>
> +///
> +/// _PSD Revision for ACPI 6.2
> +///
> +#define EFI_ACPI_6_2_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.2
> +///
> +#define EFI_ACPI_6_2_AML_CPC_REVISION 3
> +
> #pragma pack(1)
>
> ///
> diff --git a/MdePkg/Include/IndustryStandard/Acpi63.h b/MdePkg/Include/IndustryStandard/Acpi63.h
> index 10bdf5fe5a57..7582dccf649b 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi63.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi63.h
> @@ -12,6 +12,16 @@
>
> #include <IndustryStandard/Acpi62.h>
>
> +///
> +/// _PSD Revision for ACPI 6.3
> +///
> +#define EFI_ACPI_6_3_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.3
> +///
> +#define EFI_ACPI_6_3_AML_CPC_REVISION 3
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 575ca0430c13..faf069a0454e 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -12,6 +12,16 @@
>
> #include <IndustryStandard/Acpi63.h>
>
> +///
> +/// _PSD Revision for ACPI 6.4
> +///
> +#define EFI_ACPI_6_4_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.4
> +///
> +#define EFI_ACPI_6_4_AML_CPC_REVISION 3
> +
> //
> // Ensure proper structure formats
> //
> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h b/MdePkg/Include/IndustryStandard/Acpi65.h
> index d79d0b2b5f9c..b9616a3e29c2 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi65.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h
> @@ -18,6 +18,16 @@
> //
> #pragma pack(1)
>
> +///
> +/// _PSD Revision for ACPI 6.5
> +///
> +#define EFI_ACPI_6_5_AML_PSD_REVISION 0
> +
> +///
> +/// _CPC Revision for ACPI 6.5
> +///
> +#define EFI_ACPI_6_5_AML_CPC_REVISION 3
> +
> ///
> /// ACPI 6.5 Generic Address Space definition
> ///
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113372): https://edk2.groups.io/g/devel/message/113372
Mute This Topic: https://groups.io/mt/103485754/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
2024-01-08 8:48 ` [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions PierreGondois
@ 2024-01-12 14:36 ` Sami Mujawar
2024-01-16 14:17 ` 回复: " gaoliming via groups.io
0 siblings, 1 reply; 4+ messages in thread
From: Sami Mujawar @ 2024-01-12 14:36 UTC (permalink / raw)
To: PierreGondois, devel
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
Hi Liming,
If there are no further comments on this patch, can you let me know if I can merge this, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113740): https://edk2.groups.io/g/devel/message/113740
Mute This Topic: https://groups.io/mt/103485754/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 942 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
2024-01-12 14:36 ` Sami Mujawar
@ 2024-01-16 14:17 ` gaoliming via groups.io
2024-01-20 3:27 ` Michael D Kinney
0 siblings, 1 reply; 4+ messages in thread
From: gaoliming via groups.io @ 2024-01-16 14:17 UTC (permalink / raw)
To: devel, sami.mujawar, 'PierreGondois'
[-- Attachment #1: Type: text/plain, Size: 891 bytes --]
I am OK to merge it. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sami Mujawar
发送时间: 2024年1月12日 22:37
收件人: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
Hi Liming,
If there are no further comments on this patch, can you let me know if I can merge this, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113900): https://edk2.groups.io/g/devel/message/113900
Mute This Topic: https://groups.io/mt/103762110/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 4441 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
2024-01-16 14:17 ` 回复: " gaoliming via groups.io
@ 2024-01-20 3:27 ` Michael D Kinney
0 siblings, 0 replies; 4+ messages in thread
From: Michael D Kinney @ 2024-01-20 3:27 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn,
sami.mujawar@arm.com, 'PierreGondois'
Cc: Kinney, Michael D
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
Merged: https://github.com/tianocore/edk2/pull/5277
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io
Sent: Tuesday, January 16, 2024 6:18 AM
To: devel@edk2.groups.io; sami.mujawar@arm.com; 'PierreGondois' <pierre.gondois@arm.com>
Subject: 回复: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
I am OK to merge it. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> 代表 Sami Mujawar
发送时间: 2024年1月12日 22:37
收件人: PierreGondois <pierre.gondois@arm.com<mailto:pierre.gondois@arm.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
主题: Re: [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions
Hi Liming,
If there are no further comments on this patch, can you let me know if I can merge this, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114111): https://edk2.groups.io/g/devel/message/114111
Mute This Topic: https://groups.io/mt/103844809/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 6241 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-20 3:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240102172630.111466-1-pierre.gondois@...>
2024-01-08 8:48 ` [edk2-devel] [PATCH v2 1/1] MdePkg/IndustryStandard: Add _PSD/_CPC/Coord types definitions PierreGondois
2024-01-12 14:36 ` Sami Mujawar
2024-01-16 14:17 ` 回复: " gaoliming via groups.io
2024-01-20 3:27 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox