From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id CD7627803D8 for ; Wed, 17 Apr 2024 12:34:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ewUkSHBe23sYFwGtTC10dWouqLppxQXIBfOAzYn7eG8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1713357260; v=1; b=3vjiGL2IqltNNaKSvkCC8ecwpm4tPNZ0NqUmkP0Gs2Eq/9EfTz4QfhT9rSEg/LRpJ8Mt7xMf JelKbQ2V37EdmiuTMFqR8W5gynipt+Rw2Qw9znNcIaTqTm31mi8idL3/hm3EBDeC2fh7wqhEJuV UIzqmlxAjqvAOp7tH8x2XOwWlNdwVeq1s1XWdpBwgaBvWwY+OGbvWUI7WLvFr0rA0vEMeL9r0Fs 8QyRXT8TF5KVe9rqWyPtTxTOwB5dgXf3yVcwSu8yZVxFytNltCNpx3WbuPnF26Q/YOBSzvgwsqA 3rAl00xrE6iSh3U4e58aMCtS1e/N8AJ+WR83r6H2LbVLA== X-Received: by 127.0.0.2 with SMTP id O05vYY7687511x4sMwX8yTzY; Wed, 17 Apr 2024 05:34:20 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.11536.1713357258877107688 for ; Wed, 17 Apr 2024 05:34:19 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C850CDDA7F7 for ; Wed, 17 Apr 2024 20:34:15 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C43C6DDA789 for ; Wed, 17 Apr 2024 20:34:15 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 15F98DDA7F5 for ; Wed, 17 Apr 2024 20:34:12 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.92.234.250]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 17 Apr 2024 20:34:02 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.92.234.250 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , "'Chen, Christine'" , "'Rebecca Cran'" Cc: "'Feng, Bob C'" , "'Chaganty, Rangasai V'" References: <17BBB26EFE5BAF9A.17779@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBCYXNlVG9vbHM6IEZNTVQgU2tpcCBlbXB0eSBMaW5lcyB3aGlsZSBwYXJzaW5nIEZNTVRDb25maWcuaW5p?= Date: Wed, 17 Apr 2024 20:34:05 +0800 Message-ID: <02c701da90c3$89508930$9bf19b90$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIX/RGG7GwlzYHVpyDD1QYFIZRpfwL9V8xeAhrOZ7kB2XBTvrC6ACDQ Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 05:34:19 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xmjaMywX35Ce9RwbSliaKs1Jx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=3vjiGL2I; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io Ashraf: I just merge it.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Ashraf Ali S > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA4=D4=C217=C8=D5 16:36 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; S, Ashraf Ali ; Chen, > Christine ; Rebecca Cran ; > Liming Gao > =B3=AD=CB=CD: Feng, Bob C ; Chaganty, Rangasai V > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines w= hile > parsing FMMTConfig.ini >=20 > Hi @Liming Gao @Rebecca Cran >=20 > Is this patch already pushed? As its been already reviewed. >=20 > Thanks., > S, Ashraf Ali >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ashraf Ali > S > Sent: Monday, March 11, 2024 5:01 PM > To: devel@edk2.groups.io; Chen, Christine > Cc: Rebecca Cran ; Liming Gao > ; Feng, Bob C ; > Chaganty, Rangasai V > Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while > parsing FMMTConfig.ini >=20 > Thanks for the review. >=20 > I have triggered the PR under basetools : > https://github.com/tianocore/edk2-basetools/pull/122 >=20 > Thanks., > S, Ashraf Ali >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Monday, March 11, 2024 1:22 PM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Liming Gao > ; Feng, Bob C ; > Chaganty, Rangasai V > Subject: Re: [edk2-devel] [PATCH] BaseTools: FMMT Skip empty Lines while > parsing FMMTConfig.ini >=20 > Ali, please also create PR in BaseTools repo. > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Wednesday, February 28, 2024 5:57 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali ; Rebecca Cran > > ; Liming Gao ; Feng, > Bob > > C ; Chen, Christine ; > > Chaganty, Rangasai V > > Subject: [PATCH] BaseTools: FMMT Skip empty Lines while parsing > > FMMTConfig.ini > > > > When the FMMTConf.ini file has empty lines then it used to throw > > errors GuidTool load error!, this patch is to skip checking for empty > > lines in the ini file > > > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Yuwei Chen > > Cc: Chen Christine > > Cc: Chaganty Rangasai V > > > > Signed-off-by: Ashraf Ali > > --- > > BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py > > b/BaseTools/Source/Python/FMMT/core/GuidTools.py > > index f6bdeffa50..f9cfd4ead0 100644 > > --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py > > +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py > > @@ -153,7 +153,7 @@ class GUIDTools: > > config_data =3D fd.readlines() > > for line in config_data: > > try: > > - if not line.startswith("#"): > > + if not line.startswith("#") and line.strip(): > > guid, short_name, command =3D line.split() > > new_format_guid =3D > > struct2stream(ModifyGuidFormat(guid.strip())) > > self.tooldef[new_format_guid] =3D GUIDTool( > > -- > > 2.42.0.windows.2 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117918): https://edk2.groups.io/g/devel/message/117918 Mute This Topic: https://groups.io/mt/105575993/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-