From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web12.19448.1611695853884179743 for ; Tue, 26 Jan 2021 13:17:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=oGTCl2Tj; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: ankur.a.arora@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QL09EB007771; Tue, 26 Jan 2021 21:17:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2020-01-29; bh=XA5DNbNkKEVIiOCuw4iZrh0rXv5OyW9ZXhMD9TIUVj0=; b=oGTCl2TjnxpN6tuahv+jJcW8f6i0YMUAW42jqymWIzJEn/c+EYy6//cRCvYSI8QdPLvT ldCm1ItKNvDBpABzxmdyvSS+5+Mzuz0sC8gxJNotCt5a9DuOc/XsySeUP3453sXLdEMA 71zTiJFpDvuTGkhvb1xEXiTTnPeWLjhI2aCsi5OIUyEtl6JZYZR4Clw1zD102Sg/PIPc hrS78PPyCQcGOXDnLilF0x7sdry9nkl8DB0J5HLhjU/lpF3mUQZkB/Z8wXYwgMUC842P PDndp5lYvIru74VWSocNT5nUSiWUBaSPVevi1fgGuSSbSMOz3bbQ26pA+G2sP1haSHaz NQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 368b7qv5bw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 21:17:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 10QL15oV195097; Tue, 26 Jan 2021 21:17:28 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by aserp3030.oracle.com with ESMTP id 368wcnep9h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jan 2021 21:17:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEmbpLWhY9fbIuAFuSfyFqI1GDONrtmSH6efFXXkRH9AV5RXazkj5NjogzGbtUFPHhClNDFXOZfQsMjg/WG9/zMmJuagHwSj5NluAbeZNH61raJKzcOr/GW6VNtGzWaXMZyI7Y0uqEHqXpimL+4hqBExUjDSVMuKt/WFOsG2AnZuC+0OzlEIdnRgOrXsYlb3GqTXdkhGHghz8RVCd1SQTqHyrkydsKX0X72DaXy50uIzVHK9oWwIfXINFyJQubwROkeryERRemN+ICK7fSNLYCqY7zR/z/rhcq55ZQrIR+P4Dp+3GEndKZhZrIuiRq7Zy4w8KK5A//SLb17MngPEeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XA5DNbNkKEVIiOCuw4iZrh0rXv5OyW9ZXhMD9TIUVj0=; b=Zl+zFPdaST/udPpyNuetRYGI4NgDvJs02/iAj7AImUS+V0EanhkMrPtrRVKG8XsCCDhE34em1oWU+7P88ovE/HvweoYUFYHsnYSW2FfcGm736C/Q8kZKaWgFUWbPZhRgrMC1yz660NTjxrEuaOWYqvN80YpzD6OokabrHgHhUkIfX1L6dI92gSuUshz7zvvpU8jp87+lAfZmC9cuwMxYRc6/bn6/GYFd1xZdpX6E5tQH9tTEw3jfXvPf+D/A2187J/9vGq2sZ40ammiCjZlXaDm8RBrbX+EKql2RaEbHT286tVC9UHT3ANGvP/u2P7HYoDmIws+IXcBbM6reZBCNZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XA5DNbNkKEVIiOCuw4iZrh0rXv5OyW9ZXhMD9TIUVj0=; b=r/vC/0WMUpATkdkF0xA17JvScWrp8rCAQpaFMdwRO9Cwe97PSeiGtGvWjYMSQSdcPXUzKTGTiBydEdK1pEuYOc82ziVRuZti+Qmh9gU9XogtgV0gYf64K0X8w2oRsfLbjdcnYGduq0xInAUdt/wI0kB+r1mqXeCzfww6e2mLE+o= Received: from CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) by CY4PR10MB1510.namprd10.prod.outlook.com (2603:10b6:903:2a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.17; Tue, 26 Jan 2021 21:17:26 +0000 Received: from CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6]) by CY4PR10MB1718.namprd10.prod.outlook.com ([fe80::39dc:6ba7:9397:cb6%6]) with mapi id 15.20.3784.019; Tue, 26 Jan 2021 21:17:26 +0000 Subject: Re: [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic To: Laszlo Ersek , devel@edk2.groups.io Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com, Jordan Justen , Ard Biesheuvel , Aaron Young References: <20210126064440.299596-1-ankur.a.arora@oracle.com> <20210126064440.299596-2-ankur.a.arora@oracle.com> <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com> <4a1e8dd7-51e4-165c-64c1-d7d6fea6eafc@oracle.com> <53e8f8dc-99ef-9b13-c92f-e3d63ab39409@redhat.com> From: "Ankur Arora" Message-ID: <02cc6e35-1bc0-9f92-54f8-b26ecaa597c9@oracle.com> Date: Tue, 26 Jan 2021 13:17:23 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 In-Reply-To: <53e8f8dc-99ef-9b13-c92f-e3d63ab39409@redhat.com> X-Originating-IP: [70.36.60.91] X-ClientProxiedBy: MW4PR03CA0181.namprd03.prod.outlook.com (2603:10b6:303:b8::6) To CY4PR10MB1718.namprd10.prod.outlook.com (2603:10b6:910:9::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.108] (70.36.60.91) by MW4PR03CA0181.namprd03.prod.outlook.com (2603:10b6:303:b8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12 via Frontend Transport; Tue, 26 Jan 2021 21:17:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b45a044-c2c3-4f58-ffad-08d8c23fc792 X-MS-TrafficTypeDiagnostic: CY4PR10MB1510: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ot0p5jSbSCzcVM6c58eXuYTQqWVM0k8GKa0k0OJaYbrFP63FhtieHJpxWQOfkuB2pxcI1RtfQSrZ05oT3qwY4oc+0gBepx9TJ3fYQfm0qdUXhA4JxeMPHoI06ob6UxPMqEtpqYpaIW5+r7HnE4HXuEaRfTJGueC3QhuG9HYjsRDFz59htKvHdCnk4C7e6MLYffnCcUKdZYztes5gYBV5fA3FNmMWLI0f3Hm+CA4VIqDQNAHdxRWtd02JFavmCwvx6wr0KDuNjRRA2RjptRQEh88F5dczJ1CJuW+5qOkDNCvkJCdGIQ5bYjnSdd1/LbEtaOXUROBf23gCd+XIYI/JoiIzPjD2BBnep8x5tSAWmDccMdb/s4rFIWqGq1cDtj9Uysx+isEE1RwK8VhgcFtB+RzYHvXCfT673KQNono2lfvbnRBoIPfuYaMNevzvN2l0EQ1bxtp73Y9Bw1qMKPn5R971sBuNeHUCDveqMysp5xNivFOJfK6nL9QQQMFVme5lzfyv1co0YXAENPptpu5y/tVzyn8jJZTD9RM0zetjkN+MqcvYF7eRK5Ch20/eys5AZprpbrpuoa1pJsqw0UozNBUlcqalDgf6btLdOWBCVv8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY4PR10MB1718.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(346002)(39860400002)(376002)(396003)(366004)(16526019)(26005)(186003)(36756003)(2906002)(316002)(16576012)(478600001)(8676002)(4326008)(53546011)(2616005)(956004)(6486002)(31686004)(66476007)(5660300002)(66946007)(31696002)(86362001)(66556008)(54906003)(8936002)(107886003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Umc2YThWUTVFU1Z2aDhmZkdSekdzdXFoV2gwL0pZMmZ2SExMRm84dkh3a3pK?= =?utf-8?B?Vkt6ek9RdGg5WThpQkFpdUp5dmlLejYzOGhwN3FLYXd5d2J4cndhVVdSdzl3?= =?utf-8?B?elJjaVhkSUxpOTFXZU1keDh0dzBrcU01QTBJTnFTTUVablRTcityMzVuSE91?= =?utf-8?B?MDNlakZpaHV3S0k1T2lDNnBUcEJvOEZkd2NTL2dxalZSMmZkRC9sQ2NhRnFt?= =?utf-8?B?RVN5dEZsNGkzWHdzWnBqSzE4NlRqbS80R0lnUDlvYkxiakdTeUZHaTFzK1dy?= =?utf-8?B?aTZ3d3lmN1Q1ekMyWlFXbEViMVJwajRQSVdZK2lubzF5Z2hvR3E4NXBKVitj?= =?utf-8?B?NFhFVGdnUTdNQ3d0Zks3R29lU1ZIQndwdnU3RFRyWXNOVEtRenF2Ti9FK25t?= =?utf-8?B?U21saTFhN1NGeUJuMy94b3lWWTVhQjdPMzVsUnNvb3RMdGFIOUoxekNzcUdY?= =?utf-8?B?SlVhc2QzdmxxMVZBWDl3aUM0NDNreGk5ckhhSXpteHl4anVHOXVYS0dSY2Ez?= =?utf-8?B?aEtrYzNwcDdneEdNV1p4MUN0elJZTGdsWEpEUkZ6L1orcS9rTFZrc1FMWjl5?= =?utf-8?B?NWJRckpOZ2N4TjZaRzgza1ZaTHJmTGw0YmlTbGVZQ2lxaGhubHRIcUNOTFNn?= =?utf-8?B?ODg2eXZyKzh5bEFuK1VDRlR4enNSNjdFY0ZBQ0F0Vk5uK0JORjJYQ1JIYVhr?= =?utf-8?B?K0tvcFFNV1JNQUEzZzhCTG1UTndxLzNZVHB1RFZlR2twbG9FZzQwTlo4bWQr?= =?utf-8?B?ZFB1WlJpNVBybDV4T2RFNmFhV0l4b0dvSmg4bjdRYW9uM2NzUWZZOVdBa09O?= =?utf-8?B?OThHNkMyR1QzOWlydklWK2VZSjh6aUovYTNEclg2aVgxR2s0V3d2Q0ZuZXRU?= =?utf-8?B?cUpTcUh2dlZxQXF0emVpSUNyVVcrVG1YY2RnckhIMVF1azYrNWlsTmZyUE83?= =?utf-8?B?M3hjaXNoV3RadUNaN2IwbGxVYi9yQkZlcEczblVuaFRhVm9Jbm5uemt3SSta?= =?utf-8?B?Vk5jb2ZiNDJjOGdIeTBYRFgzUVAyQWNOL0NpTUl4M0ptUmh6NGJ5U0QwdFJD?= =?utf-8?B?UlhtZmQ2Tm9FdXdKSFhJWEdiSEI4c1phMEFqbU1TR1J5UkNCaVVQZ3Y2MG42?= =?utf-8?B?UlR4VWQ2d25yQjNTUTM0bEUyaGYyUldZcmZQRTZlWW9qTVJtTzJBczRGVUdE?= =?utf-8?B?SU14Q1R0YXNFS0NUYTY1dWsrcytTYUdUeFVNQWlDRlppcDQySlZQaFg1RENi?= =?utf-8?B?d0ZHRERWajd0YVhGZnZGc2NDYUZ6YUFEWVpacktLQ2FES0N3amdaczcwaEV1?= =?utf-8?B?bURFSEFQRlFxNDlmNTZrVDVYcmI2eDl0alpoNm5sTkttQkIwUnc3amNVTndL?= =?utf-8?B?VCtnWDFaOXc3ZmVlaThMakptaTM1VXZGOTFmaEN2bmI0RlBSbU5xMzZsTWV2?= =?utf-8?Q?zhM8qSd+?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b45a044-c2c3-4f58-ffad-08d8c23fc792 X-MS-Exchange-CrossTenant-AuthSource: CY4PR10MB1718.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2021 21:17:26.1822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nn0sIBSfhJiDwNsXIhgtQpsYMxB6xMnadv8+bbv/U8V+t4HJSqNkGfgxAMguPuYHRC6gIC2aXPtyJKKoWsZYAtbgQMaFvKdDFTJ9XYUKOIE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1510 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260109 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9876 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101260109 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2021-01-26 1:07 p.m., Laszlo Ersek wrote: > On 01/26/21 20:15, Ankur Arora wrote: >> On 2021-01-26 11:01 a.m., Laszlo Ersek wrote: > >>> I'll continue the review later this week. >> >> Acking the comments above. > > Thank you! > >> Meanwhile let me reprocess the series in light of the comments above. > > I'm at such a point now, during the v5 review, that I think I can easily > re-sync. > > In general, I don't mind the posting of a new version of a series > mid-review, *IF* we agree about it in advance. > > If you prefer to post a v6, for addressing the comments I've made thus > far, I'm OK with that. If you'd like me to continue reviewing v5, I'm > also OK with that. > > So it's up to you -- please state your decision, so that I know if I > should proceed with v5 (later this week), or wait for v6. I think I would prefer to send v6. Looking at the v5 comments so far, I'm sure that there's a lot of non conforming coding style issues. Addressing them now (or at least a hopefully significant subset) would probably save time. I'm looking at sending these out by Thursday morning PT, and given that you plan to continue later this week, sounds like it might not lose too much review time either. Thanks Ankur > > Thanks! > Laszlo >