public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <guomin.jiang@intel.com>,
	"'Kinney, Michael D'" <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the binary size
Date: Tue, 1 Mar 2022 09:47:33 +0800	[thread overview]
Message-ID: <02cd01d82d0e$524a9040$f6dfb0c0$@byosoft.com.cn> (raw)
In-Reply-To: <BN0PR11MB5696F650D822DFBA73A1EC4A9D3A9@BN0PR11MB5696.namprd11.prod.outlook.com>

Guomin:
  I add my comments. 

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Guomin Jiang
> 发送时间: 2022年2月21日 9:31
> 收件人: Kinney, Michael D <michael.d.kinney@intel.com>;
> devel@edk2.groups.io
> 主题: Re: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the
> binary size
> 
> Comment inline
> 
> Thank
> Guomin
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Friday, February 18, 2022 11:34 AM
> > To: devel@edk2.groups.io; Jiang, Guomin <guomin.jiang@intel.com>;
> Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the
> > binary size
> >
> > Guomin,
> >
> > I think there is a cleaner solution to this problem using compiler flags to
> > change the contents of the __FILE__ macro.
> 
> Thanks for your information. It is useful.
> 1. From the link, it seem that the VS haven't support it yet.
> 2. From my though, It is not good solution that we have strong depend on
> compiler.

Why do you think the compiler option is not good option? If the compiler supports such option, 
it will reduce the customization in Edk2 BaseTools. 

> 
> >
> > https://blog.conan.io/2019/09/02/Deterministic-builds-with-C-C++.html
> > https://reproducible-builds.org/docs/build-path/
> > https://developercommunity.visualstudio.com/t/map-file-to-a-relative-
> > path/1393881
> >
> > I found this content when I was working on the CompareBuild tool and using
> > these techniques can guarantee the same binaries are produced when the
> > path to WORKSPACE is different on different build systems.
> >
> 
> 
> > Does your change provide a module-relative, package-relative, or
> > workspace-relative file path in the ASSERT()?
> 
> No, I only use filename to replace the __FILE__

This solution changes FILE from full path to file name. It can reduce the image size. 
But, it loses the file path information. If the developer doesn't care the image size, 
how does he enable the full patch file information in ASSERT?

> 
> >
> > How does ASSERT() in autogen work?
> >
> 
> It is need to do some POC.

ASSERT works in autogen.c. But, the different modules have the same AutoGen.c file. 
If ASSERT happens in AutoGen.c, only AutoGen.c print in debug message. The developer 
may not know which this AutoGen.c is from.  

Thanks
Liming
> 
> > Thanks,
> >
> > Mike
> >
> >
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Guomin
> > > Jiang
> > > Sent: Thursday, February 17, 2022 6:30 PM
> > > To: devel@edk2.groups.io
> > > Subject: [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the
> > > binary size
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3840
> > >
> > > 1. Use DEBUG_FILE to control ASSERT path 2. Default use file name as
> > > ASSERT path
> > >
> > > Motivation and Goal:
> > > 1. The path will occupy many size in DEBUG build when file path is
> > > long 2. We hope can reduce the size but not impact the debug
> > > capability 3. If only use filename, we can search the filename to locate file.
> > It
> > >    can save many size meanwhile.
> > >
> > > Guomin Jiang (2):
> > >   BaseTools/Conf: Reduce the ASSERT patch to save the binary size
> > >   MdePkg/Include: Define new DEBUG_FILE to specify path.
> > >
> > >  BaseTools/Conf/build_rule.template | 10 ++++----
> > > MdePkg/Include/Library/DebugLib.h  | 39
> +++++++++++++++++++++------
> > ---
> > >  2 files changed, 33 insertions(+), 16 deletions(-)
> > >
> > > --
> > > 2.35.1.windows.2
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 
> 




  reply	other threads:[~2022-03-01  1:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  2:30 [PATCH 0/2] Reduce the ASSERT patch to save the binary size Guomin Jiang
2022-02-18  2:30 ` [PATCH 1/2] BaseTools/Conf: " Guomin Jiang
2022-02-28  9:52   ` Bob Feng
2022-03-01  0:47     ` Guomin Jiang
2022-02-18  2:30 ` [PATCH 2/2] MdePkg/Include: Define new DEBUG_FILE to specify path Guomin Jiang
2022-02-18  3:33 ` [edk2-devel] [PATCH 0/2] Reduce the ASSERT patch to save the binary size Michael D Kinney
2022-02-21  1:30   ` Guomin Jiang
2022-03-01  1:47     ` gaoliming [this message]
     [not found] ` <16D4C08DC1603ADF.6551@groups.io>
2022-02-24  2:33   ` [edk2-devel] [PATCH 2/2] MdePkg/Include: Define new DEBUG_FILE to specify path Guomin Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02cd01d82d0e$524a9040$f6dfb0c0$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox