From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.67; helo=mail-wr1-f67.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 13FE321B02822 for ; Tue, 6 Nov 2018 12:32:03 -0800 (PST) Received: by mail-wr1-f67.google.com with SMTP id y15-v6so15030931wru.9 for ; Tue, 06 Nov 2018 12:32:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bEvLCsj4y3tLQtctRmecEUpU6VaYO012uowIolsR1Zo=; b=a0K1jIEtwPLFzs3Rc6+RuCvn0/UJBLtBWqm2mxbtDFJOAjPHx9Mt/EPuadRpCpIjNs HQsapst1ucggtvALTtK3uptNuxzDHMds1IDKEcCILYsacHbgWexUkxGtBOrIhqFwloys opSiKJdi01X8oGJ9+ANhJ+QTKigq79qduet/fkzPI04pR9ljhC6PLMRhFGqYpfSxWkYB T/h1MsC2jiSoKAUVphsQh+2/yIPTT+FQ/NS5GVybpIESb3iJaC/1IbvEvHJL7JMwL8zY i7COe2/DPnMCI8KT4WtTH3gMcKfXit6qR6onMISFg/yiUhaosuxj77arg6I+C7NX0uaV Cr+A== X-Gm-Message-State: AGRZ1gKaNcUHlRU3mZdUKzV7WHDHuqYgV7NZqhK2ETLY0/WyfzXU8cGc i/WiJCE8F6kZWEHCsavx6jfOjPmbsUY= X-Google-Smtp-Source: AJdET5c9P65NdUFmWRBHZngeZ+We0/sQilulaWzJa/IKF4/Hhb3Dd+8txHxE4T+vUBP7TUrOZpHyQg== X-Received: by 2002:a5d:570d:: with SMTP id a13-v6mr26293003wrv.289.1541536322449; Tue, 06 Nov 2018 12:32:02 -0800 (PST) Received: from [192.168.1.74] (67.23.27.109.rev.sfr.net. [109.27.23.67]) by smtp.gmail.com with ESMTPSA id f18-v6sm29421580wre.86.2018.11.06.12.32.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 12:32:01 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: michael.d.kinney@intel.com, eric.jin@intel.com References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-10-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <02cd4706-221e-3f21-f652-efcdc378973c@redhat.com> Date: Tue, 6 Nov 2018 21:31:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181106175833.26964-10-ard.biesheuvel@linaro.org> Subject: Re: [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:32:04 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, On 6/11/18 18:58, Ard Biesheuvel wrote: > UINT8 and CHAR8 are not the same underlying type on all architectures, > so add an explicit cast where necessary. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/Hii.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/Hii.c b/IntelUndiPkg/GigUndiDxe/Hii.c > index a5d8ae207819..737a59fbbbac 100644 > --- a/IntelUndiPkg/GigUndiDxe/Hii.c > +++ b/IntelUndiPkg/GigUndiDxe/Hii.c > @@ -817,7 +817,7 @@ HiiSetMenuStrings ( > > Status = ReadPbaString ( > &UndiPrivateData->NicInfo, > - PBAString8, > + (UINT8 *)PBAString8, > MAX_PBA_STR_LENGTH > ); > if (Status == EFI_SUCCESS) { > I'm not sure why ReadPbaString() takes UINT8* instead of CHAR8*. Having the device part number stored into a CHAR8[] seems correct, what do you think?