From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5A5E074003C for ; Fri, 1 Mar 2024 12:44:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=EXLuvTHkCMA+L67IU7oA0uzGH4ku0VglSMFE//ze3+c=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1709297069; v=1; b=wk7Wt1qT8rLfWEj/BcSX6CfPks0nVjChODM7Hix4DbFOcJ681nM+xdWJZ+eO6w0yQpUZT1Yz IHiyQPULaVgytypXnZmPnUYk2c9rGGSifyUccPc1qWJe3/XpQvJFz8hL3OugyoRXGxiNAAXRtXR Uky2K6G0QC6KH3T9+12SWd/Y= X-Received: by 127.0.0.2 with SMTP id akpQYY7687511xk20YgR0WPL; Fri, 01 Mar 2024 04:44:29 -0800 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.21633.1709297068200245565 for ; Fri, 01 Mar 2024 04:44:29 -0800 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C7F01DDA79F for ; Fri, 1 Mar 2024 20:44:25 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C3258DDA78B for ; Fri, 1 Mar 2024 20:44:25 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 2233FDDA785 for ; Fri, 1 Mar 2024 20:44:22 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.93.194.54]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Fri, 01 Mar 2024 20:44:14 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.93.194.54 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Gerd Hoffmann'" , Cc: "'Michael Roth'" , "'Jiewen Yao'" , "'Laszlo Ersek'" , "'Tom Lendacky'" , "'Paolo Bonzini'" , "'Ard Biesheuvel'" , "'Min Xu'" , "'Erdem Aktas'" , "'Oliver Steffen'" , "'Ard Biesheuvel'" References: <20240222105407.75735-1-kraxel@redhat.com> <20240222105407.75735-2-kraxel@redhat.com> In-Reply-To: <20240222105407.75735-2-kraxel@redhat.com> Subject: =?UTF-8?B?W2VkazItZGV2ZWxdIOWbnuWkjTogW1BBVENIIHY0IDEvM10gTWRlTW9kdWxlUGtnL0R4ZUlwbFBlaW06IGZpeCBQY2RVc2U1TGV2ZWxQYWdlVGFibGUgYXNzZXJ0?= Date: Fri, 1 Mar 2024 20:44:17 +0800 Message-ID: <02d301da6bd6$2ced3f10$86c7bd30$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQKfDBj2yhqJ/2wTlclUU9fFkM9QeQJrlYmRr4Y3YNA= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gROuICBBqPkSOywRxnCs84cnx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wk7Wt1qT; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Gerd Hoffmann > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA2=D4=C222=C8=D5 18:54 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Michael Roth ; Jiewen Yao > ; Liming Gao ; Laszlo > Ersek ; Tom Lendacky ; > Paolo Bonzini ; Ard Biesheuvel > ; Gerd Hoffmann ; Min Xu > ; Erdem Aktas ; Oliver > Steffen ; Ard Biesheuvel > =D6=F7=CC=E2: [PATCH v4 1/3] MdeModulePkg/DxeIplPeim: fix > PcdUse5LevelPageTable assert >=20 > PcdUse5LevelPageTable documentation says: >=20 > Indicates if 5-Level Paging will be enabled in long mode. 5-Level > Paging will not be enabled when the PCD is TRUE but CPU doesn't support > 5-Level Paging. >=20 > So running in 4-level paging mode with PcdUse5LevelPageTable=3DTRUE is > possible. The only invalid combination is 5-level paging being active > with PcdUse5LevelPageTable=3DFALSE. >=20 > Fix the ASSERT accordingly. >=20 > Signed-off-by: Gerd Hoffmann > Reviewed-by: Laszlo Ersek > Acked-by: Ard Biesheuvel > --- > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > index 980c2002d4f5..1d240e95966e 100644 > --- a/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > +++ b/MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c > @@ -745,7 +745,9 @@ CreateIdentityMappingPageTables ( > // > Cr4.UintN =3D AsmReadCr4 (); > Page5LevelSupport =3D (Cr4.Bits.LA57 !=3D 0); > - ASSERT (PcdGetBool (PcdUse5LevelPageTable) =3D=3D Page5LevelSupport)= ; > + if (Page5LevelSupport) { > + ASSERT (PcdGetBool (PcdUse5LevelPageTable)); > + } > } else { > // > // If cpu runs in 32bit protected mode PEI, Page table Level in DXE is > decided by PCD and feature capability. > -- > 2.43.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116243): https://edk2.groups.io/g/devel/message/116243 Mute This Topic: https://groups.io/mt/104662570/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-