From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1C25D7803CF for ; Tue, 21 Nov 2023 01:05:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jzJe2xoB00IYAEcSxgXwfEKB9E6DnUIhw6WzgUXhPoE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1700528701; v=1; b=g5RzVwkwa+2MrCoIIU4ZKpv9NKScwOwZITNhksQoddGFGqJTWnwc5hixqY1sR9QXbbva4y5/ GaM+hXhccBgt66n6lqv2VBaq8vegNr9pfPSYZQxj8jOvXEInYIMNUBn/Y/qwDCLbM7NL7CBy3UF V7+oimn25UBo0FugCLmb3Ztg= X-Received: by 127.0.0.2 with SMTP id O6Z8YY7687511x8GD9lbsXxS; Mon, 20 Nov 2023 17:05:01 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.22111.1700528698933978127 for ; Mon, 20 Nov 2023 17:05:00 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 4B3E2A32E1D4 for ; Tue, 21 Nov 2023 09:04:54 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id E9C5EA32E166 for ; Tue, 21 Nov 2023 09:04:53 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 9C969A32DFE1 for ; Tue, 21 Nov 2023 09:04:48 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 21 Nov 2023 09:04:42 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: "'Sami Mujawar'" , "'Laszlo Ersek'" , "'Michael Kinney'" , , , , , Cc: References: <0dfe6159ce24094f914dbe340a5656b95895b808.1700018266.git.ashishsingha@nvidia.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBlZGsyLXN0YWJsZTIwMjMxMTogUmU6IFtlZGsyLWRldmVsXSBbUEFUQ0hdIER5bmFtaWNUYWJsZXNQa2c6IEZpeCBFVEUgX1VJRCBDcmVhdGlvbg==?= Date: Tue, 21 Nov 2023 09:04:44 +0800 Message-ID: <02d401da1c16$b76c0960$26441c20$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJ0Ogkh66K0fRSGs2CBRo++nfmnFgH1AfoQApVqxkqvK2WMMA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EvbndTWUyxzutP5F33vwUzgqx7686176AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=g5RzVwkw; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Sami: I am OK to merge this patch for this stable bug. I will add push label for= https://github.com/tianocore/edk2/pull/5061=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: Sami Mujawar > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2023=E5=B9=B411=E6=9C=8821=E6=97=A5= 0:07 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Laszlo Ersek ; Liming Gao= (Byosoft address) > ; Michael Kinney ; > devel@edk2.groups.io; ashishsingha@nvidia.com; quic_llindhol@quicinc.com; > ardb+tianocore@kernel.org; jbrasen@nvidia.com > =E6=8A=84=E9=80=81: nd@arm.com > =E4=B8=BB=E9=A2=98: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTa= blesPkg: Fix > ETE _UID Creation >=20 > Hi Laszlo, Liming, Mike, >=20 > Please see my response inline marked [SAMI]. >=20 > Regards, >=20 > Sami Mujawar >=20 > On 17/11/2023 09:20 am, Laszlo Ersek wrote: > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > >> Just like CPU _UID, ETE UID also needs to be unique so > >> use AcpiProcessorUid instead of CpuName > >> > >> Signed-off-by: Ashish Singhal > >> --- > >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 > ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Is this a fixup for the recent feature > > > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > > https://edk2.groups.io/g/devel/message/108996 > > > > ? > > > > If so, then I *think* this qualifies to be merged during the hard > > feature freeze (+Liming +Mike), but: >=20 > [SAMI] I raised a bugzilla for this issue at > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4600 >=20 > and have also created a pull request at > https://github.com/tianocore/edk2/pull/5061. >=20 > This patch has also passed the CI checks when I did a draft pull request. >=20 > I am not sure if I can apply the push label as we are in the code freeze > stage. >=20 > Can you advise on how to proceed, please? >=20 > [/SAMI] >=20 > > - I think we should have a "Fixes:" tag in the commit message (for > > pointing out the commit that should have contained the code being > > added/updated now) > > > > - I think we should have a BZ too (also linked into the commit message)= . > > > > Laszlo > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111492): https://edk2.groups.io/g/devel/message/111492 Mute This Topic: https://groups.io/mt/102720225/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-